| Message ID | 20200501072756.25348-1-jonathanh@nvidia.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | arm64: tegra: Fix ethernet phy-mode for Jetson Xavier | expand |
On Fri, May 01, 2020 at 08:27:56AM +0100, Jon Hunter wrote: > The 'phy-mode' property is currently defined as 'rgmii' for Jetson > Xavier. This indicates that the RGMII RX and TX delays are set by the > MAC and the internal delays set by the PHY are not used. > > If the Marvell PHY driver is enabled, such that it is used and not the > generic PHY, ethernet failures are seen (DHCP is failing to obtain an > IP address) and this is caused because the Marvell PHY driver is > disabling the internal RX and TX delays. For Jetson Xavier the internal > PHY RX and TX delay should be used and so fix this by setting the > 'phy-mode' to 'rgmii-id' and not 'rgmii'. > > Cc: stable@vger.kernel.org > > Signed-off-by: Jon Hunter <jonathanh@nvidia.com> > --- > arch/arm64/boot/dts/nvidia/tegra194-p2888.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Added a Fixes: tag and applied to for-5.8/arm64/dt, thanks. Thierry
Hi
[This is an automated email]
This commit has been processed because it contains a -stable tag.
The stable tag indicates that it's relevant for the following trees: all
The bot has tested the following trees: v5.6.8, v5.4.36, v4.19.119, v4.14.177, v4.9.220, v4.4.220.
v5.6.8: Build OK!
v5.4.36: Build OK!
v4.19.119: Build OK!
v4.14.177: Failed to apply! Possible dependencies:
5425fb15d8ee ("arm64: tegra: Add Tegra194 chip device tree")
b8656c673a6b ("arm64: tegra: Add device tree for the Tegra194 P2972-0000 board")
f69ce393ec48 ("arm64: tegra: Add GPIO controller on Tegra194")
f89b58ce71a9 ("arm64: tegra: Add ethernet controller on Tegra194")
v4.9.220: Failed to apply! Possible dependencies:
5425fb15d8ee ("arm64: tegra: Add Tegra194 chip device tree")
99575bceebd6 ("arm64: tegra: Add NVIDIA P2771 board support")
b8656c673a6b ("arm64: tegra: Add device tree for the Tegra194 P2972-0000 board")
f69ce393ec48 ("arm64: tegra: Add GPIO controller on Tegra194")
f89b58ce71a9 ("arm64: tegra: Add ethernet controller on Tegra194")
v4.4.220: Failed to apply! Possible dependencies:
0f279ebdf3ce ("arm64: tegra: Add NVIDIA Tegra132 Norrin support")
2cc85bd90337 ("arm64: tegra: Add NVIDIA P2571 board support")
34b4f6d0599e ("arm64: tegra: Add Tegra132 support")
5425fb15d8ee ("arm64: tegra: Add Tegra194 chip device tree")
5d17ba6e638e ("arm64: tegra: Add support for Google Pixel C")
63023e95bec0 ("arm64: tegra: Add NVIDIA P2371 board support")
99575bceebd6 ("arm64: tegra: Add NVIDIA P2771 board support")
b8656c673a6b ("arm64: tegra: Add device tree for the Tegra194 P2972-0000 board")
f69ce393ec48 ("arm64: tegra: Add GPIO controller on Tegra194")
f89b58ce71a9 ("arm64: tegra: Add ethernet controller on Tegra194")
NOTE: The patch will not be queued to stable trees until it is upstream.
How should we proceed with this patch?
On Wed, May 06, 2020 at 11:42:17PM +0000, Sasha Levin wrote: > Hi > > [This is an automated email] > > This commit has been processed because it contains a -stable tag. > The stable tag indicates that it's relevant for the following trees: all > > The bot has tested the following trees: v5.6.8, v5.4.36, v4.19.119, v4.14.177, v4.9.220, v4.4.220. > > v5.6.8: Build OK! > v5.4.36: Build OK! > v4.19.119: Build OK! > v4.14.177: Failed to apply! Possible dependencies: > 5425fb15d8ee ("arm64: tegra: Add Tegra194 chip device tree") > b8656c673a6b ("arm64: tegra: Add device tree for the Tegra194 P2972-0000 board") > f69ce393ec48 ("arm64: tegra: Add GPIO controller on Tegra194") > f89b58ce71a9 ("arm64: tegra: Add ethernet controller on Tegra194") > > v4.9.220: Failed to apply! Possible dependencies: > 5425fb15d8ee ("arm64: tegra: Add Tegra194 chip device tree") > 99575bceebd6 ("arm64: tegra: Add NVIDIA P2771 board support") > b8656c673a6b ("arm64: tegra: Add device tree for the Tegra194 P2972-0000 board") > f69ce393ec48 ("arm64: tegra: Add GPIO controller on Tegra194") > f89b58ce71a9 ("arm64: tegra: Add ethernet controller on Tegra194") > > v4.4.220: Failed to apply! Possible dependencies: > 0f279ebdf3ce ("arm64: tegra: Add NVIDIA Tegra132 Norrin support") > 2cc85bd90337 ("arm64: tegra: Add NVIDIA P2571 board support") > 34b4f6d0599e ("arm64: tegra: Add Tegra132 support") > 5425fb15d8ee ("arm64: tegra: Add Tegra194 chip device tree") > 5d17ba6e638e ("arm64: tegra: Add support for Google Pixel C") > 63023e95bec0 ("arm64: tegra: Add NVIDIA P2371 board support") > 99575bceebd6 ("arm64: tegra: Add NVIDIA P2771 board support") > b8656c673a6b ("arm64: tegra: Add device tree for the Tegra194 P2972-0000 board") > f69ce393ec48 ("arm64: tegra: Add GPIO controller on Tegra194") > f89b58ce71a9 ("arm64: tegra: Add ethernet controller on Tegra194") > > > NOTE: The patch will not be queued to stable trees until it is upstream. > > How should we proceed with this patch? Tegra194 support was merged into v4.17, so it doesn't make backport this to any stable kernels prior to that. Thierry
diff --git a/arch/arm64/boot/dts/nvidia/tegra194-p2888.dtsi b/arch/arm64/boot/dts/nvidia/tegra194-p2888.dtsi index 623f7d7d216b..8e3136dfdd62 100644 --- a/arch/arm64/boot/dts/nvidia/tegra194-p2888.dtsi +++ b/arch/arm64/boot/dts/nvidia/tegra194-p2888.dtsi @@ -33,7 +33,7 @@ phy-reset-gpios = <&gpio TEGRA194_MAIN_GPIO(G, 5) GPIO_ACTIVE_LOW>; phy-handle = <&phy>; - phy-mode = "rgmii"; + phy-mode = "rgmii-id"; mdio { #address-cells = <1>;
The 'phy-mode' property is currently defined as 'rgmii' for Jetson Xavier. This indicates that the RGMII RX and TX delays are set by the MAC and the internal delays set by the PHY are not used. If the Marvell PHY driver is enabled, such that it is used and not the generic PHY, ethernet failures are seen (DHCP is failing to obtain an IP address) and this is caused because the Marvell PHY driver is disabling the internal RX and TX delays. For Jetson Xavier the internal PHY RX and TX delay should be used and so fix this by setting the 'phy-mode' to 'rgmii-id' and not 'rgmii'. Cc: stable@vger.kernel.org Signed-off-by: Jon Hunter <jonathanh@nvidia.com> --- arch/arm64/boot/dts/nvidia/tegra194-p2888.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)