diff mbox series

[net-next] net: sched: choke: Remove unused inline function choke_set_classid

Message ID 20200505084736.49692-1-yuehaibing@huawei.com
State Accepted
Delegated to: David Miller
Headers show
Series [net-next] net: sched: choke: Remove unused inline function choke_set_classid | expand

Commit Message

Yue Haibing May 5, 2020, 8:47 a.m. UTC
There's no callers in-tree anymore since commit 5952fde10c35 ("net:
sched: choke: remove dead filter classify code")

Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
 net/sched/sch_choke.c | 5 -----
 1 file changed, 5 deletions(-)

Comments

Cong Wang May 5, 2020, 6:22 p.m. UTC | #1
On Tue, May 5, 2020 at 1:49 AM YueHaibing <yuehaibing@huawei.com> wrote:
>
> There's no callers in-tree anymore since commit 5952fde10c35 ("net:
> sched: choke: remove dead filter classify code")

While you are at this, please also remove classid from
struct choke_skb_cb.

Thanks.
David Miller May 5, 2020, 7:46 p.m. UTC | #2
From: YueHaibing <yuehaibing@huawei.com>
Date: Tue, 5 May 2020 16:47:36 +0800

> There's no callers in-tree anymore since commit 5952fde10c35 ("net:
> sched: choke: remove dead filter classify code")
> 
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>

Applied.
diff mbox series

Patch

diff --git a/net/sched/sch_choke.c b/net/sched/sch_choke.c
index a36974e9c601..2d350c734375 100644
--- a/net/sched/sch_choke.c
+++ b/net/sched/sch_choke.c
@@ -142,11 +142,6 @@  static inline struct choke_skb_cb *choke_skb_cb(const struct sk_buff *skb)
 	return (struct choke_skb_cb *)qdisc_skb_cb(skb)->data;
 }
 
-static inline void choke_set_classid(struct sk_buff *skb, u16 classid)
-{
-	choke_skb_cb(skb)->classid = classid;
-}
-
 /*
  * Compare flow of two packets
  *  Returns true only if source and destination address and port match.