| Message ID | 20200502143555.543636-4-pasha.tatashin@soleen.com |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | allow ramoops to collect all kmesg_dump events | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success |
On Sat, May 02, 2020 at 10:35:55AM -0400, Pavel Tatashin wrote: > Currently, it is possible to dump kmesges for panic, or oops. > With dump_all it is possible to dump messages for kmesg_dump events, > for example reboot, halt, shutdown, kexec. Please just collapse this into patch #2. Thanks! -Kees > > Signed-off-by: Pavel Tatashin <pasha.tatashin@soleen.com> > --- > Documentation/devicetree/bindings/reserved-memory/ramoops.txt | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/Documentation/devicetree/bindings/reserved-memory/ramoops.txt b/Documentation/devicetree/bindings/reserved-memory/ramoops.txt > index 0eba562fe5c6..3ce424c9ad4c 100644 > --- a/Documentation/devicetree/bindings/reserved-memory/ramoops.txt > +++ b/Documentation/devicetree/bindings/reserved-memory/ramoops.txt > @@ -47,5 +47,8 @@ Optional properties: > > - no-dump-oops: if present, only dump panics (defaults to panics and oops) > > +- dump-all: if present, dump kernel messages during all kmesg dump events. > + Reasons are specified in include/linux/kmsg_dump.h KMSG_DUMP_* > + > - flags: if present, pass ramoops behavioral flags (defaults to 0, > see include/linux/pstore_ram.h RAMOOPS_FLAG_* for flag values). > -- > 2.25.1 >
On Mon, May 4, 2020 at 3:29 PM Kees Cook <keescook@chromium.org> wrote: > > On Sat, May 02, 2020 at 10:35:55AM -0400, Pavel Tatashin wrote: > > Currently, it is possible to dump kmesges for panic, or oops. > > With dump_all it is possible to dump messages for kmesg_dump events, > > for example reboot, halt, shutdown, kexec. > > Please just collapse this into patch #2. Will do it. Thank you, Pasha
Hi Kees, According to Documentation/devicetree/bindings/submitting-patches.txt, DT binding docs should be separate patches; checkpath.pl also complaints about it. I will keep it as a separate patch in v2. Pasha On Mon, May 4, 2020 at 4:00 PM Pavel Tatashin <pasha.tatashin@soleen.com> wrote: > > On Mon, May 4, 2020 at 3:29 PM Kees Cook <keescook@chromium.org> wrote: > > > > On Sat, May 02, 2020 at 10:35:55AM -0400, Pavel Tatashin wrote: > > > Currently, it is possible to dump kmesges for panic, or oops. > > > With dump_all it is possible to dump messages for kmesg_dump events, > > > for example reboot, halt, shutdown, kexec. > > > > Please just collapse this into patch #2. > > Will do it. > > Thank you, > Pasha
diff --git a/Documentation/devicetree/bindings/reserved-memory/ramoops.txt b/Documentation/devicetree/bindings/reserved-memory/ramoops.txt index 0eba562fe5c6..3ce424c9ad4c 100644 --- a/Documentation/devicetree/bindings/reserved-memory/ramoops.txt +++ b/Documentation/devicetree/bindings/reserved-memory/ramoops.txt @@ -47,5 +47,8 @@ Optional properties: - no-dump-oops: if present, only dump panics (defaults to panics and oops) +- dump-all: if present, dump kernel messages during all kmesg dump events. + Reasons are specified in include/linux/kmsg_dump.h KMSG_DUMP_* + - flags: if present, pass ramoops behavioral flags (defaults to 0, see include/linux/pstore_ram.h RAMOOPS_FLAG_* for flag values).
Currently, it is possible to dump kmesges for panic, or oops. With dump_all it is possible to dump messages for kmesg_dump events, for example reboot, halt, shutdown, kexec. Signed-off-by: Pavel Tatashin <pasha.tatashin@soleen.com> --- Documentation/devicetree/bindings/reserved-memory/ramoops.txt | 3 +++ 1 file changed, 3 insertions(+)