| Message ID | 20200425142239.444381-1-asafka7@gmail.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [1/1] libuv, uvw: bump to versions 1.37.0, 2.5.0_libuv-v1.37 | expand |
On Sat, 25 Apr 2020 17:22:39 +0300 Asaf Kahlon <asafka7@gmail.com> wrote: > Signed-off-by: Asaf Kahlon <asafka7@gmail.com> > --- > package/libuv/libuv.hash | 2 +- > package/libuv/libuv.mk | 2 +- > package/uvw/uvw.hash | 2 +- > package/uvw/uvw.mk | 2 +- > 4 files changed, 4 insertions(+), 4 deletions(-) Applied to master, thanks. Thomas
Hello, On Sat, 25 Apr 2020 17:22:39 +0300 Asaf Kahlon <asafka7@gmail.com> wrote: > Signed-off-by: Asaf Kahlon <asafka7@gmail.com> > --- > package/libuv/libuv.hash | 2 +- > package/libuv/libuv.mk | 2 +- > package/uvw/uvw.hash | 2 +- > package/uvw/uvw.mk | 2 +- > 4 files changed, 4 insertions(+), 4 deletions(-) This update of libuv is causing a build regression in nodejs: https://bugs.busybox.net/show_bug.cgi?id=12826 See also: http://autobuild.buildroot.net/?reason=nodejs% Could you have a look ? By the way, could you create an account on our bug tracker so that we can assign issues to you when relevant ? Thanks a lot! Thomas
Hello Thomas, On Wed, Apr 29, 2020 at 10:56 PM Thomas Petazzoni <thomas.petazzoni@bootlin.com> wrote: > > Hello, > > On Sat, 25 Apr 2020 17:22:39 +0300 > Asaf Kahlon <asafka7@gmail.com> wrote: > > > Signed-off-by: Asaf Kahlon <asafka7@gmail.com> > > --- > > package/libuv/libuv.hash | 2 +- > > package/libuv/libuv.mk | 2 +- > > package/uvw/uvw.hash | 2 +- > > package/uvw/uvw.mk | 2 +- > > 4 files changed, 4 insertions(+), 4 deletions(-) > > This update of libuv is causing a build regression in nodejs: > > https://bugs.busybox.net/show_bug.cgi?id=12826 > > See also: > > http://autobuild.buildroot.net/?reason=nodejs% > > Could you have a look ? > Something with the nodejs autobuild failure looks strange to me. I'm not sure the recent bump of libuv/uvw is the reason for that failure, as I see it's broken for the same reason for a very long time. For example, this failure from the beginning of the month is the same: http://autobuild.buildroot.net/results/af8/af82fd236b536bf1415e5992ca749cd640abd7e9/build-end.log In addition, there's no build failure of nodejs since April 20. Moreover, I've managed to build nodejs with the same configuration stated in the issue. > By the way, could you create an account on our bug tracker so that we > can assign issues to you when relevant ? Yes, I've opened an account. > > Thanks a lot! > > Thomas > -- > Thomas Petazzoni, CTO, Bootlin > Embedded Linux and Kernel engineering > https://bootlin.com Regards, Asaf.
On Fri, 1 May 2020 09:42:31 +0300 Asaf Kahlon <asafka7@gmail.com> wrote: > > This update of libuv is causing a build regression in nodejs: > > > > https://bugs.busybox.net/show_bug.cgi?id=12826 > > > > See also: > > > > http://autobuild.buildroot.net/?reason=nodejs% > > > > Could you have a look ? > > > > Something with the nodejs autobuild failure looks strange to me. > I'm not sure the recent bump of libuv/uvw is the reason for that > failure, as I see > it's broken for the same reason for a very long time. > For example, this failure from the beginning of the month is the same: > http://autobuild.buildroot.net/results/af8/af82fd236b536bf1415e5992ca749cd640abd7e9/build-end.log > In addition, there's no build failure of nodejs since April 20. > Moreover, I've managed to build nodejs with the same configuration > stated in the issue. My statement was mainly based on the bug report at https://bugs.busybox.net/show_bug.cgi?id=12826 where the reporter claimed that reverting commit 7d9ed0a19d8e88b56b389187c38b44563e33e5ab fixed the issue. > > By the way, could you create an account on our bug tracker so that we > > can assign issues to you when relevant ? > > Yes, I've opened an account. Thanks! Thomas
Hello Asaf, Thomas, On Fri, 1 May 2020 09:42:31 +0300, Asaf Kahlon <asafka7@gmail.com> wrote: > Hello Thomas, > > On Wed, Apr 29, 2020 at 10:56 PM Thomas Petazzoni > <thomas.petazzoni@bootlin.com> wrote: > > > > Hello, > > > > On Sat, 25 Apr 2020 17:22:39 +0300 > > Asaf Kahlon <asafka7@gmail.com> wrote: > > > > > Signed-off-by: Asaf Kahlon <asafka7@gmail.com> > > > --- > > > package/libuv/libuv.hash | 2 +- > > > package/libuv/libuv.mk | 2 +- > > > package/uvw/uvw.hash | 2 +- > > > package/uvw/uvw.mk | 2 +- > > > 4 files changed, 4 insertions(+), 4 deletions(-) > > > > This update of libuv is causing a build regression in nodejs: > > > > https://bugs.busybox.net/show_bug.cgi?id=12826 > > > > See also: > > > > http://autobuild.buildroot.net/?reason=nodejs% > > > > Could you have a look ? > > > > Something with the nodejs autobuild failure looks strange to me. > I'm not sure the recent bump of libuv/uvw is the reason for that > failure, as I see > it's broken for the same reason for a very long time. > For example, this failure from the beginning of the month is the same: > http://autobuild.buildroot.net/results/af8/af82fd236b536bf1415e5992ca749cd640abd7e9/build-end.log > In addition, there's no build failure of nodejs since April 20. > Moreover, I've managed to build nodejs with the same configuration > stated in the issue. All the build failures are on branch 2010.11.x...., with libuv-1.33.1 (predating uv_sleep() support).... $ find . -name uv.h | xargs md5sum 9b7749f33952c1fd11e57aeb719712a8 ./node-v12.16.1/deps/uv/include/uv.h 9b7749f33952c1fd11e57aeb719712a8 ./build/host-nodejs-12.16.1/deps/uv/include/uv.h ff13d2ec9cf4d064bc8254771b7fdae1 ./build/libuv-1.33.1/include/uv.h 9b7749f33952c1fd11e57aeb719712a8 ./build/nodejs-12.16.1/deps/uv/include/uv.h 9b7749f33952c1fd11e57aeb719712a8 ./host/include/node/uv.h ff13d2ec9cf4d064bc8254771b7fdae1 ./host/arm-buildroot-linux-gnueabihf/sysroot/usr/include/uv.h ff13d2ec9cf4d064bc8254771b7fdae1 ./target/usr/include/uv.h Seems in sysroot (and target) the libuv-1.33.1 header file is installed, but in host/include/node the one from host-nodejs-12.16.1... Could not reproduce the failure from bug 12826 on 2020.02.1/2020.02.x nor master... Regards, Peter > > > By the way, could you create an account on our bug tracker so that we > > can assign issues to you when relevant ? > > Yes, I've opened an account. > > > > > Thanks a lot! > > > > Thomas > > -- > > Thomas Petazzoni, CTO, Bootlin > > Embedded Linux and Kernel engineering > > https://bootlin.com > > Regards, > Asaf. > _______________________________________________ > buildroot mailing list > buildroot@busybox.net > http://lists.busybox.net/mailman/listinfo/buildroot
diff --git a/package/libuv/libuv.hash b/package/libuv/libuv.hash index 270fba722d..8e1824f397 100644 --- a/package/libuv/libuv.hash +++ b/package/libuv/libuv.hash @@ -1,3 +1,3 @@ # Locally calculated -sha256 ff84a26c79559e511f087aa67925c3b4e0f0aac60cd8039d4d38b292f208ff58 libuv-1.35.0.tar.gz +sha256 7afa3c8a326b3eed02a9addb584ae7e995ae4d30516cad5e1e4af911931162a6 libuv-1.37.0.tar.gz sha256 6d20216ae022fbeed23916f48508fd807ece3d8464992330643b0e64e5c0c24b LICENSE diff --git a/package/libuv/libuv.mk b/package/libuv/libuv.mk index 7e75dcb194..e61f565b54 100644 --- a/package/libuv/libuv.mk +++ b/package/libuv/libuv.mk @@ -6,7 +6,7 @@ # When bumping libuv, check if a new version of uvw is available # and bump it too. -LIBUV_VERSION = 1.35.0 +LIBUV_VERSION = 1.37.0 LIBUV_SITE = $(call github,libuv,libuv,v$(LIBUV_VERSION)) LIBUV_DEPENDENCIES = host-pkgconf LIBUV_INSTALL_STAGING = YES diff --git a/package/uvw/uvw.hash b/package/uvw/uvw.hash index c74db9b916..bdc1524bfe 100644 --- a/package/uvw/uvw.hash +++ b/package/uvw/uvw.hash @@ -1,3 +1,3 @@ # Locally calculated -sha256 578179ee76d010c5c9fb180a1b60e45e9f04968718d62c51ec0f71b43564bab9 uvw-2.3.1_libuv-v1.34.tar.gz +sha256 bae3e0eccee602b3fb86d89db0c69ae2022a92142f50a042f0949da678614a6c uvw-2.5.0_libuv-v1.37.tar.gz sha256 755b2f245af22830c15b60c54469c0d92fbed42009b0d0074cec4b3959905757 LICENSE diff --git a/package/uvw/uvw.mk b/package/uvw/uvw.mk index 71b23b2ac1..98c61c80ac 100644 --- a/package/uvw/uvw.mk +++ b/package/uvw/uvw.mk @@ -4,7 +4,7 @@ # ################################################################################ -UVW_VERSION = 2.3.1_libuv-v1.34 +UVW_VERSION = 2.5.0_libuv-v1.37 UVW_SITE = $(call github,skypjack,uvw,v$(UVW_VERSION)) UVW_INSTALL_STAGING = YES UVW_INSTALL_TARGET = NO
Signed-off-by: Asaf Kahlon <asafka7@gmail.com> --- package/libuv/libuv.hash | 2 +- package/libuv/libuv.mk | 2 +- package/uvw/uvw.hash | 2 +- package/uvw/uvw.mk | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-)