| Message ID | 20200428210854.28088-2-michael@walle.cc |
|---|---|
| State | Changes Requested |
| Delegated to: | David Miller |
| Headers | show |
| Series | [net-next,1/4] net: phy: bcm54140: use genphy_soft_reset() | expand |
On Tue, Apr 28, 2020 at 11:08:52PM +0200, Michael Walle wrote: > Broadcom defines the bits for this PHY as follows: > { oui[24:3], model[6:0], revision[2:0] } > > Thus we have to mask the lower three bits only. > > Fixes: 6937602ed3f9 ("net: phy: add Broadcom BCM54140 support") > Signed-off-by: Michael Walle <michael@walle.cc> Reviewed-by: Andrew Lunn <andrew@lunn.ch> Andrew
On 4/28/20 2:08 PM, Michael Walle wrote: > Broadcom defines the bits for this PHY as follows: > { oui[24:3], model[6:0], revision[2:0] } > > Thus we have to mask the lower three bits only. > > Fixes: 6937602ed3f9 ("net: phy: add Broadcom BCM54140 support") > Signed-off-by: Michael Walle <michael@walle.cc> Reviewed-by: Florian Fainelli <f.fainelli@gmail.com> > --- > > Please note that although this patch contains a Fixes tag its subject > contains the net-next tag, because the commit in question is only in > net-next. Yes, and this is fine, thanks for doing this!
diff --git a/drivers/net/phy/bcm54140.c b/drivers/net/phy/bcm54140.c index eb5dbacc1253..edafc9dc2f63 100644 --- a/drivers/net/phy/bcm54140.c +++ b/drivers/net/phy/bcm54140.c @@ -852,7 +852,7 @@ static int bcm54140_set_tunable(struct phy_device *phydev, static struct phy_driver bcm54140_drivers[] = { { .phy_id = PHY_ID_BCM54140, - .phy_id_mask = 0xfffffff0, + .phy_id_mask = 0xfffffff8, .name = "Broadcom BCM54140", .features = PHY_GBIT_FEATURES, .config_init = bcm54140_config_init, @@ -870,7 +870,7 @@ static struct phy_driver bcm54140_drivers[] = { module_phy_driver(bcm54140_drivers); static struct mdio_device_id __maybe_unused bcm54140_tbl[] = { - { PHY_ID_BCM54140, 0xfffffff0 }, + { PHY_ID_BCM54140, 0xfffffff8 }, { } };
Broadcom defines the bits for this PHY as follows: { oui[24:3], model[6:0], revision[2:0] } Thus we have to mask the lower three bits only. Fixes: 6937602ed3f9 ("net: phy: add Broadcom BCM54140 support") Signed-off-by: Michael Walle <michael@walle.cc> --- Please note that although this patch contains a Fixes tag its subject contains the net-next tag, because the commit in question is only in net-next. drivers/net/phy/bcm54140.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)