| Message ID | 20200427200909.6753-1-b.bilas@grinn-global.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | package/cegui: disable ogre support | expand |
On Mon, 27 Apr 2020 22:09:09 +0200 Bartosz Bilas <b.bilas@grinn-global.com> wrote: > Buildroot's ogre version isn't compatible with current (v0-8-7) cegui > therefore disable support for that. It will be restored when upstream will > switch to the new version. > > Fixes: > - http://autobuild.buildroot.net/results/8ee717ac4d596fc0af274037841ac4ed6862ddaa/ > > Signed-off-by: Bartosz Bilas <b.bilas@grinn-global.com> > --- > package/cegui/cegui.mk | 10 ++-------- > 1 file changed, 2 insertions(+), 8 deletions(-) Applied, thanks. To be honest, I think it was a mistake to support all those optional features without testing them. Xerces, then minizip, now ogre. I would have very much preferred to disable all these features unconditionally, and then people who need them can add the necessary conditions. BTW, are you using cegui in some projects ? Thomas
Hello Thomas, On 27.04.2020 22:19, Thomas Petazzoni wrote: > On Mon, 27 Apr 2020 22:09:09 +0200 > Bartosz Bilas <b.bilas@grinn-global.com> wrote: > >> Buildroot's ogre version isn't compatible with current (v0-8-7) cegui >> therefore disable support for that. It will be restored when upstream will >> switch to the new version. >> >> Fixes: >> - http://autobuild.buildroot.net/results/8ee717ac4d596fc0af274037841ac4ed6862ddaa/ >> >> Signed-off-by: Bartosz Bilas <b.bilas@grinn-global.com> >> --- >> package/cegui/cegui.mk | 10 ++-------- >> 1 file changed, 2 insertions(+), 8 deletions(-) > Applied, thanks. > > To be honest, I think it was a mistake to support all those optional > features without testing them. Xerces, then minizip, now ogre. I would > have very much preferred to disable all these features unconditionally, > and then people who need them can add the necessary conditions. Some of them are fixed on the master branch, some of them came up due to conflict with package version ( such as buildroot's minizip which is actually a fork of original zlib). I've checked some of them but that's tricky to verify every possibility as it's being done by autobuilders but I try to fix that as fast as possible ;) We can disable all of them or check autobuilders results and fix it. I've asked the maintainers about new release which will fix some of the issues so I hope it will be done soon. > > BTW, are you using cegui in some projects ? I'm not but I was. Now I'm trying to keep this package to be built fine under buildroot. > > Thomas
diff --git a/package/cegui/cegui.mk b/package/cegui/cegui.mk index 434201b1f8..673340194a 100644 --- a/package/cegui/cegui.mk +++ b/package/cegui/cegui.mk @@ -10,7 +10,8 @@ CEGUI_LICENSE = MIT CEGUI_LICENSE_FILES = COPYING CEGUI_INSTALL_STAGING = YES CEGUI_CONF_OPTS += -DCEGUI_BUILD_XMLPARSER_XERCES=OFF \ - -DCEGUI_HAS_MINIZIP_RESOURCE_PROVIDER=OFF + -DCEGUI_HAS_MINIZIP_RESOURCE_PROVIDER=OFF \ + -DCEGUI_BUILD_RENDERER_OGRE=OFF CEGUI_DEPENDENCIES = glm \ $(if $(BR2_PACKAGE_LIBGLFW),libglfw) \ $(if $(BR2_PACKAGE_HAS_LIBGL),libgl) \ @@ -25,13 +26,6 @@ else CEGUI_CONF_OPTS += -DCEGUI_USE_EPOXY=OFF endif -ifeq ($(BR2_PACKAGE_OGRE),y) -CEGUI_DEPENDENCIES += ogre -CEGUI_CONF_OPTS += -DCEGUI_BUILD_RENDERER_OGRE=ON -else -CEGUI_CONF_OPTS += -DCEGUI_BUILD_RENDERER_OGRE=OFF -endif - ifeq ($(BR2_PACKAGE_EXPAT),y) CEGUI_DEPENDENCIES += expat CEGUI_CONF_OPTS += -DCEGUI_BUILD_XMLPARSER_EXPAT=ON
Buildroot's ogre version isn't compatible with current (v0-8-7) cegui therefore disable support for that. It will be restored when upstream will switch to the new version. Fixes: - http://autobuild.buildroot.net/results/8ee717ac4d596fc0af274037841ac4ed6862ddaa/ Signed-off-by: Bartosz Bilas <b.bilas@grinn-global.com> --- package/cegui/cegui.mk | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-)