| Message ID | 20200415001244.144623-2-helgaas@kernel.org |
|---|---|
| State | New |
| Headers | show |
| Series | PCI: Don't select Kconfig symbols by default | expand |
On Tue, Apr 14, 2020 at 07:12:41PM -0500, Bjorn Helgaas wrote: > From: Bjorn Helgaas <bhelgaas@google.com> > > Drivers should not be selected by default because that bloats the kernel > for people who don't need them. > > Remove the "default y" for CONFIG_PCI_DRA7XX_HOST. > > Signed-off-by: Bjorn Helgaas <bhelgaas@google.com> > Cc: Kishon Vijay Abraham I <kishon@ti.com> > Cc: linux-omap@vger.kernel.org > --- > drivers/pci/controller/dwc/Kconfig | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/pci/controller/dwc/Kconfig b/drivers/pci/controller/dwc/Kconfig > index 03dcaf65d159..ea335ee7ca8e 100644 > --- a/drivers/pci/controller/dwc/Kconfig > +++ b/drivers/pci/controller/dwc/Kconfig > @@ -26,7 +26,6 @@ config PCI_DRA7XX_HOST > depends on OF && HAS_IOMEM && TI_PIPE3 > select PCIE_DW_HOST > select PCI_DRA7XX > - default y Perhaps 'default y if SOC_DRA7XX'? > help > Enables support for the PCIe controller in the DRA7xx SoC to work in > host mode. There are two instances of PCIe controller in DRA7xx. > -- > 2.26.0.110.g2183baf09c-goog >
On Wed, Apr 22, 2020 at 02:29:57PM -0500, Rob Herring wrote: > On Tue, Apr 14, 2020 at 07:12:41PM -0500, Bjorn Helgaas wrote: > > From: Bjorn Helgaas <bhelgaas@google.com> > > > > Drivers should not be selected by default because that bloats the kernel > > for people who don't need them. > > > > Remove the "default y" for CONFIG_PCI_DRA7XX_HOST. > > > > Signed-off-by: Bjorn Helgaas <bhelgaas@google.com> > > Cc: Kishon Vijay Abraham I <kishon@ti.com> > > Cc: linux-omap@vger.kernel.org > > --- > > drivers/pci/controller/dwc/Kconfig | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/drivers/pci/controller/dwc/Kconfig b/drivers/pci/controller/dwc/Kconfig > > index 03dcaf65d159..ea335ee7ca8e 100644 > > --- a/drivers/pci/controller/dwc/Kconfig > > +++ b/drivers/pci/controller/dwc/Kconfig > > @@ -26,7 +26,6 @@ config PCI_DRA7XX_HOST > > depends on OF && HAS_IOMEM && TI_PIPE3 > > select PCIE_DW_HOST > > select PCI_DRA7XX > > - default y > > Perhaps 'default y if SOC_DRA7XX'? Good idea, I did that.
diff --git a/drivers/pci/controller/dwc/Kconfig b/drivers/pci/controller/dwc/Kconfig index 03dcaf65d159..ea335ee7ca8e 100644 --- a/drivers/pci/controller/dwc/Kconfig +++ b/drivers/pci/controller/dwc/Kconfig @@ -26,7 +26,6 @@ config PCI_DRA7XX_HOST depends on OF && HAS_IOMEM && TI_PIPE3 select PCIE_DW_HOST select PCI_DRA7XX - default y help Enables support for the PCIe controller in the DRA7xx SoC to work in host mode. There are two instances of PCIe controller in DRA7xx.