| Message ID | 20200322182019.32493-1-rayagonda.kokatanur@broadcom.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [v1,1/1] i2c: iproc: generate stop event for slave writes | expand |
On Sun, Mar 22, 2020 at 11:50:19PM +0530, Rayagonda Kokatanur wrote: > When slave status is I2C_SLAVE_RX_END, generate I2C_SLAVE_STOP > event to i2c_client. > > Fixes: c245d94ed106 ("i2c: iproc: Add multi byte read-write support for slave mode") > Signed-off-by: Rayagonda Kokatanur <rayagonda.kokatanur@broadcom.com> Just to make sure: That means the HW has already detected a STOP condition on the bus? > --- > drivers/i2c/busses/i2c-bcm-iproc.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/i2c/busses/i2c-bcm-iproc.c b/drivers/i2c/busses/i2c-bcm-iproc.c > index 30efb7913b2e..b58224b7ba79 100644 > --- a/drivers/i2c/busses/i2c-bcm-iproc.c > +++ b/drivers/i2c/busses/i2c-bcm-iproc.c > @@ -360,6 +360,9 @@ static bool bcm_iproc_i2c_slave_isr(struct bcm_iproc_i2c_dev *iproc_i2c, > value = (u8)((val >> S_RX_DATA_SHIFT) & S_RX_DATA_MASK); > i2c_slave_event(iproc_i2c->slave, > I2C_SLAVE_WRITE_RECEIVED, &value); > + if (rx_status == I2C_SLAVE_RX_END) > + i2c_slave_event(iproc_i2c->slave, > + I2C_SLAVE_STOP, &value); > } > } else if (status & BIT(IS_S_TX_UNDERRUN_SHIFT)) { > /* Master read other than start */ > -- > 2.17.1 >
On Wed, Apr 15, 2020 at 5:59 PM Wolfram Sang <wsa@the-dreams.de> wrote: > > On Sun, Mar 22, 2020 at 11:50:19PM +0530, Rayagonda Kokatanur wrote: > > When slave status is I2C_SLAVE_RX_END, generate I2C_SLAVE_STOP > > event to i2c_client. > > > > Fixes: c245d94ed106 ("i2c: iproc: Add multi byte read-write support for slave mode") > > Signed-off-by: Rayagonda Kokatanur <rayagonda.kokatanur@broadcom.com> > > Just to make sure: That means the HW has already detected a STOP > condition on the bus? Yes. > > > --- > > drivers/i2c/busses/i2c-bcm-iproc.c | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/drivers/i2c/busses/i2c-bcm-iproc.c b/drivers/i2c/busses/i2c-bcm-iproc.c > > index 30efb7913b2e..b58224b7ba79 100644 > > --- a/drivers/i2c/busses/i2c-bcm-iproc.c > > +++ b/drivers/i2c/busses/i2c-bcm-iproc.c > > @@ -360,6 +360,9 @@ static bool bcm_iproc_i2c_slave_isr(struct bcm_iproc_i2c_dev *iproc_i2c, > > value = (u8)((val >> S_RX_DATA_SHIFT) & S_RX_DATA_MASK); > > i2c_slave_event(iproc_i2c->slave, > > I2C_SLAVE_WRITE_RECEIVED, &value); > > + if (rx_status == I2C_SLAVE_RX_END) > > + i2c_slave_event(iproc_i2c->slave, > > + I2C_SLAVE_STOP, &value); > > } > > } else if (status & BIT(IS_S_TX_UNDERRUN_SHIFT)) { > > /* Master read other than start */ > > -- > > 2.17.1 > >
On Sun, Mar 22, 2020 at 11:50:19PM +0530, Rayagonda Kokatanur wrote: > When slave status is I2C_SLAVE_RX_END, generate I2C_SLAVE_STOP > event to i2c_client. > > Fixes: c245d94ed106 ("i2c: iproc: Add multi byte read-write support for slave mode") > Signed-off-by: Rayagonda Kokatanur <rayagonda.kokatanur@broadcom.com> Applied to for-current, thanks!
diff --git a/drivers/i2c/busses/i2c-bcm-iproc.c b/drivers/i2c/busses/i2c-bcm-iproc.c index 30efb7913b2e..b58224b7ba79 100644 --- a/drivers/i2c/busses/i2c-bcm-iproc.c +++ b/drivers/i2c/busses/i2c-bcm-iproc.c @@ -360,6 +360,9 @@ static bool bcm_iproc_i2c_slave_isr(struct bcm_iproc_i2c_dev *iproc_i2c, value = (u8)((val >> S_RX_DATA_SHIFT) & S_RX_DATA_MASK); i2c_slave_event(iproc_i2c->slave, I2C_SLAVE_WRITE_RECEIVED, &value); + if (rx_status == I2C_SLAVE_RX_END) + i2c_slave_event(iproc_i2c->slave, + I2C_SLAVE_STOP, &value); } } else if (status & BIT(IS_S_TX_UNDERRUN_SHIFT)) { /* Master read other than start */
When slave status is I2C_SLAVE_RX_END, generate I2C_SLAVE_STOP event to i2c_client. Fixes: c245d94ed106 ("i2c: iproc: Add multi byte read-write support for slave mode") Signed-off-by: Rayagonda Kokatanur <rayagonda.kokatanur@broadcom.com> --- drivers/i2c/busses/i2c-bcm-iproc.c | 3 +++ 1 file changed, 3 insertions(+)