Message ID | 1586939510-69461-1-git-send-email-xiyuyang19@fudan.edu.cn |
---|---|
State | Awaiting Upstream |
Delegated to: | David Miller |
Headers | show |
Series | batman-adv: Fix refcnt leak in batadv_show_throughput_override | expand |
On Wednesday, 15 April 2020 10:31:50 CEST Xiyu Yang wrote:
[...]
> Fix this issue by calling batadv_hardif_put() before the
[...]
Thanks, fixes for batadv_store_throughput_override [1] and
batadv_show_throughput_override [2] were applied. I've also added the missing
Fixes: line to both patches.
May I ask whether you are still a user of the deprecated sysfs interface or
did you find this in an automated fashion?
Thanks,
Sven
[1] https://git.open-mesh.org/linux-merge.git/commit/cd339d8b14cd895d8333d94d832b05f67f00eefc
[2] https://git.open-mesh.org/linux-merge.git/commit/3d3e548f74fe51aee9a3c9e297518a2655dbc642
On Wed, Apr 15, 2020 at 11:04:02AM +0200, Sven Eckelmann wrote: > On Wednesday, 15 April 2020 10:31:50 CEST Xiyu Yang wrote: > [...] > > Fix this issue by calling batadv_hardif_put() before the > [...] > > Thanks, fixes for batadv_store_throughput_override [1] and > batadv_show_throughput_override [2] were applied. I've also added the missing > Fixes: line to both patches. > > May I ask whether you are still a user of the deprecated sysfs interface or > did you find this in an automated fashion? > > Thanks, > Sven > > [1] https://git.open-mesh.org/linux-merge.git/commit/cd339d8b14cd895d8333d94d832b05f67f00eefc > [2] https://git.open-mesh.org/linux-merge.git/commit/3d3e548f74fe51aee9a3c9e297518a2655dbc642 Thanks for your confirmation! We are looking for some automated ways to find this kind of bug.
diff --git a/net/batman-adv/sysfs.c b/net/batman-adv/sysfs.c index 97736696d042..0f962dcd239e 100644 --- a/net/batman-adv/sysfs.c +++ b/net/batman-adv/sysfs.c @@ -1190,6 +1190,7 @@ static ssize_t batadv_show_throughput_override(struct kobject *kobj, tp_override = atomic_read(&hard_iface->bat_v.throughput_override); + batadv_hardif_put(hard_iface); return sprintf(buff, "%u.%u MBit\n", tp_override / 10, tp_override % 10); }