| Message ID | 20200414041630.5740-3-f.fainelli@gmail.com |
|---|---|
| State | Superseded |
| Delegated to: | David Miller |
| Headers | show |
| Series | net: dsa: b53: Various ARL fixes | expand |
On Mon, Apr 13, 2020 at 09:16:28PM -0700, Florian Fainelli wrote: > When support for the MDB entries was added, the valid bit was correctly > changed to be assigned depending on the remaining port bitmask, that is, > if there were no more ports added to the entry's port bitmask, the entry > now becomes invalid. There was another assignment a few lines below that > would override this which would invalidate entries even when there were > still multiple ports left in the MDB entry. > > Fixes: 5d65b64a3d97 ("net: dsa: b53: Add support for MDB") > Signed-off-by: Florian Fainelli <f.fainelli@gmail.com> Reviewed-by: Andrew Lunn <andrew@lunn.ch> Andrew
diff --git a/drivers/net/dsa/b53/b53_common.c b/drivers/net/dsa/b53/b53_common.c index fa9b9aca7b56..e937bf365490 100644 --- a/drivers/net/dsa/b53/b53_common.c +++ b/drivers/net/dsa/b53/b53_common.c @@ -1561,7 +1561,6 @@ static int b53_arl_op(struct b53_device *dev, int op, int port, ent.is_valid = !!(ent.port); } - ent.is_valid = is_valid; ent.vid = vid; ent.is_static = true; ent.is_age = false;
When support for the MDB entries was added, the valid bit was correctly changed to be assigned depending on the remaining port bitmask, that is, if there were no more ports added to the entry's port bitmask, the entry now becomes invalid. There was another assignment a few lines below that would override this which would invalidate entries even when there were still multiple ports left in the MDB entry. Fixes: 5d65b64a3d97 ("net: dsa: b53: Add support for MDB") Signed-off-by: Florian Fainelli <f.fainelli@gmail.com> --- drivers/net/dsa/b53/b53_common.c | 1 - 1 file changed, 1 deletion(-)