mbox series

[v1,0/4] fix memory leak and compilation warning and rearrange code

Message ID 20200331053406.23063-1-rayagonda.kokatanur@broadcom.com
Headers show
Series fix memory leak and compilation warning and rearrange code | expand

Message

Rayagonda Kokatanur March 31, 2020, 5:34 a.m. UTC 
This patch series adds following,
-Fix possible memory leak in probe()
-Enable R1B response quirk
-Fix compilation warning
-Rearrange the code probe()

Bharat Kumar Reddy Gooty (2):
  drivers: mmc: iproc_sdhci: fix possible memory leak
  drivers: mmc: iproc_sdhci: enable broken R1B response quirk

Rayagonda Kokatanur (2):
  drivers: mmc: iproc_sdhci: fix compilation warning
  drivers: mmc: iproc_sdhci: move host.mmc init before sdhci_setup_cfg

 drivers/mmc/iproc_sdhci.c | 22 +++++++++++++---------
 1 file changed, 13 insertions(+), 9 deletions(-)

Comments

Jaehoon Chung April 2, 2020, 6:02 a.m. UTC | #1 
Hi Rayagonda,

On 3/31/20 2:34 PM, Rayagonda Kokatanur wrote:
> This patch series adds following,
> -Fix possible memory leak in probe()
> -Enable R1B response quirk
> -Fix compilation warning
> -Rearrange the code probe()
> 
> Bharat Kumar Reddy Gooty (2):
>   drivers: mmc: iproc_sdhci: fix possible memory leak
>   drivers: mmc: iproc_sdhci: enable broken R1B response quirk
> 
> Rayagonda Kokatanur (2):
>   drivers: mmc: iproc_sdhci: fix compilation warning
>   drivers: mmc: iproc_sdhci: move host.mmc init before sdhci_setup_cfg

Just minor question..Is there the using target with iproc_sdhci?
I didn't find whre SDHCI_IRPOC is eanble

Best Regards,
Jaehoon Chung

> 
>  drivers/mmc/iproc_sdhci.c | 22 +++++++++++++---------
>  1 file changed, 13 insertions(+), 9 deletions(-)
>
Rayagonda Kokatanur April 2, 2020, 6:08 a.m. UTC | #2 
On Thu, Apr 2, 2020 at 11:32 AM Jaehoon Chung <jh80.chung@samsung.com> wrote:
>
> Hi Rayagonda,
>
> On 3/31/20 2:34 PM, Rayagonda Kokatanur wrote:
> > This patch series adds following,
> > -Fix possible memory leak in probe()
> > -Enable R1B response quirk
> > -Fix compilation warning
> > -Rearrange the code probe()
> >
> > Bharat Kumar Reddy Gooty (2):
> >   drivers: mmc: iproc_sdhci: fix possible memory leak
> >   drivers: mmc: iproc_sdhci: enable broken R1B response quirk
> >
> > Rayagonda Kokatanur (2):
> >   drivers: mmc: iproc_sdhci: fix compilation warning
> >   drivers: mmc: iproc_sdhci: move host.mmc init before sdhci_setup_cfg
>
> Just minor question..Is there the using target with iproc_sdhci?
> I didn't find whre SDHCI_IRPOC is enable

Yes, its being used in broadocm ns3 platform.
I will send a platform patch soon.

>
> Best Regards,
> Jaehoon Chung
>
> >
> >  drivers/mmc/iproc_sdhci.c | 22 +++++++++++++---------
> >  1 file changed, 13 insertions(+), 9 deletions(-)
> >
>
Jaehoon Chung April 2, 2020, 7:08 a.m. UTC | #3 
On 4/2/20 3:08 PM, Rayagonda Kokatanur wrote:
> On Thu, Apr 2, 2020 at 11:32 AM Jaehoon Chung <jh80.chung@samsung.com> wrote:
>>
>> Hi Rayagonda,
>>
>> On 3/31/20 2:34 PM, Rayagonda Kokatanur wrote:
>>> This patch series adds following,
>>> -Fix possible memory leak in probe()
>>> -Enable R1B response quirk
>>> -Fix compilation warning
>>> -Rearrange the code probe()
>>>
>>> Bharat Kumar Reddy Gooty (2):
>>>   drivers: mmc: iproc_sdhci: fix possible memory leak
>>>   drivers: mmc: iproc_sdhci: enable broken R1B response quirk
>>>
>>> Rayagonda Kokatanur (2):
>>>   drivers: mmc: iproc_sdhci: fix compilation warning
>>>   drivers: mmc: iproc_sdhci: move host.mmc init before sdhci_setup_cfg
>>
>> Just minor question..Is there the using target with iproc_sdhci?
>> I didn't find whre SDHCI_IRPOC is enable
> 
> Yes, its being used in broadocm ns3 platform.
> I will send a platform patch soon.

Thanks for explanation.

Reviewed-by: Jaehoon Chung <jh80.chung@samsung.com>

Best Regards,
Jaehoon Chung

> 
>>
>> Best Regards,
>> Jaehoon Chung
>>
>>>
>>>  drivers/mmc/iproc_sdhci.c | 22 +++++++++++++---------
>>>  1 file changed, 13 insertions(+), 9 deletions(-)
>>>
>>
> 
>