Message ID | 20200329234924.14505-1-unixmania@gmail.com |
---|---|
Headers | show |
Series | Fix and improve the S02sysctl init script | expand |
On Sun, 29 Mar 2020 20:49:21 -0300 unixmania@gmail.com wrote: > Carlos Santos (3): > pakage/busybox: use same S02sysctl script as procps-ng > package/procps-ng: add busybox-related comments to S02sysctl > pakage/procps-ng: use logger in S02sysctl only if it is available Thanks, series applied. I must admit I'm starting to be a bit worried by the complexity of what should be a simple script to load sysctl values, but OK. Thomas
On Mon, Mar 30, 2020 at 2:26 AM Thomas Petazzoni <thomas.petazzoni@bootlin.com> wrote: > > On Sun, 29 Mar 2020 20:49:21 -0300 > unixmania@gmail.com wrote: > > > Carlos Santos (3): > > pakage/busybox: use same S02sysctl script as procps-ng > > package/procps-ng: add busybox-related comments to S02sysctl > > pakage/procps-ng: use logger in S02sysctl only if it is available > > Thanks, series applied. I must admit I'm starting to be a bit worried > by the complexity of what should be a simple script to load sysctl > values, but OK. I don't like it, either, and will submit a patch to kmod fixing the behavior when the --system option is passed. Triggering the --ignore option seems to be a bug, since it is not documented in the manual page.
On Mon, Mar 30, 2020 at 8:16 AM Carlos Santos <unixmania@gmail.com> wrote: > > On Mon, Mar 30, 2020 at 2:26 AM Thomas Petazzoni > <thomas.petazzoni@bootlin.com> wrote: > > > > On Sun, 29 Mar 2020 20:49:21 -0300 > > unixmania@gmail.com wrote: > > > > > Carlos Santos (3): > > > pakage/busybox: use same S02sysctl script as procps-ng > > > package/procps-ng: add busybox-related comments to S02sysctl > > > pakage/procps-ng: use logger in S02sysctl only if it is available > > > > Thanks, series applied. I must admit I'm starting to be a bit worried > > by the complexity of what should be a simple script to load sysctl > > values, but OK. > > I don't like it, either, and will submit a patch to kmod fixing the > behavior when the --system option is passed. Triggering the --ignore > option seems to be a bug, since it is not documented in the manual > page. Errata: will submit a patch to procps-ng.
From: Carlos Santos <unixmania@gmail.com> Both busybox and procps-ng provide a S02sysctl init script. Since the scripts are the same, except for some comments, make the busybox one a symlink to the procps-ng one. Also the scripts used the logger utility unconditionally but it may not exist. Declare two functions to perform the operation, run_logger and run_std, and use the appropriate one, depending on the existence of logger. Carlos Santos (3): pakage/busybox: use same S02sysctl script as procps-ng package/procps-ng: add busybox-related comments to S02sysctl pakage/procps-ng: use logger in S02sysctl only if it is available package/busybox/S02sysctl | 67 +------------------------------------ package/procps-ng/S02sysctl | 54 +++++++++++++++++++++++------- 2 files changed, 43 insertions(+), 78 deletions(-) mode change 100644 => 120000 package/busybox/S02sysctl