| Message ID | 20200322205850.3528-1-f.fainelli@gmail.com |
|---|---|
| State | Accepted |
| Delegated to: | David Miller |
| Headers | show |
| Series | [net] net: dsa: Fix duplicate frames flooded by learning | expand |
On Sun, 22 Mar 2020 13:58:50 -0700, Florian Fainelli <f.fainelli@gmail.com> wrote: > When both the switch and the bridge are learning about new addresses, > switch ports attached to the bridge would see duplicate ARP frames > because both entities would attempt to send them. > > Fixes: 5037d532b83d ("net: dsa: add Broadcom tag RX/TX handler") > Reported-by: Maxime Bizon <mbizon@freebox.fr> > Signed-off-by: Florian Fainelli <f.fainelli@gmail.com> Reviewed-by: Vivien Didelot <vivien.didelot@gmail.com>
From: Florian Fainelli <f.fainelli@gmail.com> Date: Sun, 22 Mar 2020 13:58:50 -0700 > When both the switch and the bridge are learning about new addresses, > switch ports attached to the bridge would see duplicate ARP frames > because both entities would attempt to send them. > > Fixes: 5037d532b83d ("net: dsa: add Broadcom tag RX/TX handler") > Reported-by: Maxime Bizon <mbizon@freebox.fr> > Signed-off-by: Florian Fainelli <f.fainelli@gmail.com> Applied and queued up for -stable.
diff --git a/net/dsa/tag_brcm.c b/net/dsa/tag_brcm.c index 9c3114179690..9169b63a89e3 100644 --- a/net/dsa/tag_brcm.c +++ b/net/dsa/tag_brcm.c @@ -140,6 +140,8 @@ static struct sk_buff *brcm_tag_rcv_ll(struct sk_buff *skb, /* Remove Broadcom tag and update checksum */ skb_pull_rcsum(skb, BRCM_TAG_LEN); + skb->offload_fwd_mark = 1; + return skb; } #endif
When both the switch and the bridge are learning about new addresses, switch ports attached to the bridge would see duplicate ARP frames because both entities would attempt to send them. Fixes: 5037d532b83d ("net: dsa: add Broadcom tag RX/TX handler") Reported-by: Maxime Bizon <mbizon@freebox.fr> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com> --- net/dsa/tag_brcm.c | 2 ++ 1 file changed, 2 insertions(+)