diff mbox series

[net] netfilter: nf_flow_table: populate addr_type mask

Message ID 7ab81e8a-d1db-6b0c-7f22-fb07e0d0432c@solarflare.com
State Awaiting Upstream
Delegated to: David Miller
Headers show
Series [net] netfilter: nf_flow_table: populate addr_type mask | expand

Commit Message

Edward Cree March 19, 2020, 7:37 p.m. UTC 
nf_flow_rule_match() sets control.addr_type in key, so needs to also set
 the corresponding mask.  An exact match is wanted, so mask is all ones.

Fixes: c29f74e0df7a ("netfilter: nf_flow_table: hardware offload support")
Signed-off-by: Edward Cree <ecree@solarflare.com>
---
 net/netfilter/nf_flow_table_offload.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Pablo Neira Ayuso March 19, 2020, 8:22 p.m. UTC | #1 
On Thu, Mar 19, 2020 at 07:37:21PM +0000, Edward Cree wrote:
> nf_flow_rule_match() sets control.addr_type in key, so needs to also set
>  the corresponding mask.  An exact match is wanted, so mask is all ones.

Applied, thank you.
diff mbox series

Patch

diff --git a/net/netfilter/nf_flow_table_offload.c b/net/netfilter/nf_flow_table_offload.c
index 06f00cdc3891..f2c22c682851 100644
--- a/net/netfilter/nf_flow_table_offload.c
+++ b/net/netfilter/nf_flow_table_offload.c
@@ -87,6 +87,7 @@  static int nf_flow_rule_match(struct nf_flow_match *match,
 	default:
 		return -EOPNOTSUPP;
 	}
+	mask->control.addr_type = 0xffff;
 	match->dissector.used_keys |= BIT(key->control.addr_type);
 	mask->basic.n_proto = 0xffff;