Message ID | 1584524612-24470-1-git-send-email-ilpo.jarvinen@helsinki.fi |
---|---|
Headers | show |
Series | : Accurate ECN for TCP | expand |
From: Ilpo Järvinen <ilpo.jarvinen@helsinki.fi> Date: Wed, 18 Mar 2020 11:43:04 +0200 > Comments would be highly appreciated. Two coding style comments which you should audit your entire submission for: 1) Please order local variables in reverse christmas tree ordering (longest to shortest long) 2) Please do not use the inline keyword in foo.c files, let the compiler decide. Thank you.
On Wed, 18 Mar 2020, David Miller wrote: > From: Ilpo Järvinen <ilpo.jarvinen@helsinki.fi> > Date: Wed, 18 Mar 2020 11:43:04 +0200 > > > Comments would be highly appreciated. > > Two coding style comments which you should audit your entire submission > for: > > 1) Please order local variables in reverse christmas tree ordering (longest > to shortest long) Does this apply also to the usual struct tcp_sock *tp = tcp_sk(sk); line or can it be put first if there are some dependencies on it? > 2) Please do not use the inline keyword in foo.c files, let the compiler > decide. Thanks. I'll do those (I certainly removed some other bits I moved from header to .c but missed a few it seems).
From: "Ilpo Järvinen" <ilpo.jarvinen@cs.helsinki.fi> Date: Thu, 19 Mar 2020 22:25:23 +0200 (EET) > On Wed, 18 Mar 2020, David Miller wrote: > >> From: Ilpo Järvinen <ilpo.jarvinen@helsinki.fi> >> Date: Wed, 18 Mar 2020 11:43:04 +0200 >> >> > Comments would be highly appreciated. >> >> Two coding style comments which you should audit your entire submission >> for: >> >> 1) Please order local variables in reverse christmas tree ordering (longest >> to shortest long) > > Does this apply also to the usual struct tcp_sock *tp = tcp_sk(sk); line > or can it be put first if there are some dependencies on it? Yes, please. Put the assignment into the code lines if necessary.