Message ID | 20200316171352.3298-1-madhuparnabhowmik10@gmail.com |
---|---|
State | Accepted |
Delegated to: | David Miller |
Headers | show |
Series | net: kcm: kcmproc.c: Fix RCU list suspicious usage warning | expand |
From: madhuparnabhowmik10@gmail.com Date: Mon, 16 Mar 2020 22:43:52 +0530 > From: Madhuparna Bhowmik <madhuparnabhowmik10@gmail.com> > > This path fixes the suspicious RCU usage warning reported by > kernel test robot. > > net/kcm/kcmproc.c:#RCU-list_traversed_in_non-reader_section > > There is no need to use list_for_each_entry_rcu() in > kcm_stats_seq_show() as the list is always traversed under > knet->mutex held. > > Reported-by: kernel test robot <lkp@intel.com> > Signed-off-by: Madhuparna Bhowmik <madhuparnabhowmik10@gmail.com> Applied to net-next, thanks.
diff --git a/net/kcm/kcmproc.c b/net/kcm/kcmproc.c index 370da2f80e3c..25c1007f1098 100644 --- a/net/kcm/kcmproc.c +++ b/net/kcm/kcmproc.c @@ -261,7 +261,7 @@ static int kcm_stats_seq_show(struct seq_file *seq, void *v) aggregate_strp_stats(&knet->aggregate_strp_stats, &strp_stats); - list_for_each_entry_rcu(mux, &knet->mux_list, kcm_mux_list) { + list_for_each_entry(mux, &knet->mux_list, kcm_mux_list) { spin_lock_bh(&mux->lock); aggregate_mux_stats(&mux->stats, &mux_stats); aggregate_psock_stats(&mux->aggregate_psock_stats,