mbox series

[RFC,0/5] hostapd: DFS channels in chan_switch command ane event

Message ID 20200128150940.17018-1-sergey.matyukevich.os@quantenna.com
Headers show
Series hostapd: DFS channels in chan_switch command ane event | expand

Message

Sergey Matyukevich Jan. 28, 2020, 3:09 p.m. UTC 
Hello Jouni and all,

This patch series includes misc bits related to switching to DFS channels
in various circumstances. Major changes include:

- support for switching to DFS channels in hostapd_cli chan_switch command
- handle switching to DFS channel in ch_switch event for repeater

Sergey Matyukevich (5):
  hostapd: basic channel check for hostapd_cli chan_switch
  DFS: rename and export hostapd_config_dfs_chan_available helper
  DFS: add new hostapd_is_dfs_overlap helper
  hostapd: add support for DFS channels in hostapd_cli chan_switch
  hostapd: DFS for channel switch in repeater mode

 hostapd/ctrl_iface.c   | 173 ++++++++++++++++++++++++++++++++++++++++++++++++-
 src/ap/dfs.c           |  59 ++++++++++++++++-
 src/ap/dfs.h           |   5 +-
 src/ap/drv_callbacks.c |   7 ++
 4 files changed, 240 insertions(+), 4 deletions(-)

Comments

Jouni Malinen Feb. 29, 2020, 3:58 p.m. UTC | #1 
On Tue, Jan 28, 2020 at 03:09:48PM +0000, Sergey Matyukevich wrote:
> This patch series includes misc bits related to switching to DFS channels
> in various circumstances. Major changes include:
> 
> - support for switching to DFS channels in hostapd_cli chan_switch command
> - handle switching to DFS channel in ch_switch event for repeater
> 
> Sergey Matyukevich (5):
>   hostapd: basic channel check for hostapd_cli chan_switch
>   DFS: rename and export hostapd_config_dfs_chan_available helper
>   DFS: add new hostapd_is_dfs_overlap helper
>   hostapd: add support for DFS channels in hostapd_cli chan_switch
>   hostapd: DFS for channel switch in repeater mode

Was there some particular reason for calling this an RFC series? Are
these ready to be applied or is some additional work still needed?
Regardless, I have not seen any comments on these and I have nothing to
add either before there is a patch series that is considered ready.
Ideally, I'd also like to see hwsim test cases added to exercise the
added functionality.
Sergey Matyukevich March 16, 2020, 3:32 p.m. UTC | #2 
> > This patch series includes misc bits related to switching to DFS channels
> > in various circumstances. Major changes include:
> > 
> > - support for switching to DFS channels in hostapd_cli chan_switch command
> > - handle switching to DFS channel in ch_switch event for repeater
> > 
> > Sergey Matyukevich (5):
> >   hostapd: basic channel check for hostapd_cli chan_switch
> >   DFS: rename and export hostapd_config_dfs_chan_available helper
> >   DFS: add new hostapd_is_dfs_overlap helper
> >   hostapd: add support for DFS channels in hostapd_cli chan_switch
> >   hostapd: DFS for channel switch in repeater mode
> 
> Was there some particular reason for calling this an RFC series? Are
> these ready to be applied or is some additional work still needed?
> Regardless, I have not seen any comments on these and I have nothing to
> add either before there is a patch series that is considered ready.
> Ideally, I'd also like to see hwsim test cases added to exercise the
> added functionality.

Hello Jouni,

I would consider this series as ready. In brief, patches 1-3 contain
preparatory refactoring changes including minor enhancements for
channel sanity check in chan_switch hostapd_cli command.
The actual changes are the last two patches.

The primary reason for calling this RFC was to get some feedback
regarding the change of behavior of chan_switch command. Previously
it did not work for DFS channels, now it starts CAC when needed
and then switches to the selected DFS channel.

Regards,
Sergey
Jouni Malinen March 29, 2020, 7:54 p.m. UTC | #3 
On Mon, Mar 16, 2020 at 06:32:00PM +0300, Sergey Matyukevich wrote:
> > >   hostapd: basic channel check for hostapd_cli chan_switch
> > >   DFS: rename and export hostapd_config_dfs_chan_available helper
> > >   DFS: add new hostapd_is_dfs_overlap helper
> > >   hostapd: add support for DFS channels in hostapd_cli chan_switch
> > >   hostapd: DFS for channel switch in repeater mode

> I would consider this series as ready. In brief, patches 1-3 contain
> preparatory refactoring changes including minor enhancements for
> channel sanity check in chan_switch hostapd_cli command.
> The actual changes are the last two patches.

Thanks, I applied these now with some changes to the first one since it
was breaking number of hwsim test cases using 40 MHz channels. One of
those test cases was using incorrect parameters and I fixed that, but
the others looked fine to me since center_freq1 should not really be
mandated to be included for HT40 cases.