diff mbox series

[-next] net: ibm: remove set but not used variables 'err'

Message ID 20200311065411.172692-1-chenzhou10@huawei.com
State Accepted
Delegated to: David Miller
Headers show
Series [-next] net: ibm: remove set but not used variables 'err' | expand

Commit Message

chenzhou March 11, 2020, 6:54 a.m. UTC
Fixes gcc '-Wunused-but-set-variable' warning:

drivers/net/ethernet/ibm/emac/core.c: In function __emac_mdio_write:
drivers/net/ethernet/ibm/emac/core.c:875:9: warning:
	variable err set but not used [-Wunused-but-set-variable]

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Chen Zhou <chenzhou10@huawei.com>
---
 drivers/net/ethernet/ibm/emac/core.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Comments

David Miller March 12, 2020, 6:33 a.m. UTC | #1
From: Chen Zhou <chenzhou10@huawei.com>
Date: Wed, 11 Mar 2020 14:54:11 +0800

> Fixes gcc '-Wunused-but-set-variable' warning:
> 
> drivers/net/ethernet/ibm/emac/core.c: In function __emac_mdio_write:
> drivers/net/ethernet/ibm/emac/core.c:875:9: warning:
> 	variable err set but not used [-Wunused-but-set-variable]
> 
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Chen Zhou <chenzhou10@huawei.com>

Applied, thank you.
diff mbox series

Patch

diff --git a/drivers/net/ethernet/ibm/emac/core.c b/drivers/net/ethernet/ibm/emac/core.c
index b7fc177..06248a7 100644
--- a/drivers/net/ethernet/ibm/emac/core.c
+++ b/drivers/net/ethernet/ibm/emac/core.c
@@ -872,7 +872,7 @@  static void __emac_mdio_write(struct emac_instance *dev, u8 id, u8 reg,
 {
 	struct emac_regs __iomem *p = dev->emacp;
 	u32 r = 0;
-	int n, err = -ETIMEDOUT;
+	int n;
 
 	mutex_lock(&dev->mdio_lock);
 
@@ -919,7 +919,6 @@  static void __emac_mdio_write(struct emac_instance *dev, u8 id, u8 reg,
 			goto bail;
 		}
 	}
-	err = 0;
  bail:
 	if (emac_has_feature(dev, EMAC_FTR_HAS_RGMII))
 		rgmii_put_mdio(dev->rgmii_dev, dev->rgmii_port);