| Message ID | 1583220084-10890-2-git-send-email-masonccyang@mxic.com.tw |
|---|---|
| State | Accepted |
| Headers | show |
| Series | mtd: rawnand: Add support Macronix Block Portection & Deep Power Down mode | expand |
On Tue, 2020-03-03 at 07:21:21 UTC, Mason Yang wrote: > Add nand_lock() & nand_unlock() for manufacturer specific lock & unlock > operation while the device supports Block Portection function. > > Signed-off-by: Mason Yang <masonccyang@mxic.com.tw> > Reported-by: kbuild test robot <lkp@intel.com> > Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com> Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git nand/next, thanks. Miquel
On Tue, 3 Mar 2020 15:21:21 +0800 Mason Yang <masonccyang@mxic.com.tw> wrote: > Add nand_lock() & nand_unlock() for manufacturer specific lock & unlock > operation while the device supports Block Portection function. > > Signed-off-by: Mason Yang <masonccyang@mxic.com.tw> > Reported-by: kbuild test robot <lkp@intel.com> Reported-by on something that's not a fix doesn't make sense. I know the 0day bot asked you to add this tag, but that should only be done if you submit a separate patch, ideally with a Fixes tag. If the offending patch has not been merged yet, you should just fix the commit and ignore the Reported-by tag (you can mention who reported the problem in the changelog though). > Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com> > --- > drivers/mtd/nand/raw/nand_base.c | 36 ++++++++++++++++++++++++++++++++++-- > include/linux/mtd/rawnand.h | 5 +++++ > 2 files changed, 39 insertions(+), 2 deletions(-) > > diff --git a/drivers/mtd/nand/raw/nand_base.c b/drivers/mtd/nand/raw/nand_base.c > index f64e3b6..769be81 100644 > --- a/drivers/mtd/nand/raw/nand_base.c > +++ b/drivers/mtd/nand/raw/nand_base.c > @@ -4360,6 +4360,38 @@ static void nand_shutdown(struct mtd_info *mtd) > nand_suspend(mtd); > } > > +/** > + * nand_lock - [MTD Interface] Lock the NAND flash > + * @mtd: MTD device structure > + * @ofs: offset byte address > + * @len: number of bytes to lock (must be a multiple of block/page size) > + */ > +static int nand_lock(struct mtd_info *mtd, loff_t ofs, uint64_t len) > +{ > + struct nand_chip *chip = mtd_to_nand(mtd); > + > + if (!chip->lock_area) > + return -ENOTSUPP; > + > + return chip->lock_area(chip, ofs, len); > +} > + > +/** > + * nand_unlock - [MTD Interface] Unlock the NAND flash > + * @mtd: MTD device structure > + * @ofs: offset byte address > + * @len: number of bytes to unlock (must be a multiple of block/page size) > + */ > +static int nand_unlock(struct mtd_info *mtd, loff_t ofs, uint64_t len) > +{ > + struct nand_chip *chip = mtd_to_nand(mtd); > + > + if (!chip->unlock_area) > + return -ENOTSUPP; > + > + return chip->unlock_area(chip, ofs, len); > +} > + > /* Set default functions */ > static void nand_set_defaults(struct nand_chip *chip) > { > @@ -5786,8 +5818,8 @@ static int nand_scan_tail(struct nand_chip *chip) > mtd->_read_oob = nand_read_oob; > mtd->_write_oob = nand_write_oob; > mtd->_sync = nand_sync; > - mtd->_lock = NULL; > - mtd->_unlock = NULL; > + mtd->_lock = nand_lock; > + mtd->_unlock = nand_unlock; > mtd->_suspend = nand_suspend; > mtd->_resume = nand_resume; > mtd->_reboot = nand_shutdown; > diff --git a/include/linux/mtd/rawnand.h b/include/linux/mtd/rawnand.h > index 4ab9bcc..bc2fa3c 100644 > --- a/include/linux/mtd/rawnand.h > +++ b/include/linux/mtd/rawnand.h > @@ -1077,6 +1077,8 @@ struct nand_legacy { > * @manufacturer: [INTERN] Contains manufacturer information > * @manufacturer.desc: [INTERN] Contains manufacturer's description > * @manufacturer.priv: [INTERN] Contains manufacturer private information > + * @lock_area: [REPLACEABLE] specific NAND chip lock operation > + * @unlock_area: [REPLACEABLE] specific NAND chip unlock operation > */ > > struct nand_chip { > @@ -1136,6 +1138,9 @@ struct nand_chip { > const struct nand_manufacturer *desc; > void *priv; > } manufacturer; > + > + int (*lock_area)(struct nand_chip *chip, loff_t ofs, uint64_t len); > + int (*unlock_area)(struct nand_chip *chip, loff_t ofs, uint64_t len); > }; > > extern const struct mtd_ooblayout_ops nand_ooblayout_sp_ops;
Hi Boris, > > Add nand_lock() & nand_unlock() for manufacturer specific lock & unlock > > operation while the device supports Block Portection function. > > > > Signed-off-by: Mason Yang <masonccyang@mxic.com.tw> > > Reported-by: kbuild test robot <lkp@intel.com> > > Reported-by on something that's not a fix doesn't make sense. I know > the 0day bot asked you to add this tag, but that should only be done if > you submit a separate patch, ideally with a Fixes tag. If the offending > patch has not been merged yet, you should just fix the commit and ignore > the Reported-by tag (you can mention who reported the problem in the > changelog though). > okay, understand it. Thanks a lot for your explanation. Mason CONFIDENTIALITY NOTE: This e-mail and any attachments may contain confidential information and/or personal data, which is protected by applicable laws. Please be reminded that duplication, disclosure, distribution, or use of this e-mail (and/or its attachments) or any part thereof is prohibited. If you receive this e-mail in error, please notify us immediately and delete this mail as well as its attachment(s) from your system. In addition, please be informed that collection, processing, and/or use of personal data is prohibited unless expressly permitted by personal data protection laws. Thank you for your attention and cooperation. Macronix International Co., Ltd. ===================================================================== ============================================================================ CONFIDENTIALITY NOTE: This e-mail and any attachments may contain confidential information and/or personal data, which is protected by applicable laws. Please be reminded that duplication, disclosure, distribution, or use of this e-mail (and/or its attachments) or any part thereof is prohibited. If you receive this e-mail in error, please notify us immediately and delete this mail as well as its attachment(s) from your system. In addition, please be informed that collection, processing, and/or use of personal data is prohibited unless expressly permitted by personal data protection laws. Thank you for your attention and cooperation. Macronix International Co., Ltd. =====================================================================
Hi Mason, Boris, masonccyang@mxic.com.tw wrote on Wed, 11 Mar 2020 10:40:04 +0800: > Hi Boris, > > > > Add nand_lock() & nand_unlock() for manufacturer specific lock & > unlock > > > operation while the device supports Block Portection function. > > > > > > Signed-off-by: Mason Yang <masonccyang@mxic.com.tw> > > > Reported-by: kbuild test robot <lkp@intel.com> > > > > Reported-by on something that's not a fix doesn't make sense. I know > > the 0day bot asked you to add this tag, but that should only be done if > > you submit a separate patch, ideally with a Fixes tag. If the offending > > patch has not been merged yet, you should just fix the commit and ignore > > the Reported-by tag (you can mention who reported the problem in the > > changelog though). Yesterday when applying all the NAND patches my personal IP address got flagged as spam by mistake (~500 mails in ~10s) so I could not answer manually as I wished. Indeed, this Reported-by tag was not needed and I dropped it manually when applying. This tag is meant to show an error that was existing *before* your series and that you are fixing with your series. This is not something you should add when a robot tells you something is wrong in your series. Also, I rewrote several paragraphs and I prefixed two of them with "mtd: rawnand: macronix:". Thanks, Miquèl
diff --git a/drivers/mtd/nand/raw/nand_base.c b/drivers/mtd/nand/raw/nand_base.c index f64e3b6..769be81 100644 --- a/drivers/mtd/nand/raw/nand_base.c +++ b/drivers/mtd/nand/raw/nand_base.c @@ -4360,6 +4360,38 @@ static void nand_shutdown(struct mtd_info *mtd) nand_suspend(mtd); } +/** + * nand_lock - [MTD Interface] Lock the NAND flash + * @mtd: MTD device structure + * @ofs: offset byte address + * @len: number of bytes to lock (must be a multiple of block/page size) + */ +static int nand_lock(struct mtd_info *mtd, loff_t ofs, uint64_t len) +{ + struct nand_chip *chip = mtd_to_nand(mtd); + + if (!chip->lock_area) + return -ENOTSUPP; + + return chip->lock_area(chip, ofs, len); +} + +/** + * nand_unlock - [MTD Interface] Unlock the NAND flash + * @mtd: MTD device structure + * @ofs: offset byte address + * @len: number of bytes to unlock (must be a multiple of block/page size) + */ +static int nand_unlock(struct mtd_info *mtd, loff_t ofs, uint64_t len) +{ + struct nand_chip *chip = mtd_to_nand(mtd); + + if (!chip->unlock_area) + return -ENOTSUPP; + + return chip->unlock_area(chip, ofs, len); +} + /* Set default functions */ static void nand_set_defaults(struct nand_chip *chip) { @@ -5786,8 +5818,8 @@ static int nand_scan_tail(struct nand_chip *chip) mtd->_read_oob = nand_read_oob; mtd->_write_oob = nand_write_oob; mtd->_sync = nand_sync; - mtd->_lock = NULL; - mtd->_unlock = NULL; + mtd->_lock = nand_lock; + mtd->_unlock = nand_unlock; mtd->_suspend = nand_suspend; mtd->_resume = nand_resume; mtd->_reboot = nand_shutdown; diff --git a/include/linux/mtd/rawnand.h b/include/linux/mtd/rawnand.h index 4ab9bcc..bc2fa3c 100644 --- a/include/linux/mtd/rawnand.h +++ b/include/linux/mtd/rawnand.h @@ -1077,6 +1077,8 @@ struct nand_legacy { * @manufacturer: [INTERN] Contains manufacturer information * @manufacturer.desc: [INTERN] Contains manufacturer's description * @manufacturer.priv: [INTERN] Contains manufacturer private information + * @lock_area: [REPLACEABLE] specific NAND chip lock operation + * @unlock_area: [REPLACEABLE] specific NAND chip unlock operation */ struct nand_chip { @@ -1136,6 +1138,9 @@ struct nand_chip { const struct nand_manufacturer *desc; void *priv; } manufacturer; + + int (*lock_area)(struct nand_chip *chip, loff_t ofs, uint64_t len); + int (*unlock_area)(struct nand_chip *chip, loff_t ofs, uint64_t len); }; extern const struct mtd_ooblayout_ops nand_ooblayout_sp_ops;