Message ID | 20200310183624.441788-1-songliubraving@fb.com |
---|---|
Headers | show |
Series | Fixes for bpftool-prog-profile | expand |
Song Liu wrote: > 1. Fix build for older clang; > 2. Fix skeleton's dependency on libbpf. > > Song Liu (2): > bpftool: only build bpftool-prog-profile with clang >= v11 > bpftool: skeleton should depend on libbpf > > tools/bpf/bpftool/Makefile | 15 ++++++++++++--- > tools/bpf/bpftool/prog.c | 2 ++ > 2 files changed, 14 insertions(+), 3 deletions(-) > > -- > 2.17.1 Maybe instead of "Please recompile" -> "Please build" sounds a bit better to me but that is probably a matter of preference and doesn't matter much. Anyways for the series, Acked-by: John Fastabend <john.fastabend@gmail.com>
On Tue, Mar 10, 2020 at 11:36 AM Song Liu <songliubraving@fb.com> wrote: > > 1. Fix build for older clang; > 2. Fix skeleton's dependency on libbpf. > Can you please also add tools/bpf/bpftool/profiler.skel.h to .gitignore? > Song Liu (2): > bpftool: only build bpftool-prog-profile with clang >= v11 > bpftool: skeleton should depend on libbpf > > tools/bpf/bpftool/Makefile | 15 ++++++++++++--- > tools/bpf/bpftool/prog.c | 2 ++ > 2 files changed, 14 insertions(+), 3 deletions(-) > > -- > 2.17.1