[1/1] UBUNTU: SAUCE: remove python-xattr dependency

Starting with Python 3.3, handling of Linux extended attributes is now
part of the Python Standard Library (os module).

On top of that, there isn't a single instantion of the xattr class, nor
any invokation of any xattr function in the entire autotest-client tree,
so i think this dependency is completely bogus and could be removed
altogether: i ran the patched ubuntu_xfstests_ext4 test in a Xenial VM
and in a Focal VM, and both completed fine.

Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com>
---
 ubuntu_xfstests_btrfs/ubuntu_xfstests_btrfs.py | 1 -
 ubuntu_xfstests_ext4/ubuntu_xfstests_ext4.py   | 1 -
 ubuntu_xfstests_xfs/ubuntu_xfstests_xfs.py     | 1 -
 xfstests/xfstests.py                           | 1 -
 4 files changed, 4 deletions(-)

On 05/03/2020 10:46, Paolo Pisati wrote:
> Starting with Python 3.3, handling of Linux extended attributes is now
> part of the Python Standard Library (os module).
> 
> On top of that, there isn't a single instantion of the xattr class, nor
> any invokation of any xattr function in the entire autotest-client tree,
> so i think this dependency is completely bogus and could be removed
> altogether: i ran the patched ubuntu_xfstests_ext4 test in a Xenial VM
> and in a Focal VM, and both completed fine.

Does this work on older releases such as precise?

> 
> Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com>
> ---
>  ubuntu_xfstests_btrfs/ubuntu_xfstests_btrfs.py | 1 -
>  ubuntu_xfstests_ext4/ubuntu_xfstests_ext4.py   | 1 -
>  ubuntu_xfstests_xfs/ubuntu_xfstests_xfs.py     | 1 -
>  xfstests/xfstests.py                           | 1 -
>  4 files changed, 4 deletions(-)
> 
> diff --git a/ubuntu_xfstests_btrfs/ubuntu_xfstests_btrfs.py b/ubuntu_xfstests_btrfs/ubuntu_xfstests_btrfs.py
> index d4fc5efa..2d3f99e2 100644
> --- a/ubuntu_xfstests_btrfs/ubuntu_xfstests_btrfs.py
> +++ b/ubuntu_xfstests_btrfs/ubuntu_xfstests_btrfs.py
> @@ -48,7 +48,6 @@ class ubuntu_xfstests_btrfs(test.test):
>              'libssl-dev',
>              'libtool',
>              'pkg-config',
> -            'python-xattr',
>              'quota',
>              'texinfo',
>              'texlive',
> diff --git a/ubuntu_xfstests_ext4/ubuntu_xfstests_ext4.py b/ubuntu_xfstests_ext4/ubuntu_xfstests_ext4.py
> index 3df4eae3..92b79b7d 100644
> --- a/ubuntu_xfstests_ext4/ubuntu_xfstests_ext4.py
> +++ b/ubuntu_xfstests_ext4/ubuntu_xfstests_ext4.py
> @@ -48,7 +48,6 @@ class ubuntu_xfstests_ext4(test.test):
>              'libssl-dev',
>              'libtool',
>              'pkg-config',
> -            'python-xattr',
>              'quota',
>              'texinfo',
>              'texlive',
> diff --git a/ubuntu_xfstests_xfs/ubuntu_xfstests_xfs.py b/ubuntu_xfstests_xfs/ubuntu_xfstests_xfs.py
> index 17578b82..c5ca83fb 100644
> --- a/ubuntu_xfstests_xfs/ubuntu_xfstests_xfs.py
> +++ b/ubuntu_xfstests_xfs/ubuntu_xfstests_xfs.py
> @@ -48,7 +48,6 @@ class ubuntu_xfstests_xfs(test.test):
>              'libssl-dev',
>              'libtool',
>              'pkg-config',
> -            'python-xattr',
>              'quota',
>              'texinfo',
>              'texlive',
> diff --git a/xfstests/xfstests.py b/xfstests/xfstests.py
> index 03dd3fe4..91845d5e 100644
> --- a/xfstests/xfstests.py
> +++ b/xfstests/xfstests.py
> @@ -35,7 +35,6 @@ class xfstests(test.test):
>              'autoconf',
>              'kpartx',
>              'libtool',
> -            'python-xattr',
>              'quota',
>              'bc',
>              'attr',
>

On Thu, Mar 5, 2020 at 11:06 AM Colin Ian King <colin.king@canonical.com> wrote:
>
> On 05/03/2020 10:46, Paolo Pisati wrote:
> > Starting with Python 3.3, handling of Linux extended attributes is now
> > part of the Python Standard Library (os module).
> >
> > On top of that, there isn't a single instantion of the xattr class, nor
> > any invokation of any xattr function in the entire autotest-client tree,
> > so i think this dependency is completely bogus and could be removed
> > altogether: i ran the patched ubuntu_xfstests_ext4 test in a Xenial VM
> > and in a Focal VM, and both completed fine.
>
> Does this work on older releases such as precise?

Nope, because the test is broken in Precise - i spawned a VM to try it:

1) ubuntu_xfstests_* tests have a dependency that doesn't exist in Precise:

...
14:06:30 WARNI| Could not find GDB installed. Crash handling will
operate with limited functionality
14:06:30 ERROR| [stderr] E: Unable to locate package thin-provisioning-tools
...

after removing the above dependency, setup() completed fine

2) the actual fs tests contained in the external repo 'xfstests-bld'
FTBFS in Precise:

...
  stdout:
  sed -e "s;@DIR@;$(pwd);" < kvm-xfstests/android-xfstests.in >
android-xfstests.sh
  sed -e "s;@DIR@;$(pwd);" < kvm-xfstests/gce-xfstests.in > gce-xfstests.sh
  sed -e "s;@DIR@;$(pwd);" < kvm-xfstests/kvm-xfstests.in > kvm-xfstests.sh
  chmod +x android-xfstests.sh
  chmod +x gce-xfstests.sh
  chmod +x kvm-xfstests.sh
  ./get-all
  ./build-all
  ----------------- 2020-03-05 14:13:27: Starting build of extended
attribute library
  checking build system type... x86_64-pc-linux-gnu
  checking host system type... x86_64-pc-linux-gnu
  checking how to print strings... printf
  checking for gcc... gcc
  checking whether the C compiler works... no
  stderr:
  configure: WARNING: unrecognized options: --disable-nls
  configure: error: in
`/home/ubuntu/k-testing/autotest/client/tmp/ubuntu_xfstests_ext4/src/xfstests-bld/attr':
  configure: error: C compiler cannot create executables
  See `config.log' for more details
  make: *** [all] Error 1
...

As we are not running these suites on older releases (P/T), this change
should be OK, and I have checked the xfstests-bld and the xfstest-dev
that will be downloaded by this test, a quick recursive grep shows none
of them is using this module.

Acked, applied and pushed.
Thanks
Sam

Acked-by: Po-Hsu Lin <po-hsu.lin@canonical.com>