Message ID | 20200304213023.689983-2-t.schramm@manjaro.org |
---|---|
State | Not Applicable, archived |
Headers | show |
Series | Add support for the pine64 Pinebook Pro | expand |
Am Mittwoch, 4. März 2020, 22:30:22 CET schrieb Tobias Schramm: > From: Emmanuel Vadot <manu@freebsd.org> > > Add a compatible for Pine64 Pinebook Pro > > Signed-off-by: Emmanuel Vadot <manu@freebsd.org> > Reviewed-by: Rob Herring <robh@kernel.org> applied for 5.7, but moved above Rock64 ;-) Thanks Heiko
Am Mittwoch, 4. März 2020, 22:30:23 CET schrieb Tobias Schramm: > This commit adds initial dt support for the rk3399 based Pinebook Pro. > > Signed-off-by: Tobias Schramm <t.schramm@manjaro.org> applied for 5.7 Thanks Heiko
Hi, Missing #address-cells, #size-cells Can you still fix that? On 3/6/20 1:23 AM, Heiko Stuebner wrote: > Am Mittwoch, 4. März 2020, 22:30:23 CET schrieb Tobias Schramm: >> This commit adds initial dt support for the rk3399 based Pinebook Pro. >> >> Signed-off-by: Tobias Schramm <t.schramm@manjaro.org> > > applied for 5.7 > > Thanks > Heiko > > > +&edp { > + force-hpd; > + pinctrl-names = "default"; > + pinctrl-0 = <&edp_hpd>; > + status = "okay"; > + > + ports { #address-cells = <1>; #size-cells = <0>; Don't forget that extra empty line here. > + edp_out: port@1 { > + reg = <1>; > + #address-cells = <1>; > + #size-cells = <0>; > + > + edp_out_panel: endpoint@0 { > + reg = <0>; > + remote-endpoint = <&panel_in_edp>; > + }; > + }; > + }; > +};
Hi Johan, Am Freitag, 6. März 2020, 08:22:00 CET schrieb Johan Jonker: > Hi, > > Missing #address-cells, #size-cells > Can you still fix that? > > On 3/6/20 1:23 AM, Heiko Stuebner wrote: > > Am Mittwoch, 4. März 2020, 22:30:23 CET schrieb Tobias Schramm: > >> This commit adds initial dt support for the rk3399 based Pinebook Pro. > >> > >> Signed-off-by: Tobias Schramm <t.schramm@manjaro.org> > > > > applied for 5.7 > > > > Thanks > > Heiko > > > > > > > +&edp { > > + force-hpd; > > + pinctrl-names = "default"; > > + pinctrl-0 = <&edp_hpd>; > > + status = "okay"; > > + > > + ports { > > #address-cells = <1>; > #size-cells = <0>; > > Don't forget that extra empty line here. The edp ports node does get its address+size cells already from the main node in rk3399.dtsi, so isn't needed here. Heiko > > > > + edp_out: port@1 { > > + reg = <1>; > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + edp_out_panel: endpoint@0 { > > + reg = <0>; > > + remote-endpoint = <&panel_in_edp>; > > + }; > > + }; > > + }; > > +}; > >
Hi Heiko, >> This commit adds initial dt support for the rk3399 based Pinebook Pro. >> >> Signed-off-by: Tobias Schramm <t.schramm@manjaro.org> > > applied for 5.7 > any chance you can squeeze in another small fix? Somewhere in the process the vmcc and vqmmc supplies of the sdmmc controller were removed in error. Those should be added to the sdmmc controller like this: &sdmmc { pinctrl-names = "default"; pinctrl-0 = <&sdmmc_clk &sdmmc_cmd &sdmmc_bus4>; sd-uhs-sdr104; + vmmc-supply = <&vcc3v0_sd>; + vqmmc-supply = <&vcc_sdio>; status = "okay"; }; Thanks, Tobias
Hi Tobias, Am Freitag, 6. März 2020, 19:58:45 CET schrieb Tobias Schramm: > Hi Heiko, > > >> This commit adds initial dt support for the rk3399 based Pinebook Pro. > >> > >> Signed-off-by: Tobias Schramm <t.schramm@manjaro.org> > > > > applied for 5.7 > > > > any chance you can squeeze in another small fix? Somewhere in the > process the vmcc and vqmmc supplies of the sdmmc controller were removed > in error. Those should be added to the sdmmc controller like this: > > &sdmmc { > pinctrl-names = "default"; > pinctrl-0 = <&sdmmc_clk &sdmmc_cmd &sdmmc_bus4>; > sd-uhs-sdr104; > + vmmc-supply = <&vcc3v0_sd>; > + vqmmc-supply = <&vcc_sdio>; > status = "okay"; > }; I've amended the commit with these two properties. Heiko
diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml index 874b0eaa2a75..17f0ab0b8832 100644 --- a/Documentation/devicetree/bindings/arm/rockchip.yaml +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml @@ -415,6 +415,11 @@ properties: - const: pine64,rockpro64 - const: rockchip,rk3399 + - description: Pine64 PinebookPro + items: + - const: pine64,pinebook-pro + - const: rockchip,rk3399 + - description: Radxa Rock items: - const: radxa,rock