| Message ID | 20200304185602.2540-1-lesliemonis@gmail.com |
|---|---|
| Headers | show |
| Series | pie: minor improvements | expand |
On Thu, 5 Mar 2020 00:25:58 +0530 Leslie Monis wrote: > This patch series includes the following minor changes with > respect to the PIE/FQ-PIE qdiscs: > > - Patch 1 removes some ambiguity by using the term "backlog" > instead of "qlen" when referring to the queue length > in bytes. > - Patch 2 removes redundant type casting on two expressions. > - Patch 3 removes the pie_vars->accu_prob_overflows variable > without affecting the precision in calculations and > makes the size of the pie_vars structure exactly 64 > bytes. > - Patch 4 realigns a comment affected by a change in patch 3. > > Changes from v1 to v2: > - Kept 8 as the argument to prandom_bytes() instead of changing it > to 7 as suggested by David Miller. I was wondering if patch 3 changes make user-visible changes but it seems those should be only slight accuracy adjustments, so LGTM. FWIW: Reviewed-by: Jakub Kicinski <kuba@kernel.org>
From: Jakub Kicinski <kuba@kernel.org> Date: Wed, 4 Mar 2020 12:49:17 -0800 > On Thu, 5 Mar 2020 00:25:58 +0530 Leslie Monis wrote: >> This patch series includes the following minor changes with >> respect to the PIE/FQ-PIE qdiscs: >> >> - Patch 1 removes some ambiguity by using the term "backlog" >> instead of "qlen" when referring to the queue length >> in bytes. >> - Patch 2 removes redundant type casting on two expressions. >> - Patch 3 removes the pie_vars->accu_prob_overflows variable >> without affecting the precision in calculations and >> makes the size of the pie_vars structure exactly 64 >> bytes. >> - Patch 4 realigns a comment affected by a change in patch 3. >> >> Changes from v1 to v2: >> - Kept 8 as the argument to prandom_bytes() instead of changing it >> to 7 as suggested by David Miller. > > I was wondering if patch 3 changes make user-visible changes but it > seems those should be only slight accuracy adjustments, so LGTM. FWIW: > > Reviewed-by: Jakub Kicinski <kuba@kernel.org> Series applied, thanks everyone.
This patch series includes the following minor changes with respect to the PIE/FQ-PIE qdiscs: - Patch 1 removes some ambiguity by using the term "backlog" instead of "qlen" when referring to the queue length in bytes. - Patch 2 removes redundant type casting on two expressions. - Patch 3 removes the pie_vars->accu_prob_overflows variable without affecting the precision in calculations and makes the size of the pie_vars structure exactly 64 bytes. - Patch 4 realigns a comment affected by a change in patch 3. Changes from v1 to v2: - Kept 8 as the argument to prandom_bytes() instead of changing it to 7 as suggested by David Miller. Leslie Monis (4): pie: use term backlog instead of qlen pie: remove unnecessary type casting pie: remove pie_vars->accu_prob_overflows pie: realign comment include/net/pie.h | 31 +++++++++++++--------------- net/sched/sch_fq_pie.c | 1 - net/sched/sch_pie.c | 47 +++++++++++++++++------------------------- 3 files changed, 33 insertions(+), 46 deletions(-)