| Message ID | 20200228154214.13916-1-ckeepax@opensource.cirrus.com |
|---|---|
| State | New |
| Headers | show |
| Series | pinctrl: madera: Add missing call to pinctrl_unregister_mappings | expand |
On Fri, Feb 28, 2020 at 4:42 PM Charles Keepax <ckeepax@opensource.cirrus.com> wrote: > pinctrl_register_mappings is called in the pdata case, however a call to > pinctrl_unregister_mappings is missing causing the mappings to be leaked > on driver unbind. Add the missing call to correct this issue. > > Signed-off-by: Charles Keepax <ckeepax@opensource.cirrus.com> Patch applied for fixes. Yours, Linus Walleij
diff --git a/drivers/pinctrl/cirrus/pinctrl-madera-core.c b/drivers/pinctrl/cirrus/pinctrl-madera-core.c index 7b6409ef553c9..dce2626384a90 100644 --- a/drivers/pinctrl/cirrus/pinctrl-madera-core.c +++ b/drivers/pinctrl/cirrus/pinctrl-madera-core.c @@ -1073,13 +1073,26 @@ static int madera_pin_probe(struct platform_device *pdev) return ret; } + platform_set_drvdata(pdev, priv); + dev_dbg(priv->dev, "pinctrl probed ok\n"); return 0; } +static int madera_pin_remove(struct platform_device *pdev) +{ + struct madera_pin_private *priv = platform_get_drvdata(pdev); + + if (priv->madera->pdata.gpio_configs) + pinctrl_unregister_mappings(priv->madera->pdata.gpio_configs); + + return 0; +} + static struct platform_driver madera_pin_driver = { .probe = madera_pin_probe, + .remove = madera_pin_remove, .driver = { .name = "madera-pinctrl", },
pinctrl_register_mappings is called in the pdata case, however a call to pinctrl_unregister_mappings is missing causing the mappings to be leaked on driver unbind. Add the missing call to correct this issue. Signed-off-by: Charles Keepax <ckeepax@opensource.cirrus.com> --- drivers/pinctrl/cirrus/pinctrl-madera-core.c | 13 +++++++++++++ 1 file changed, 13 insertions(+)