| Message ID | 20200225163025.9430-4-vadym.kochan@plvision.eu |
|---|---|
| State | RFC |
| Delegated to: | David Miller |
| Headers | show |
| Series | net: marvell: prestera: Add Switchdev driver for Prestera family ASIC device 98DX326x (AC3x) | expand |
On 2/25/2020 8:30 AM, Vadym Kochan wrote: > Document requirement for the PCI port which is connected to the ASIC, to > allow access to the firmware related registers. > > Signed-off-by: Vadym Kochan <vadym.kochan@plvision.eu> > --- > .../devicetree/bindings/net/marvell,prestera.txt | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > > diff --git a/Documentation/devicetree/bindings/net/marvell,prestera.txt b/Documentation/devicetree/bindings/net/marvell,prestera.txt > index 83370ebf5b89..103c35cfa8a7 100644 > --- a/Documentation/devicetree/bindings/net/marvell,prestera.txt > +++ b/Documentation/devicetree/bindings/net/marvell,prestera.txt > @@ -45,3 +45,16 @@ dfx-server { > ranges = <0 MBUS_ID(0x08, 0x00) 0 0x100000>; > reg = <MBUS_ID(0x08, 0x00) 0 0x100000>; > }; > + > +Marvell Prestera SwitchDev bindings > +----------------------------------- > +The current implementation of Prestera Switchdev PCI interface driver requires > +that BAR2 is assigned to 0xf6000000 as base address from the PCI IO range: It is always a bit disturbing to document what a driver does, or want in a Device Tree binding. If it is necessary for the PCIe device to have multiple ranges defined such that the necessary BARs are available, that is what is necessary, no need to mention what the driver or firmware does. > + > +&cp0_pcie0 { > + ranges = <0x81000000 0x0 0xfb000000 0x0 0xfb000000 0x0 0xf0000 > + 0x82000000 0x0 0xf6000000 0x0 0xf6000000 0x0 0x2000000 > + 0x82000000 0x0 0xf9000000 0x0 0xf9000000 0x0 0x100000>; > + phys = <&cp0_comphy0 0>; > + status = "okay"; > +}; >
diff --git a/Documentation/devicetree/bindings/net/marvell,prestera.txt b/Documentation/devicetree/bindings/net/marvell,prestera.txt index 83370ebf5b89..103c35cfa8a7 100644 --- a/Documentation/devicetree/bindings/net/marvell,prestera.txt +++ b/Documentation/devicetree/bindings/net/marvell,prestera.txt @@ -45,3 +45,16 @@ dfx-server { ranges = <0 MBUS_ID(0x08, 0x00) 0 0x100000>; reg = <MBUS_ID(0x08, 0x00) 0 0x100000>; }; + +Marvell Prestera SwitchDev bindings +----------------------------------- +The current implementation of Prestera Switchdev PCI interface driver requires +that BAR2 is assigned to 0xf6000000 as base address from the PCI IO range: + +&cp0_pcie0 { + ranges = <0x81000000 0x0 0xfb000000 0x0 0xfb000000 0x0 0xf0000 + 0x82000000 0x0 0xf6000000 0x0 0xf6000000 0x0 0x2000000 + 0x82000000 0x0 0xf9000000 0x0 0xf9000000 0x0 0x100000>; + phys = <&cp0_comphy0 0>; + status = "okay"; +};
Document requirement for the PCI port which is connected to the ASIC, to allow access to the firmware related registers. Signed-off-by: Vadym Kochan <vadym.kochan@plvision.eu> --- .../devicetree/bindings/net/marvell,prestera.txt | 13 +++++++++++++ 1 file changed, 13 insertions(+)