| Message ID | 20200226081011.1347245-1-anarsoul@gmail.com |
|---|---|
| Headers | show |
| Series | Add LCD support for Pine64 Pinebook 1080p | expand |
On Wed, Feb 26, 2020 at 12:10 AM Vasily Khoruzhick <anarsoul@gmail.com> wrote: > > From: Samuel Holland <samuel@sholland.org> This patch can be dropped since equivalent was merged: https://cgit.freedesktop.org/drm/drm-misc/commit/?id=6726ca1a2d531f5a6efc1f785b15606ce837c4dc > We don't need to pass '-supply' suffix to devm_regulator_get() > > Fixes: 6aa192698089 ("drm/bridge: Add Analogix anx6345 support") > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > Signed-off-by: Samuel Holland <samuel@sholland.org> > Signed-off-by: Vasily Khoruzhick <anarsoul@gmail.com> > --- > drivers/gpu/drm/bridge/analogix/analogix-anx6345.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/bridge/analogix/analogix-anx6345.c b/drivers/gpu/drm/bridge/analogix/analogix-anx6345.c > index 56f55c53abfd..0d8d083b0207 100644 > --- a/drivers/gpu/drm/bridge/analogix/analogix-anx6345.c > +++ b/drivers/gpu/drm/bridge/analogix/analogix-anx6345.c > @@ -712,14 +712,14 @@ static int anx6345_i2c_probe(struct i2c_client *client, > DRM_DEBUG("No panel found\n"); > > /* 1.2V digital core power regulator */ > - anx6345->dvdd12 = devm_regulator_get(dev, "dvdd12-supply"); > + anx6345->dvdd12 = devm_regulator_get(dev, "dvdd12"); > if (IS_ERR(anx6345->dvdd12)) { > DRM_ERROR("dvdd12-supply not found\n"); > return PTR_ERR(anx6345->dvdd12); > } > > /* 2.5V digital core power regulator */ > - anx6345->dvdd25 = devm_regulator_get(dev, "dvdd25-supply"); > + anx6345->dvdd25 = devm_regulator_get(dev, "dvdd25"); > if (IS_ERR(anx6345->dvdd25)) { > DRM_ERROR("dvdd25-supply not found\n"); > return PTR_ERR(anx6345->dvdd25); > -- > 2.25.0 >
On Wed, Feb 26, 2020 at 12:10:11AM -0800, Vasily Khoruzhick wrote: > From: Icenowy Zheng <icenowy@aosc.io> > > Pinebook has an ANX6345 bridge connected to the RGB666 LCD output and > eDP panel input. The bridge is controlled via I2C that's connected to > R_I2C bus. > > Enable all this hardware in device tree. > > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > Signed-off-by: Icenowy Zheng <icenowy@aosc.io> > Signed-off-by: Vasily Khoruzhick <anarsoul@gmail.com> Applied the 6 patches, thanks! Maxime
Since ANX6345 driver has been merged we can add support for Pinebook LCD This is a follow up on [1] which attempted to add support for all the A64-based Pinebooks. Since patches for 768p were dropped we don't need edp-connector binding discussed in [1] and its earlier versions and we can use panel-simple binding as everyone else does. If we ever going to add support for 768p we can do it through dt-overlay with appropriate panel node or by teaching bootloader to patch dtb with correct panel compatible. Similar approach was chosen in [2] [1] https://patchwork.kernel.org/cover/10814169/ [2] https://patchwork.kernel.org/patch/11277765/ v2: - Collect r-b tags - Don't print devm_regulator_get() error only if it is -EPROBE_DEFER - Keep compatibles alphabetically sorted in panel-simple.yaml - Properly indent new panel modes - Drop #address-cells, #size-cells properties and @0 suffix of endpoints in sun50i-a64-pinebook.dts Icenowy Zheng (1): arm64: allwinner: a64: enable LCD-related hardware for Pinebook Samuel Holland (1): drm/bridge: anx6345: Fix getting anx6345 regulators Vasily Khoruzhick (4): drm/bridge: anx6345: don't print error message if regulator is not ready dt-bindings: Add Guangdong Neweast Optoelectronics CO. LTD vendor prefix dt-bindings: display: simple: Add NewEast Optoelectronics WJFH116008A compatible drm/panel: simple: Add NewEast Optoelectronics CO., LTD WJFH116008A panel support .../bindings/display/panel/panel-simple.yaml | 2 + .../devicetree/bindings/vendor-prefixes.yaml | 2 + .../dts/allwinner/sun50i-a64-pinebook.dts | 61 ++++++++++++++++++- .../drm/bridge/analogix/analogix-anx6345.c | 12 ++-- drivers/gpu/drm/panel/panel-simple.c | 48 +++++++++++++++ 5 files changed, 120 insertions(+), 5 deletions(-)