| Message ID | cover.1582705101.git.amit.kucheria@linaro.org |
|---|---|
| Headers | show |
| Series | Cleanup dtbs_check warnings for tsens | expand |
On 26-02-20, 15:01, Amit Kucheria wrote: > The qcom-tsens binding requires a SoC-specific and a TSENS > family-specific binding to be specified in the compatible string. > > Since them family-specific binding is not listed in the .dtsi file, we > see the following warnings in 'make dtbs_check'. Fix them. > > /home/amit/work/builds/build-aarch64/arch/arm64/boot/dts/qcom/msm8996-mtp.dt.yaml: > thermal-sensor@4a9000: compatible: ['qcom,msm8996-tsens'] is not valid > under any of the given schemas (Possible causes of the failure): > /home/amit/work/builds/build-aarch64/arch/arm64/boot/dts/qcom/msm8996-mtp.dt.yaml: > thermal-sensor@4a9000: compatible: ['qcom,msm8996-tsens'] is too short > /home/amit/work/builds/build-aarch64/arch/arm64/boot/dts/qcom/msm8996-mtp.dt.yaml: > thermal-sensor@4a9000: compatible:0: 'qcom,msm8996-tsens' is not one of > ['qcom,msm8916-tsens', 'qcom,msm8974-tsens'] > /home/amit/work/builds/build-aarch64/arch/arm64/boot/dts/qcom/msm8996-mtp.dt.yaml: > thermal-sensor@4a9000: compatible:0: 'qcom,msm8996-tsens' is not one of > ['qcom,msm8976-tsens', 'qcom,qcs404-tsens'] > > /home/amit/work/builds/build-aarch64/arch/arm64/boot/dts/qcom/msm8996-mtp.dt.yaml: > thermal-sensor@4ad000: compatible: ['qcom,msm8996-tsens'] is not valid > under any of the given schemas (Possible causes of the failure): > /home/amit/work/builds/build-aarch64/arch/arm64/boot/dts/qcom/msm8996-mtp.dt.yaml: > thermal-sensor@4ad000: compatible: ['qcom,msm8996-tsens'] is too short > /home/amit/work/builds/build-aarch64/arch/arm64/boot/dts/qcom/msm8996-mtp.dt.yaml: > thermal-sensor@4ad000: compatible:0: 'qcom,msm8996-tsens' is not one of > ['qcom,msm8916-tsens', 'qcom,msm8974-tsens'] > /home/amit/work/builds/build-aarch64/arch/arm64/boot/dts/qcom/msm8996-mtp.dt.yaml: > thermal-sensor@4ad000: compatible:0: 'qcom,msm8996-tsens' is not one of > ['qcom,msm8976-tsens', 'qcom,qcs404-tsens'] Reviewed-by: Vinod Koul <vkoul@kernel.org> > > Signed-off-by: Amit Kucheria <amit.kucheria@linaro.org> > --- > arch/arm64/boot/dts/qcom/msm8996.dtsi | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64/boot/dts/qcom/msm8996.dtsi > index 7ae082ea14ea..f157cd4f53b4 100644 > --- a/arch/arm64/boot/dts/qcom/msm8996.dtsi > +++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi > @@ -446,7 +446,7 @@ > }; > > tsens0: thermal-sensor@4a9000 { > - compatible = "qcom,msm8996-tsens"; > + compatible = "qcom,msm8996-tsens", "qcom,tsens-v2"; > reg = <0x004a9000 0x1000>, /* TM */ > <0x004a8000 0x1000>; /* SROT */ > #qcom,sensors = <13>; > @@ -457,7 +457,7 @@ > }; > > tsens1: thermal-sensor@4ad000 { > - compatible = "qcom,msm8996-tsens"; > + compatible = "qcom,msm8996-tsens", "qcom,tsens-v2"; > reg = <0x004ad000 0x1000>, /* TM */ > <0x004ac000 0x1000>; /* SROT */ > #qcom,sensors = <8>; > -- > 2.20.1
On 26-02-20, 15:01, Amit Kucheria wrote: > The qcom-tsens binding requires a SoC-specific and a TSENS > family-specific binding to be specified in the compatible string. > > Since them family-specific binding is not listed in the .dtsi file, we > see the following warnings in 'make dtbs_check'. Fix them. > > /home/amit/work/builds/build-aarch64/arch/arm64/boot/dts/qcom/msm8996-mtp.dt.yaml: > thermal-sensor@4a9000: compatible: ['qcom,msm8996-tsens'] is not valid > under any of the given schemas (Possible causes of the failure): > /home/amit/work/builds/build-aarch64/arch/arm64/boot/dts/qcom/msm8996-mtp.dt.yaml: > thermal-sensor@4a9000: compatible: ['qcom,msm8996-tsens'] is too short > /home/amit/work/builds/build-aarch64/arch/arm64/boot/dts/qcom/msm8996-mtp.dt.yaml: > thermal-sensor@4a9000: compatible:0: 'qcom,msm8996-tsens' is not one of > ['qcom,msm8916-tsens', 'qcom,msm8974-tsens'] > /home/amit/work/builds/build-aarch64/arch/arm64/boot/dts/qcom/msm8996-mtp.dt.yaml: > thermal-sensor@4a9000: compatible:0: 'qcom,msm8996-tsens' is not one of > ['qcom,msm8976-tsens', 'qcom,qcs404-tsens'] > > /home/amit/work/builds/build-aarch64/arch/arm64/boot/dts/qcom/msm8996-mtp.dt.yaml: > thermal-sensor@4ad000: compatible: ['qcom,msm8996-tsens'] is not valid > under any of the given schemas (Possible causes of the failure): > /home/amit/work/builds/build-aarch64/arch/arm64/boot/dts/qcom/msm8996-mtp.dt.yaml: > thermal-sensor@4ad000: compatible: ['qcom,msm8996-tsens'] is too short > /home/amit/work/builds/build-aarch64/arch/arm64/boot/dts/qcom/msm8996-mtp.dt.yaml: > thermal-sensor@4ad000: compatible:0: 'qcom,msm8996-tsens' is not one of > ['qcom,msm8916-tsens', 'qcom,msm8974-tsens'] > /home/amit/work/builds/build-aarch64/arch/arm64/boot/dts/qcom/msm8996-mtp.dt.yaml: > thermal-sensor@4ad000: compatible:0: 'qcom,msm8996-tsens' is not one of > ['qcom,msm8976-tsens', 'qcom,qcs404-tsens'] Reviewed-by: Vinod Koul <vkoul@kernel.org> > > Signed-off-by: Amit Kucheria <amit.kucheria@linaro.org> > --- > arch/arm64/boot/dts/qcom/msm8996.dtsi | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64/boot/dts/qcom/msm8996.dtsi > index 7ae082ea14ea..f157cd4f53b4 100644 > --- a/arch/arm64/boot/dts/qcom/msm8996.dtsi > +++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi > @@ -446,7 +446,7 @@ > }; > > tsens0: thermal-sensor@4a9000 { > - compatible = "qcom,msm8996-tsens"; > + compatible = "qcom,msm8996-tsens", "qcom,tsens-v2"; > reg = <0x004a9000 0x1000>, /* TM */ > <0x004a8000 0x1000>; /* SROT */ > #qcom,sensors = <13>; > @@ -457,7 +457,7 @@ > }; > > tsens1: thermal-sensor@4ad000 { > - compatible = "qcom,msm8996-tsens"; > + compatible = "qcom,msm8996-tsens", "qcom,tsens-v2"; > reg = <0x004ad000 0x1000>, /* TM */ > <0x004ac000 0x1000>; /* SROT */ > #qcom,sensors = <8>; > -- > 2.20.1
On 26-02-20, 15:01, Amit Kucheria wrote: > The qcom-tsens binding requires a SoC-specific and a TSENS > family-specific binding to be specified in the compatible string. > > Since them family-specific binding is not listed in the .dtsi file, we > see the following warnings in 'make dtbs_check'. Fix them. > > /home/amit/work/builds/build-aarch64/arch/arm64/boot/dts/qcom/msm8916-mtp.dt.yaml: > thermal-sensor@4a9000: compatible: ['qcom,msm8916-tsens'] is not valid > under any of the given schemas (Possible causes of the failure): > /home/amit/work/builds/build-aarch64/arch/arm64/boot/dts/qcom/msm8916-mtp.dt.yaml: > thermal-sensor@4a9000: compatible: ['qcom,msm8916-tsens'] is too short > /home/amit/work/builds/build-aarch64/arch/arm64/boot/dts/qcom/msm8916-mtp.dt.yaml: > thermal-sensor@4a9000: compatible:0: 'qcom,msm8916-tsens' is not one of > ['qcom,msm8976-tsens', 'qcom,qcs404-tsens'] > /home/amit/work/builds/build-aarch64/arch/arm64/boot/dts/qcom/msm8916-mtp.dt.yaml: > thermal-sensor@4a9000: compatible:0: 'qcom,msm8916-tsens' is not one of > ['qcom,msm8996-tsens', 'qcom,msm8998-tsens', 'qcom,sdm845-tsens'] Reviewed-by: Vinod Koul <vkoul@kernel.org> > > Signed-off-by: Amit Kucheria <amit.kucheria@linaro.org> > --- > arch/arm64/boot/dts/qcom/msm8916.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/qcom/msm8916.dtsi b/arch/arm64/boot/dts/qcom/msm8916.dtsi > index 9f31064f2374..1748ea3f4b4f 100644 > --- a/arch/arm64/boot/dts/qcom/msm8916.dtsi > +++ b/arch/arm64/boot/dts/qcom/msm8916.dtsi > @@ -860,7 +860,7 @@ > }; > > tsens: thermal-sensor@4a9000 { > - compatible = "qcom,msm8916-tsens"; > + compatible = "qcom,msm8916-tsens", "qcom,tsens-v0_1"; > reg = <0x4a9000 0x1000>, /* TM */ > <0x4a8000 0x1000>; /* SROT */ > nvmem-cells = <&tsens_caldata>, <&tsens_calsel>; > -- > 2.20.1
On Wed 26 Feb 01:31 PST 2020, Amit Kucheria wrote: $subject should be "arm64: dts: qcom: msm8916: ..." Apart from that this looks good. Regards, Bjorn > The qcom-tsens binding requires a SoC-specific and a TSENS > family-specific binding to be specified in the compatible string. > > Since them family-specific binding is not listed in the .dtsi file, we > see the following warnings in 'make dtbs_check'. Fix them. > > /home/amit/work/builds/build-aarch64/arch/arm64/boot/dts/qcom/msm8916-mtp.dt.yaml: > thermal-sensor@4a9000: compatible: ['qcom,msm8916-tsens'] is not valid > under any of the given schemas (Possible causes of the failure): > /home/amit/work/builds/build-aarch64/arch/arm64/boot/dts/qcom/msm8916-mtp.dt.yaml: > thermal-sensor@4a9000: compatible: ['qcom,msm8916-tsens'] is too short > /home/amit/work/builds/build-aarch64/arch/arm64/boot/dts/qcom/msm8916-mtp.dt.yaml: > thermal-sensor@4a9000: compatible:0: 'qcom,msm8916-tsens' is not one of > ['qcom,msm8976-tsens', 'qcom,qcs404-tsens'] > /home/amit/work/builds/build-aarch64/arch/arm64/boot/dts/qcom/msm8916-mtp.dt.yaml: > thermal-sensor@4a9000: compatible:0: 'qcom,msm8916-tsens' is not one of > ['qcom,msm8996-tsens', 'qcom,msm8998-tsens', 'qcom,sdm845-tsens'] > > Signed-off-by: Amit Kucheria <amit.kucheria@linaro.org> > --- > arch/arm64/boot/dts/qcom/msm8916.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/qcom/msm8916.dtsi b/arch/arm64/boot/dts/qcom/msm8916.dtsi > index 9f31064f2374..1748ea3f4b4f 100644 > --- a/arch/arm64/boot/dts/qcom/msm8916.dtsi > +++ b/arch/arm64/boot/dts/qcom/msm8916.dtsi > @@ -860,7 +860,7 @@ > }; > > tsens: thermal-sensor@4a9000 { > - compatible = "qcom,msm8916-tsens"; > + compatible = "qcom,msm8916-tsens", "qcom,tsens-v0_1"; > reg = <0x4a9000 0x1000>, /* TM */ > <0x4a8000 0x1000>; /* SROT */ > nvmem-cells = <&tsens_caldata>, <&tsens_calsel>; > -- > 2.20.1 >
On Wed 26 Feb 01:31 PST 2020, Amit Kucheria wrote: As with patch 2, $subject should have an appropriate prefix. Please update this. Regards, Bjorn > The qcom-tsens binding requires a SoC-specific and a TSENS > family-specific binding to be specified in the compatible string. > > Since them family-specific binding is not listed in the .dtsi file, we > see the following warnings in 'make dtbs_check'. Fix them. > > /home/amit/work/builds/build-aarch64/arch/arm64/boot/dts/qcom/msm8996-mtp.dt.yaml: > thermal-sensor@4a9000: compatible: ['qcom,msm8996-tsens'] is not valid > under any of the given schemas (Possible causes of the failure): > /home/amit/work/builds/build-aarch64/arch/arm64/boot/dts/qcom/msm8996-mtp.dt.yaml: > thermal-sensor@4a9000: compatible: ['qcom,msm8996-tsens'] is too short > /home/amit/work/builds/build-aarch64/arch/arm64/boot/dts/qcom/msm8996-mtp.dt.yaml: > thermal-sensor@4a9000: compatible:0: 'qcom,msm8996-tsens' is not one of > ['qcom,msm8916-tsens', 'qcom,msm8974-tsens'] > /home/amit/work/builds/build-aarch64/arch/arm64/boot/dts/qcom/msm8996-mtp.dt.yaml: > thermal-sensor@4a9000: compatible:0: 'qcom,msm8996-tsens' is not one of > ['qcom,msm8976-tsens', 'qcom,qcs404-tsens'] > > /home/amit/work/builds/build-aarch64/arch/arm64/boot/dts/qcom/msm8996-mtp.dt.yaml: > thermal-sensor@4ad000: compatible: ['qcom,msm8996-tsens'] is not valid > under any of the given schemas (Possible causes of the failure): > /home/amit/work/builds/build-aarch64/arch/arm64/boot/dts/qcom/msm8996-mtp.dt.yaml: > thermal-sensor@4ad000: compatible: ['qcom,msm8996-tsens'] is too short > /home/amit/work/builds/build-aarch64/arch/arm64/boot/dts/qcom/msm8996-mtp.dt.yaml: > thermal-sensor@4ad000: compatible:0: 'qcom,msm8996-tsens' is not one of > ['qcom,msm8916-tsens', 'qcom,msm8974-tsens'] > /home/amit/work/builds/build-aarch64/arch/arm64/boot/dts/qcom/msm8996-mtp.dt.yaml: > thermal-sensor@4ad000: compatible:0: 'qcom,msm8996-tsens' is not one of > ['qcom,msm8976-tsens', 'qcom,qcs404-tsens'] > > Signed-off-by: Amit Kucheria <amit.kucheria@linaro.org> > --- > arch/arm64/boot/dts/qcom/msm8996.dtsi | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64/boot/dts/qcom/msm8996.dtsi > index 7ae082ea14ea..f157cd4f53b4 100644 > --- a/arch/arm64/boot/dts/qcom/msm8996.dtsi > +++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi > @@ -446,7 +446,7 @@ > }; > > tsens0: thermal-sensor@4a9000 { > - compatible = "qcom,msm8996-tsens"; > + compatible = "qcom,msm8996-tsens", "qcom,tsens-v2"; > reg = <0x004a9000 0x1000>, /* TM */ > <0x004a8000 0x1000>; /* SROT */ > #qcom,sensors = <13>; > @@ -457,7 +457,7 @@ > }; > > tsens1: thermal-sensor@4ad000 { > - compatible = "qcom,msm8996-tsens"; > + compatible = "qcom,msm8996-tsens", "qcom,tsens-v2"; > reg = <0x004ad000 0x1000>, /* TM */ > <0x004ac000 0x1000>; /* SROT */ > #qcom,sensors = <8>; > -- > 2.20.1 >
Make dtbs_check pass for tsens bits. I'm working on another series to cleanup other DT warnings for QC platforms. Amit Kucheria (3): dt-bindings: thermal: tsens: Add entry for sc7180 tsens to binding dt-bindings: thermal: tsens: Add qcom,tsens-v0_1 to msm8916.dtsi compatible dt-bindings: thermal: tsens: Add qcom,tsens-v2 to msm8996.dtsi compatible Documentation/devicetree/bindings/thermal/qcom-tsens.yaml | 1 + arch/arm64/boot/dts/qcom/msm8916.dtsi | 2 +- arch/arm64/boot/dts/qcom/msm8996.dtsi | 4 ++-- 3 files changed, 4 insertions(+), 3 deletions(-)