Message ID | 20200218023625.14324-1-yuehaibing@huawei.com |
---|---|
State | New |
Headers | show |
Series | [-next] pinctrl: mediatek: remove set but not used variable 'e' | expand |
On 18/02/2020 03:36, YueHaibing wrote: > drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c: In function mtk_hw_pin_field_lookup: > drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c:70:39: warning: > variable e set but not used [-Wunused-but-set-variable] > > Since commit 3de7deefce69 ("pinctrl: mediatek: Check gpio pin > number and use binary search in mtk_hw_pin_field_lookup()"), > it is not used any more, so remove it, also remove redundant > assignment to variable c, it will be assigned a new value later > before used. > > Reported-by: Hulk Robot <hulkci@huawei.com> > Signed-off-by: YueHaibing <yuehaibing@huawei.com> Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com> > --- > drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c b/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c > index 1da9425..d3169a8 100644 > --- a/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c > +++ b/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c > @@ -67,7 +67,7 @@ static int mtk_hw_pin_field_lookup(struct mtk_pinctrl *hw, > const struct mtk_pin_desc *desc, > int field, struct mtk_pin_field *pfd) > { > - const struct mtk_pin_field_calc *c, *e; > + const struct mtk_pin_field_calc *c; > const struct mtk_pin_reg_calc *rc; > int start = 0, end, check; > bool found = false; > @@ -82,8 +82,6 @@ static int mtk_hw_pin_field_lookup(struct mtk_pinctrl *hw, > } > > end = rc->nranges - 1; > - c = rc->range; > - e = c + rc->nranges; > > while (start <= end) { > check = (start + end) >> 1; >
On Tue, Feb 18, 2020 at 3:36 AM YueHaibing <yuehaibing@huawei.com> wrote: > drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c: In function mtk_hw_pin_field_lookup: > drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c:70:39: warning: > variable e set but not used [-Wunused-but-set-variable] > > Since commit 3de7deefce69 ("pinctrl: mediatek: Check gpio pin > number and use binary search in mtk_hw_pin_field_lookup()"), > it is not used any more, so remove it, also remove redundant > assignment to variable c, it will be assigned a new value later > before used. > > Reported-by: Hulk Robot <hulkci@huawei.com> > Signed-off-by: YueHaibing <yuehaibing@huawei.com> Patch applied with Matthias Review tag. Yours, Linus Walleij
diff --git a/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c b/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c index 1da9425..d3169a8 100644 --- a/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c +++ b/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c @@ -67,7 +67,7 @@ static int mtk_hw_pin_field_lookup(struct mtk_pinctrl *hw, const struct mtk_pin_desc *desc, int field, struct mtk_pin_field *pfd) { - const struct mtk_pin_field_calc *c, *e; + const struct mtk_pin_field_calc *c; const struct mtk_pin_reg_calc *rc; int start = 0, end, check; bool found = false; @@ -82,8 +82,6 @@ static int mtk_hw_pin_field_lookup(struct mtk_pinctrl *hw, } end = rc->nranges - 1; - c = rc->range; - e = c + rc->nranges; while (start <= end) { check = (start + end) >> 1;
drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c: In function mtk_hw_pin_field_lookup: drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c:70:39: warning: variable e set but not used [-Wunused-but-set-variable] Since commit 3de7deefce69 ("pinctrl: mediatek: Check gpio pin number and use binary search in mtk_hw_pin_field_lookup()"), it is not used any more, so remove it, also remove redundant assignment to variable c, it will be assigned a new value later before used. Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: YueHaibing <yuehaibing@huawei.com> --- drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)