| Message ID | 20191216194815.5436-1-asafka7@gmail.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | [1/1] package/python-pathlib2: select python-scandir | expand |
On Mon, 16 Dec 2019 21:48:15 +0200 Asaf Kahlon <asafka7@gmail.com> wrote: > scandir is a runtime dependency of pathlib2. > > Signed-off-by: Asaf Kahlon <asafka7@gmail.com> > --- > package/python-pathlib2/Config.in | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/package/python-pathlib2/Config.in b/package/python-pathlib2/Config.in > index e28de4c12e..ca948c271f 100644 > --- a/package/python-pathlib2/Config.in > +++ b/package/python-pathlib2/Config.in > @@ -1,6 +1,7 @@ > config BR2_PACKAGE_PYTHON_PATHLIB2 > bool "python-pathlib2" > depends on BR2_PACKAGE_PYTHON > + select BR2_PACKAGE_PYTHON_SCANDIR # runtime I see this in the setup.py: extras_require={ ':python_version<"3.5"': ['scandir'], }, Doesn't that mean that it is needed only if the Python version is < 3.5 ? Best regards, Thomas
Hello, On Sun, Dec 22, 2019 at 3:42 PM Thomas Petazzoni <thomas.petazzoni@bootlin.com> wrote: > > On Mon, 16 Dec 2019 21:48:15 +0200 > Asaf Kahlon <asafka7@gmail.com> wrote: > > > scandir is a runtime dependency of pathlib2. > > > > Signed-off-by: Asaf Kahlon <asafka7@gmail.com> > > --- > > package/python-pathlib2/Config.in | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/package/python-pathlib2/Config.in b/package/python-pathlib2/Config.in > > index e28de4c12e..ca948c271f 100644 > > --- a/package/python-pathlib2/Config.in > > +++ b/package/python-pathlib2/Config.in > > @@ -1,6 +1,7 @@ > > config BR2_PACKAGE_PYTHON_PATHLIB2 > > bool "python-pathlib2" > > depends on BR2_PACKAGE_PYTHON > > + select BR2_PACKAGE_PYTHON_SCANDIR # runtime > > I see this in the setup.py: > > extras_require={ > ':python_version<"3.5"': ['scandir'], > }, > > Doesn't that mean that it is needed only if the Python version is < 3.5 ? Yeah that's true, but pathlib2 can be chosen only for python 2, so we can say for sure it's needed. > > Best regards, > > Thomas > -- > Thomas Petazzoni, CTO, Bootlin > Embedded Linux and Kernel engineering > https://bootlin.com Regards, Asaf.
Asaf, All, On Sun, Dec 22, 2019 at 11:39 AM Asaf Kahlon <asafka7@gmail.com> wrote: > > Yeah that's true, but pathlib2 can be chosen only for python 2, > so we can say for sure it's needed. I can confirm that pathlib2 will crash on first invocation when using python2 if BR2_PACKAGE_PYTHON_SCANDIR is not enabled. Thanks, Conrad
diff --git a/package/python-pathlib2/Config.in b/package/python-pathlib2/Config.in index e28de4c12e..ca948c271f 100644 --- a/package/python-pathlib2/Config.in +++ b/package/python-pathlib2/Config.in @@ -1,6 +1,7 @@ config BR2_PACKAGE_PYTHON_PATHLIB2 bool "python-pathlib2" depends on BR2_PACKAGE_PYTHON + select BR2_PACKAGE_PYTHON_SCANDIR # runtime select BR2_PACKAGE_PYTHON_SIX # runtime help Object-oriented filesystem paths.
scandir is a runtime dependency of pathlib2. Signed-off-by: Asaf Kahlon <asafka7@gmail.com> --- package/python-pathlib2/Config.in | 1 + 1 file changed, 1 insertion(+)