| Message ID | 20200210034612.3261-1-aaron.ma@canonical.com |
|---|---|
| Headers | show |
| Series | Fix multitouch support on some devices | expand |
On Mon, Feb 10, 2020 at 11:46:08AM +0800, Aaron Ma wrote: > BugLink: https://bugs.launchpad.net/bugs/1862567 > > SRU justification: > > [Impact] > Some LG touchscreens reported themselves as generic touch devices, > actually it is multitouch devices. > Even after adding IDs in hid-multitouch, hid-generic will bind the > device still. > multitouch features are not supported. > > [Fix] > commit e04a0442 make hid-generic work nicely with other drivers like > hid-multitouch. > If other drivers match the devices, hid-generic will step back. > This patch will benefit many devices to support their own drivers > without adding IDs. > > [Test] > Verified on LG/ELAN/RAYDIUM touchscreens with positive results. > > [Regression Potential] > Medium. > commit e04a0442 is included by 4.16 kernel, only bionic kernel should be > applied. > This commit is based on the other 3 patches, mostly changes are moving > codes to hid-quirk.c. > Backports are during to the other backports patches, these changes are > moved to > hid-quirk.c too. > > Benjamin Tissoires (4): > HID: core: move the dynamic quirks handling in core > HID: quirks: move the list of special devices into a quirk > HID: core: move the list of ignored devices in hid-quirks.c > HID: core: remove the absolute need of hid_have_special_driver[] > > drivers/hid/Makefile | 2 +- > drivers/hid/hid-core.c | 951 ++--------------------- > drivers/hid/hid-generic.c | 68 +- > drivers/hid/hid-quirks.c | 1267 +++++++++++++++++++++++++++++++ > drivers/hid/usbhid/Makefile | 2 +- > drivers/hid/usbhid/hid-core.c | 10 +- > drivers/hid/usbhid/hid-quirks.c | 405 ---------- > include/linux/hid.h | 21 +- > net/bluetooth/hidp/core.c | 2 +- > 9 files changed, 1414 insertions(+), 1314 deletions(-) > create mode 100644 drivers/hid/hid-quirks.c > delete mode 100644 drivers/hid/usbhid/hid-quirks.c > > -- > 2.17.1 > > > -- > kernel-team mailing list > kernel-team@lists.ubuntu.com > https://lists.ubuntu.com/mailman/listinfo/kernel-team Acked-by: Sultan Alsawaf <sultan.alsawaf@canonical.com>
On 10.02.20 04:46, Aaron Ma wrote: > BugLink: https://bugs.launchpad.net/bugs/1862567 > > SRU justification: > > [Impact] > Some LG touchscreens reported themselves as generic touch devices, > actually it is multitouch devices. > Even after adding IDs in hid-multitouch, hid-generic will bind the > device still. > multitouch features are not supported. > > [Fix] > commit e04a0442 make hid-generic work nicely with other drivers like > hid-multitouch. > If other drivers match the devices, hid-generic will step back. > This patch will benefit many devices to support their own drivers > without adding IDs. > > [Test] > Verified on LG/ELAN/RAYDIUM touchscreens with positive results. > > [Regression Potential] > Medium. > commit e04a0442 is included by 4.16 kernel, only bionic kernel should be > applied. > This commit is based on the other 3 patches, mostly changes are moving > codes to hid-quirk.c. > Backports are during to the other backports patches, these changes are > moved to > hid-quirk.c too. > > Benjamin Tissoires (4): > HID: core: move the dynamic quirks handling in core > HID: quirks: move the list of special devices into a quirk > HID: core: move the list of ignored devices in hid-quirks.c > HID: core: remove the absolute need of hid_have_special_driver[] > > drivers/hid/Makefile | 2 +- > drivers/hid/hid-core.c | 951 ++--------------------- > drivers/hid/hid-generic.c | 68 +- > drivers/hid/hid-quirks.c | 1267 +++++++++++++++++++++++++++++++ > drivers/hid/usbhid/Makefile | 2 +- > drivers/hid/usbhid/hid-core.c | 10 +- > drivers/hid/usbhid/hid-quirks.c | 405 ---------- > include/linux/hid.h | 21 +- > net/bluetooth/hidp/core.c | 2 +- > 9 files changed, 1414 insertions(+), 1314 deletions(-) > create mode 100644 drivers/hid/hid-quirks.c > delete mode 100644 drivers/hid/usbhid/hid-quirks.c > Acked-by: Kleber Sacilotto de Souza <kleber.souza@canonical.com>
On 10.02.20 04:46, Aaron Ma wrote: > BugLink: https://bugs.launchpad.net/bugs/1862567 > > SRU justification: > > [Impact] > Some LG touchscreens reported themselves as generic touch devices, > actually it is multitouch devices. > Even after adding IDs in hid-multitouch, hid-generic will bind the > device still. > multitouch features are not supported. > > [Fix] > commit e04a0442 make hid-generic work nicely with other drivers like > hid-multitouch. > If other drivers match the devices, hid-generic will step back. > This patch will benefit many devices to support their own drivers > without adding IDs. > > [Test] > Verified on LG/ELAN/RAYDIUM touchscreens with positive results. > > [Regression Potential] > Medium. > commit e04a0442 is included by 4.16 kernel, only bionic kernel should be > applied. > This commit is based on the other 3 patches, mostly changes are moving > codes to hid-quirk.c. > Backports are during to the other backports patches, these changes are > moved to > hid-quirk.c too. > > Benjamin Tissoires (4): > HID: core: move the dynamic quirks handling in core > HID: quirks: move the list of special devices into a quirk > HID: core: move the list of ignored devices in hid-quirks.c > HID: core: remove the absolute need of hid_have_special_driver[] > > drivers/hid/Makefile | 2 +- > drivers/hid/hid-core.c | 951 ++--------------------- > drivers/hid/hid-generic.c | 68 +- > drivers/hid/hid-quirks.c | 1267 +++++++++++++++++++++++++++++++ > drivers/hid/usbhid/Makefile | 2 +- > drivers/hid/usbhid/hid-core.c | 10 +- > drivers/hid/usbhid/hid-quirks.c | 405 ---------- > include/linux/hid.h | 21 +- > net/bluetooth/hidp/core.c | 2 +- > 9 files changed, 1414 insertions(+), 1314 deletions(-) > create mode 100644 drivers/hid/hid-quirks.c > delete mode 100644 drivers/hid/usbhid/hid-quirks.c > Applied to bionic/linux. Thanks, Kleber
To to a show in z on I'm qf to ez we ag On Tue, Feb 11, 2020, 6:24 AM Sultan Alsawaf <sultan.alsawaf@canonical.com wrote: > On Mon, Feb 10, 2020 at 11:46:08AM +0800, Aaron Ma wrote: > > BugLink: https://bugs.launchpad.net/bugs/1862567 > > > > SRU justification: > > > > [Impact] > > Some LG touchscreens reported themselves as generic touch devices, > > actually it is multitouch devices. > > Even after adding IDs in hid-multitouch, hid-generic will bind the > > device still. > > multitouch features are not supported. > > > > [Fix] > > commit e04a0442 make hid-generic work nicely with other drivers like > > hid-multitouch. > > If other drivers match the devices, hid-generic will step back. > > This patch will benefit many devices to support their own drivers > > without adding IDs. > > > > [Test] > > Verified on LG/ELAN/RAYDIUM touchscreens with positive results. > > > > [Regression Potential] > > Medium. > > commit e04a0442 is included by 4.16 kernel, only bionic kernel should be > > applied. > > This commit is based on the other 3 patches, mostly changes are moving > > codes to hid-quirk.c. > > Backports are during to the other backports patches, these changes are > > moved to > > hid-quirk.c too. > > > > Benjamin Tissoires (4): > > HID: core: move the dynamic quirks handling in core > > HID: quirks: move the list of special devices into a quirk > > HID: core: move the list of ignored devices in hid-quirks.c > > HID: core: remove the absolute need of hid_have_special_driver[] > > > > drivers/hid/Makefile | 2 +- > > drivers/hid/hid-core.c | 951 ++--------------------- > > drivers/hid/hid-generic.c | 68 +- > > drivers/hid/hid-quirks.c | 1267 +++++++++++++++++++++++++++++++ > > drivers/hid/usbhid/Makefile | 2 +- > > drivers/hid/usbhid/hid-core.c | 10 +- > > drivers/hid/usbhid/hid-quirks.c | 405 ---------- > > include/linux/hid.h | 21 +- > > net/bluetooth/hidp/core.c | 2 +- > > 9 files changed, 1414 insertions(+), 1314 deletions(-) > > create mode 100644 drivers/hid/hid-quirks.c > > delete mode 100644 drivers/hid/usbhid/hid-quirks.c > > > > -- > > 2.17.1 > > > > > > -- > > kernel-team mailing list > > kernel-team@lists.ubuntu.com > > https://lists.ubuntu.com/mailman/listinfo/kernel-team > > Acked-by: Sultan Alsawaf <sultan.alsawaf@canonical.com> > > -- > kernel-team mailing list > kernel-team@lists.ubuntu.com > https://lists.ubuntu.com/mailman/listinfo/kernel-team >