| Message ID | 20200204165547.115220-20-hare@suse.de |
|---|---|
| State | Not Applicable |
| Delegated to: | David Miller |
| Headers | show |
| Series | ata: kill ATA_DEBUG | expand |
On 2/4/20 5:55 PM, Hannes Reinecke wrote: > Reset is now logged with tracepoints, so the DPRINTK() calls can > be dropped. > > Signed-off-by: Hannes Reinecke <hare@suse.de> Reviewed-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics > --- > drivers/ata/sata_rcar.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/drivers/ata/sata_rcar.c b/drivers/ata/sata_rcar.c > index 980aacdbcf3b..1b42be234761 100644 > --- a/drivers/ata/sata_rcar.c > +++ b/drivers/ata/sata_rcar.c > @@ -323,8 +323,6 @@ static int sata_rcar_bus_softreset(struct ata_port *ap, unsigned long deadline) > { > struct ata_ioports *ioaddr = &ap->ioaddr; > > - DPRINTK("ata%u: bus reset via SRST\n", ap->print_id); > - > /* software reset. causes dev0 to be selected */ > iowrite32(ap->ctl, ioaddr->ctl_addr); > udelay(20); > @@ -350,7 +348,6 @@ static int sata_rcar_softreset(struct ata_link *link, unsigned int *classes, > devmask |= 1 << 0; > > /* issue bus reset */ > - DPRINTK("about to softreset, devmask=%x\n", devmask); > rc = sata_rcar_bus_softreset(ap, deadline); > /* if link is occupied, -ENODEV too is an error */ > if (rc && (rc != -ENODEV || sata_scr_valid(link))) { > @@ -361,7 +358,6 @@ static int sata_rcar_softreset(struct ata_link *link, unsigned int *classes, > /* determine by signature whether we have ATA or ATAPI devices */ > classes[0] = ata_sff_dev_classify(&link->device[0], devmask, &err); > > - DPRINTK("classes[0]=%u\n", classes[0]); > return 0; > } >
diff --git a/drivers/ata/sata_rcar.c b/drivers/ata/sata_rcar.c index 980aacdbcf3b..1b42be234761 100644 --- a/drivers/ata/sata_rcar.c +++ b/drivers/ata/sata_rcar.c @@ -323,8 +323,6 @@ static int sata_rcar_bus_softreset(struct ata_port *ap, unsigned long deadline) { struct ata_ioports *ioaddr = &ap->ioaddr; - DPRINTK("ata%u: bus reset via SRST\n", ap->print_id); - /* software reset. causes dev0 to be selected */ iowrite32(ap->ctl, ioaddr->ctl_addr); udelay(20); @@ -350,7 +348,6 @@ static int sata_rcar_softreset(struct ata_link *link, unsigned int *classes, devmask |= 1 << 0; /* issue bus reset */ - DPRINTK("about to softreset, devmask=%x\n", devmask); rc = sata_rcar_bus_softreset(ap, deadline); /* if link is occupied, -ENODEV too is an error */ if (rc && (rc != -ENODEV || sata_scr_valid(link))) { @@ -361,7 +358,6 @@ static int sata_rcar_softreset(struct ata_link *link, unsigned int *classes, /* determine by signature whether we have ATA or ATAPI devices */ classes[0] = ata_sff_dev_classify(&link->device[0], devmask, &err); - DPRINTK("classes[0]=%u\n", classes[0]); return 0; }
Reset is now logged with tracepoints, so the DPRINTK() calls can be dropped. Signed-off-by: Hannes Reinecke <hare@suse.de> --- drivers/ata/sata_rcar.c | 4 ---- 1 file changed, 4 deletions(-)