diff mbox series

package/gr-osmosdr: fix dependencies

Message ID 1580914682-11394-1-git-send-email-gwenj@trabucayre.com
State Changes Requested
Headers show
Series package/gr-osmosdr: fix dependencies | expand

Commit Message

Gwenhael Goavec-Merou Feb. 5, 2020, 2:58 p.m. UTC 
From: Gwenhael Goavec-Merou <gwenhael.goavec-merou@trabucayre.com>

gr-osmosdr fails with:
CMake Error at /somewhere/buildroot/output/host/mipsel-buildroot-linux-gnu/sysroot/usr/lib/cmake/gnuradio/GnuradioConfig.cmake:116 (include):
  include could not find load file:

    /somewhere/buildroot/output/host/mipsel-buildroot-linux-gnu/sysroot/usr/lib/cmake/gnuradio/gnuradio-filterConfig.cmake
Call Stack (most recent call first):
  CMakeLists.txt:45 (find_package)

gr-osmosdr depends on BR2_PACKAGE_GNURADIO_BLOCKS, BR2_PACKAGE_GNURADIO_FFT and
BR2_PACKAGE_GNURADIO_FILTER.

By replacing BLOCKS by FILTER (FILTER select FFT, and FFT select BLOCKS) every mandatories
Gnu Radio modules are selected.

fix:
- http://autobuild.buildroot.net/results/1781db2b8c28641167f7a39a4d799930db13f9bf/

Signed-off-by: Gwenhael Goavec-Merou <gwenhael.goavec-merou@trabucayre.com>
---
 package/gr-osmosdr/Config.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Thomas Petazzoni Feb. 5, 2020, 3:45 p.m. UTC | #1 
On Wed,  5 Feb 2020 15:58:02 +0100
Gwenhael Goavec-Merou <gwenj@trabucayre.com> wrote:

> From: Gwenhael Goavec-Merou <gwenhael.goavec-merou@trabucayre.com>
> 
> gr-osmosdr fails with:
> CMake Error at /somewhere/buildroot/output/host/mipsel-buildroot-linux-gnu/sysroot/usr/lib/cmake/gnuradio/GnuradioConfig.cmake:116 (include):
>   include could not find load file:
> 
>     /somewhere/buildroot/output/host/mipsel-buildroot-linux-gnu/sysroot/usr/lib/cmake/gnuradio/gnuradio-filterConfig.cmake
> Call Stack (most recent call first):
>   CMakeLists.txt:45 (find_package)
> 
> gr-osmosdr depends on BR2_PACKAGE_GNURADIO_BLOCKS, BR2_PACKAGE_GNURADIO_FFT and
> BR2_PACKAGE_GNURADIO_FILTER.

If it really needs these three features directly, we want gr-osmodr to
select all three options, not just one that happens to internally imply
the two others.

Thanks!

Thomas
diff mbox series

Patch

diff --git a/package/gr-osmosdr/Config.in b/package/gr-osmosdr/Config.in
index f26380371f..8d42964900 100644
--- a/package/gr-osmosdr/Config.in
+++ b/package/gr-osmosdr/Config.in
@@ -1,7 +1,7 @@ 
 config BR2_PACKAGE_GR_OSMOSDR
 	bool "gr-osmosdr"
 	depends on BR2_PACKAGE_GNURADIO
-	select BR2_PACKAGE_GNURADIO_BLOCKS
+	select BR2_PACKAGE_GNURADIO_FILTER
 	help
 	  GNU Radio block for interfacing with various radio hardware