diff mbox series

[RFC,v3,6/6] libstb/trustedboot: Map UV image measurement to PCR4

Message ID 20200122151354.23683-7-grimm@linux.ibm.com
State RFC
Headers show
Series Ultravisor support in skiboot | expand

Checks

Context Check Description
snowpatch_ozlabs/apply_patch warning Failed to apply on branch master (d75e82dbfbb9443efeb3f9a5921ac23605aab469)
snowpatch_ozlabs/apply_patch fail Failed to apply to any branch

Commit Message

Ryan Grimm Jan. 22, 2020, 3:13 p.m. UTC
From: Claudio Carvalho <cclaudio@linux.ibm.com>

This maps the ultravisor image to be measured to PCR4. The image is
automatically verified and  measured hen it is loaded from PNOR.

Signed-off-by: Claudio Carvalho <cclaudio@linux.ibm.com>
---
 libstb/trustedboot.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Stewart Smith Feb. 2, 2020, 12:01 a.m. UTC | #1
On Wed, Jan 22, 2020, at 7:13 AM, Ryan Grimm wrote:
> From: Claudio Carvalho <cclaudio@linux.ibm.com>
> 
> This maps the ultravisor image to be measured to PCR4. The image is
> automatically verified and  measured hen it is loaded from PNOR.
> 
> Signed-off-by: Claudio Carvalho <cclaudio@linux.ibm.com>
> ---
>  libstb/trustedboot.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/libstb/trustedboot.c b/libstb/trustedboot.c
> index 3f977de1..87f3b6bf 100644
> --- a/libstb/trustedboot.c
> +++ b/libstb/trustedboot.c
> @@ -45,6 +45,7 @@ static struct {
>  	{ RESOURCE_ID_KERNEL,		PCR_4},
>  	{ RESOURCE_ID_CAPP,		PCR_4},
>  	{ RESOURCE_ID_VERSION,		PCR_4}, /* Also data for Hostboot */
> +	{ RESOURCE_ID_UV_IMAGE,		PCR_4},
>  };

Is it about time we start being explicit as to the order in which these are written into the PCRs? Currently it's all implementation specific and I wonder the best way for someone to be able to create a set of PCR values for a firmware build and publish them along side it?
diff mbox series

Patch

diff --git a/libstb/trustedboot.c b/libstb/trustedboot.c
index 3f977de1..87f3b6bf 100644
--- a/libstb/trustedboot.c
+++ b/libstb/trustedboot.c
@@ -45,6 +45,7 @@  static struct {
 	{ RESOURCE_ID_KERNEL,		PCR_4},
 	{ RESOURCE_ID_CAPP,		PCR_4},
 	{ RESOURCE_ID_VERSION,		PCR_4}, /* Also data for Hostboot */
+	{ RESOURCE_ID_UV_IMAGE,		PCR_4},
 };
 
 /*