| Message ID | 1580084042-11598-1-git-send-email-john.fastabend@gmail.com |
|---|---|
| Headers | show |
| Series | XDP flush cleanups | expand |
On 1/27/20 1:13 AM, John Fastabend wrote: > A couple updates to cleanup some of the XDP comments and rcu usage. > > It would be best if patch 1/3 goes into current bpf-next with the > associated patch in the fixes tag so we don't have out of sync > comments in the code. Just noting because its close to time to close > {bpf|net}-next branches. > > v2->v3: Jesper noticed I can't spell, so fixed spelling. If we > are fixing comments its best to have correct spelling. > > v1->v2: Added 2/3 patch for virtio_net to use rcu_access_pointer > and avoid read_lock. > > John Fastabend (3): > bpf: xdp, update devmap comments to reflect napi/rcu usage > bpf: xdp, virtio_net use access ptr macro for xdp enable check > bpf: xdp, remove no longer required rcu_read_{un}lock() > > drivers/net/veth.c | 6 +++++- > drivers/net/virtio_net.c | 2 +- > kernel/bpf/devmap.c | 26 ++++++++++++++------------ > 3 files changed, 20 insertions(+), 14 deletions(-) > Series applied, thanks. I had to manually massage the patch 3/3 as it wasn't rebased onto bpf-next.
A couple updates to cleanup some of the XDP comments and rcu usage. It would be best if patch 1/3 goes into current bpf-next with the associated patch in the fixes tag so we don't have out of sync comments in the code. Just noting because its close to time to close {bpf|net}-next branches. v2->v3: Jesper noticed I can't spell, so fixed spelling. If we are fixing comments its best to have correct spelling. v1->v2: Added 2/3 patch for virtio_net to use rcu_access_pointer and avoid read_lock. John Fastabend (3): bpf: xdp, update devmap comments to reflect napi/rcu usage bpf: xdp, virtio_net use access ptr macro for xdp enable check bpf: xdp, remove no longer required rcu_read_{un}lock() drivers/net/veth.c | 6 +++++- drivers/net/virtio_net.c | 2 +- kernel/bpf/devmap.c | 26 ++++++++++++++------------ 3 files changed, 20 insertions(+), 14 deletions(-)