| Message ID | 20200124224142.1833678-1-rdna@fb.com |
|---|---|
| State | Accepted |
| Delegated to: | BPF Maintainers |
| Headers | show |
| Series | [bpf-next] tools/bpf: Allow overriding llvm tools for runqslower | expand |
On Fri, Jan 24, 2020 at 2:42 PM Andrey Ignatov <rdna@fb.com> wrote: > > tools/testing/selftests/bpf/Makefile supports overriding clang, llc and > other tools so that custom ones can be used instead of those from PATH. > It's convinient and heavily used by some users. > > Apply same rules to runqslower/Makefile. > > Signed-off-by: Andrey Ignatov <rdna@fb.com> > --- Thanks! Acked-by: Andrii Nakryiko <andriin@fb.com> > tools/bpf/runqslower/Makefile | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/tools/bpf/runqslower/Makefile b/tools/bpf/runqslower/Makefile > index faf5418609ea..0c021352beed 100644 > --- a/tools/bpf/runqslower/Makefile > +++ b/tools/bpf/runqslower/Makefile > @@ -1,8 +1,8 @@ > # SPDX-License-Identifier: (LGPL-2.1 OR BSD-2-Clause) > OUTPUT := .output > -CLANG := clang > -LLC := llc > -LLVM_STRIP := llvm-strip > +CLANG ?= clang > +LLC ?= llc > +LLVM_STRIP ?= llvm-strip > DEFAULT_BPFTOOL := $(OUTPUT)/sbin/bpftool > BPFTOOL ?= $(DEFAULT_BPFTOOL) > LIBBPF_SRC := $(abspath ../../lib/bpf) > -- > 2.17.1 >
On 1/24/20 11:41 PM, Andrey Ignatov wrote: > tools/testing/selftests/bpf/Makefile supports overriding clang, llc and > other tools so that custom ones can be used instead of those from PATH. > It's convinient and heavily used by some users. > > Apply same rules to runqslower/Makefile. > > Signed-off-by: Andrey Ignatov <rdna@fb.com> Applied, thanks!
diff --git a/tools/bpf/runqslower/Makefile b/tools/bpf/runqslower/Makefile index faf5418609ea..0c021352beed 100644 --- a/tools/bpf/runqslower/Makefile +++ b/tools/bpf/runqslower/Makefile @@ -1,8 +1,8 @@ # SPDX-License-Identifier: (LGPL-2.1 OR BSD-2-Clause) OUTPUT := .output -CLANG := clang -LLC := llc -LLVM_STRIP := llvm-strip +CLANG ?= clang +LLC ?= llc +LLVM_STRIP ?= llvm-strip DEFAULT_BPFTOOL := $(OUTPUT)/sbin/bpftool BPFTOOL ?= $(DEFAULT_BPFTOOL) LIBBPF_SRC := $(abspath ../../lib/bpf)
tools/testing/selftests/bpf/Makefile supports overriding clang, llc and other tools so that custom ones can be used instead of those from PATH. It's convinient and heavily used by some users. Apply same rules to runqslower/Makefile. Signed-off-by: Andrey Ignatov <rdna@fb.com> --- tools/bpf/runqslower/Makefile | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)