| Message ID | 1579064664-16452-2-git-send-email-qiangqing.zhang@nxp.com |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | irqchip: add NXP INTMUX interrupt controller | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/dt-meta-schema | fail | build log |
On Wed, 15 Jan 2020 13:04:23 +0800, Joakim Zhang wrote: > This patch adds the DT bindings for the NXP INTMUX interrupt multiplexer > for i.MX8 family SoCs. > > Signed-off-by: Joakim Zhang <qiangqing.zhang@nxp.com> > --- > .../interrupt-controller/fsl,intmux.yaml | 67 +++++++++++++++++++ > 1 file changed, 67 insertions(+) > create mode 100644 Documentation/devicetree/bindings/interrupt-controller/fsl,intmux.yaml > My bot found errors running 'make dt_binding_check' on your patch: Documentation/devicetree/bindings/display/simple-framebuffer.example.dts:21.16-37.11: Warning (chosen_node_is_root): /example-0/chosen: chosen node must be at root node Error: Documentation/devicetree/bindings/interrupt-controller/fsl,intmux.example.dts:20.27-28 syntax error FATAL ERROR: Unable to parse input tree scripts/Makefile.lib:300: recipe for target 'Documentation/devicetree/bindings/interrupt-controller/fsl,intmux.example.dt.yaml' failed make[1]: *** [Documentation/devicetree/bindings/interrupt-controller/fsl,intmux.example.dt.yaml] Error 1 Makefile:1263: recipe for target 'dt_binding_check' failed make: *** [dt_binding_check] Error 2 See https://patchwork.ozlabs.org/patch/1223172 Please check and re-submit.
> -----Original Message----- > From: Rob Herring <robh@kernel.org> > Sent: 2020年1月17日 3:29 > To: Joakim Zhang <qiangqing.zhang@nxp.com> > Cc: maz@kernel.org; jason@lakedaemon.net; tglx@linutronix.de; > robh+dt@kernel.org; mark.rutland@arm.com; shawnguo@kernel.org; > s.hauer@pengutronix.de; kernel@pengutronix.de; festevam@gmail.com; > linux-kernel@vger.kernel.org; devicetree@vger.kernel.org; > linux-arm-kernel@lists.infradead.org; dl-linux-imx <linux-imx@nxp.com>; Andy > Duan <fugang.duan@nxp.com>; Joakim Zhang <qiangqing.zhang@nxp.com> > Subject: Re: [PATCH V5 1/2] dt-bindings/irq: add binding for NXP INTMUX > interrupt multiplexer > > On Wed, 15 Jan 2020 13:04:23 +0800, Joakim Zhang wrote: > > This patch adds the DT bindings for the NXP INTMUX interrupt > > multiplexer for i.MX8 family SoCs. > > > > Signed-off-by: Joakim Zhang <qiangqing.zhang@nxp.com> > > --- > > .../interrupt-controller/fsl,intmux.yaml | 67 +++++++++++++++++++ > > 1 file changed, 67 insertions(+) > > create mode 100644 > > Documentation/devicetree/bindings/interrupt-controller/fsl,intmux.yaml > > > > My bot found errors running 'make dt_binding_check' on your patch: > > Documentation/devicetree/bindings/display/simple-framebuffer.example.dts:2 > 1.16-37.11: Warning (chosen_node_is_root): /example-0/chosen: chosen node > must be at root node > Error: > Documentation/devicetree/bindings/interrupt-controller/fsl,intmux.example.dt > s:20.27-28 syntax error FATAL ERROR: Unable to parse input tree > scripts/Makefile.lib:300: recipe for target > 'Documentation/devicetree/bindings/interrupt-controller/fsl,intmux.example.d > t.yaml' failed > make[1]: *** > [Documentation/devicetree/bindings/interrupt-controller/fsl,intmux.example.d > t.yaml] Error 1 > Makefile:1263: recipe for target 'dt_binding_check' failed > make: *** [dt_binding_check] Error 2 > > See > https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatchw > ork.ozlabs.org%2Fpatch%2F1223172&data=02%7C01%7Cqiangqing.zhan > g%40nxp.com%7Caade42e256f248dc2ef708d79aba6941%7C686ea1d3bc2b4c6 > fa92cd99c5c301635%7C0%7C0%7C637147997726888265&sdata=7opsZO > V%2FKzIJBl4MoEESCYZa%2BjlzKKofG6m84SsfAHg%3D&reserved=0 > Please check and re-submit. Hi Rob, make dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/interrupt-controller/fsl,intmux.yaml CHKDT Documentation/devicetree/bindings/interrupt-controller/fsl,intmux.yaml SCHEMA Documentation/devicetree/bindings/processed-schema.yaml DTC Documentation/devicetree/bindings/interrupt-controller/fsl,intmux.example.dt.yaml CHECK Documentation/devicetree/bindings/interrupt-controller/fsl,intmux.example.dt.yaml I don't know DTC also need pass the check, sorry for that. I will re-send the patch set. Best Regards, Joakim Zhang
diff --git a/Documentation/devicetree/bindings/interrupt-controller/fsl,intmux.yaml b/Documentation/devicetree/bindings/interrupt-controller/fsl,intmux.yaml new file mode 100644 index 000000000000..ea351bad8902 --- /dev/null +++ b/Documentation/devicetree/bindings/interrupt-controller/fsl,intmux.yaml @@ -0,0 +1,67 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/interrupt-controller/fsl,intmux.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Freescale INTMUX interrupt multiplexer + +maintainers: + - Joakim Zhang <qiangqing.zhang@nxp.com> + +properties: + compatible: + const: fsl,imx-intmux + + reg: + maxItems: 1 + + interrupts: + minItems: 1 + maxItems: 8 + description: | + Should contain the parent interrupt lines (up to 8) used to multiplex + the input interrupts. + + interrupt-controller: true + + '#interrupt-cells': + const: 2 + description: | + The 1st cell is hw interrupt number, the 2nd cell is channel index. + + clocks: + description: ipg clock. + + clock-names: + const: ipg + +required: + - compatible + - reg + - interrupts + - interrupt-controller + - '#interrupt-cells' + - clocks + - clock-names + +additionalProperties: false + +examples: + - | + interrupt-controller@37400000 { + compatible = "fsl,imx-intmux"; + reg = <0x37400000 0x1000>; + interrupts = <GIC_SPI 16 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 17 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 18 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 19 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 20 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 21 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 22 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 23 IRQ_TYPE_LEVEL_HIGH>; + interrupt-controller; + #interrupt-cells = <2>; + clocks = <&clk IMX8QM_CM40_IPG_CLK>; + clock-names = "ipg"; + };
This patch adds the DT bindings for the NXP INTMUX interrupt multiplexer for i.MX8 family SoCs. Signed-off-by: Joakim Zhang <qiangqing.zhang@nxp.com> --- .../interrupt-controller/fsl,intmux.yaml | 67 +++++++++++++++++++ 1 file changed, 67 insertions(+) create mode 100644 Documentation/devicetree/bindings/interrupt-controller/fsl,intmux.yaml