diff mbox series

package/libupnp18: add config option --enable-reuseaddr

Message ID 20200109103241.3786-1-joerg.krause@embedded.rocks
State Accepted
Headers show
Series package/libupnp18: add config option --enable-reuseaddr | expand

Commit Message

Jörg Krause Jan. 9, 2020, 10:32 a.m. UTC
Enable the option to use SO_REUSEADDR on the built-in miniserver
socket to allow clean restarts [1].

This fixes a runtime issue with Gerbera and possible other programs
which does not allow a graceful restart otherwise.

[1] https://github.com/pupnp/pupnp/commit/629dec75610260a669c7c3ed40c9332b7917b562

Signed-off-by: Jörg Krause <joerg.krause@embedded.rocks>
---
 package/libupnp18/libupnp18.mk | 3 +++
 1 file changed, 3 insertions(+)

Comments

Yann E. MORIN Jan. 9, 2020, 4:51 p.m. UTC | #1
Jörg, All,

On 2020-01-09 11:32 +0100, Jörg Krause spake thusly:
> Enable the option to use SO_REUSEADDR on the built-in miniserver
> socket to allow clean restarts [1].
> 
> This fixes a runtime issue with Gerbera and possible other programs
> which does not allow a graceful restart otherwise.
> 
> [1] https://github.com/pupnp/pupnp/commit/629dec75610260a669c7c3ed40c9332b7917b562
> 
> Signed-off-by: Jörg Krause <joerg.krause@embedded.rocks>

Applied to master, thanks.

Regards,
Yann E. MORIN.

> ---
>  package/libupnp18/libupnp18.mk | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/package/libupnp18/libupnp18.mk b/package/libupnp18/libupnp18.mk
> index ca82a54413..f73c656831 100644
> --- a/package/libupnp18/libupnp18.mk
> +++ b/package/libupnp18/libupnp18.mk
> @@ -13,6 +13,9 @@ LIBUPNP18_LICENSE = BSD-3-Clause
>  LIBUPNP18_LICENSE_FILES = COPYING
>  LIBUPNP18_DEPENDENCIES = host-pkgconf
>  
> +# Bind the internal miniserver socket with reuseaddr to allow clean restarts.
> +LIBUPNP18_CONF_OPTS += --enable-reuseaddr
> +
>  ifeq ($(BR2_PACKAGE_OPENSSL),y)
>  LIBUPNP18_CONF_OPTS += --enable-open-ssl
>  LIBUPNP18_DEPENDENCIES += openssl
> -- 
> 2.24.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot@busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
diff mbox series

Patch

diff --git a/package/libupnp18/libupnp18.mk b/package/libupnp18/libupnp18.mk
index ca82a54413..f73c656831 100644
--- a/package/libupnp18/libupnp18.mk
+++ b/package/libupnp18/libupnp18.mk
@@ -13,6 +13,9 @@  LIBUPNP18_LICENSE = BSD-3-Clause
 LIBUPNP18_LICENSE_FILES = COPYING
 LIBUPNP18_DEPENDENCIES = host-pkgconf
 
+# Bind the internal miniserver socket with reuseaddr to allow clean restarts.
+LIBUPNP18_CONF_OPTS += --enable-reuseaddr
+
 ifeq ($(BR2_PACKAGE_OPENSSL),y)
 LIBUPNP18_CONF_OPTS += --enable-open-ssl
 LIBUPNP18_DEPENDENCIES += openssl