| Message ID | 5764e60da6d3af7e76c30f63b07f1a12b4787918.1578400471.git.Jose.Abreu@synopsys.com |
|---|---|
| State | Accepted |
| Delegated to: | David Miller |
| Headers | show |
| Series | [net] net: stmmac: Fixed link does not need MDIO Bus | expand |
> From: Jose Abreu <Jose.Abreu@synopsys.com> > Subject: [PATCH net] net: stmmac: Fixed link does not need MDIO Bus > > When using fixed link we don't need the MDIO bus support. > > Reported-by: Heiko Stuebner <heiko@sntech.de> > Reported-by: kernelci.org bot <bot@kernelci.org> > Fixes: d3e014ec7d5e ("net: stmmac: platform: Fix MDIO init for platforms > without PHY") > Signed-off-by: Jose Abreu <Jose.Abreu@synopsys.com> Acked-by: Sriram Dash <Sriram.dash@samsung.com> > > --- > Cc: Giuseppe Cavallaro <peppe.cavallaro@st.com> > Cc: Alexandre Torgue <alexandre.torgue@st.com> > Cc: Jose Abreu <joabreu@synopsys.com> > Cc: "David S. Miller" <davem@davemloft.net> > Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com> > Cc: netdev@vger.kernel.org > Cc: linux-stm32@st-md-mailman.stormreply.com > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-kernel@vger.kernel.org > Cc: Heiko Stuebner <heiko@sntech.de> > Cc: kernelci.org bot <bot@kernelci.org> > Cc: Florian Fainelli <f.fainelli@gmail.com> > Cc: Sriram Dash <sriram.dash@samsung.com> > --- > drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c > b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c > index cc8d7e7bf9ac..4775f49d7f3b 100644 > --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c > +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c > @@ -320,7 +320,7 @@ static int stmmac_mtl_setup(struct platform_device > *pdev, static int stmmac_dt_phy(struct plat_stmmacenet_data *plat, > struct device_node *np, struct device *dev) { > - bool mdio = false; > + bool mdio = !of_phy_is_fixed_link(np); > static const struct of_device_id need_mdio_ids[] = { > { .compatible = "snps,dwc-qos-ethernet-4.10" }, > {}, > -- > 2.7.4
Hi All On 1/7/20 1:51 PM, Sriram Dash wrote: >> From: Jose Abreu <Jose.Abreu@synopsys.com> >> Subject: [PATCH net] net: stmmac: Fixed link does not need MDIO Bus >> >> When using fixed link we don't need the MDIO bus support. >> >> Reported-by: Heiko Stuebner <heiko@sntech.de> >> Reported-by: kernelci.org bot <bot@kernelci.org> >> Fixes: d3e014ec7d5e ("net: stmmac: platform: Fix MDIO init for platforms >> without PHY") >> Signed-off-by: Jose Abreu <Jose.Abreu@synopsys.com> > Acked-by: Sriram Dash <Sriram.dash@samsung.com> Tested on STiH410-B2260 board Tested-by: Patrice Chotard <patrice.chotard@st.com> Thanks >> --- >> Cc: Giuseppe Cavallaro <peppe.cavallaro@st.com> >> Cc: Alexandre Torgue <alexandre.torgue@st.com> >> Cc: Jose Abreu <joabreu@synopsys.com> >> Cc: "David S. Miller" <davem@davemloft.net> >> Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com> >> Cc: netdev@vger.kernel.org >> Cc: linux-stm32@st-md-mailman.stormreply.com >> Cc: linux-arm-kernel@lists.infradead.org >> Cc: linux-kernel@vger.kernel.org >> Cc: Heiko Stuebner <heiko@sntech.de> >> Cc: kernelci.org bot <bot@kernelci.org> >> Cc: Florian Fainelli <f.fainelli@gmail.com> >> Cc: Sriram Dash <sriram.dash@samsung.com> >> --- >> drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c >> b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c >> index cc8d7e7bf9ac..4775f49d7f3b 100644 >> --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c >> +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c >> @@ -320,7 +320,7 @@ static int stmmac_mtl_setup(struct platform_device >> *pdev, static int stmmac_dt_phy(struct plat_stmmacenet_data *plat, >> struct device_node *np, struct device *dev) { >> - bool mdio = false; >> + bool mdio = !of_phy_is_fixed_link(np); >> static const struct of_device_id need_mdio_ids[] = { >> { .compatible = "snps,dwc-qos-ethernet-4.10" }, >> {}, >> -- >> 2.7.4 > > _______________________________________________ > Linux-stm32 mailing list > Linux-stm32@st-md-mailman.stormreply.com > https://st-md-mailman.stormreply.com/mailman/listinfo/linux-stm32
Am Dienstag, 7. Januar 2020, 13:35:42 CET schrieb Jose Abreu: > When using fixed link we don't need the MDIO bus support. > > Reported-by: Heiko Stuebner <heiko@sntech.de> > Reported-by: kernelci.org bot <bot@kernelci.org> > Fixes: d3e014ec7d5e ("net: stmmac: platform: Fix MDIO init for platforms without PHY") > Signed-off-by: Jose Abreu <Jose.Abreu@synopsys.com> On px30 Tested-by: Heiko Stuebner <heiko@sntech.de>
On 07/01/2020 13:35, Jose Abreu wrote: > When using fixed link we don't need the MDIO bus support. > > Reported-by: Heiko Stuebner <heiko@sntech.de> > Reported-by: kernelci.org bot <bot@kernelci.org> > Fixes: d3e014ec7d5e ("net: stmmac: platform: Fix MDIO init for platforms without PHY") > Signed-off-by: Jose Abreu <Jose.Abreu@synopsys.com> > > --- > Cc: Giuseppe Cavallaro <peppe.cavallaro@st.com> > Cc: Alexandre Torgue <alexandre.torgue@st.com> > Cc: Jose Abreu <joabreu@synopsys.com> > Cc: "David S. Miller" <davem@davemloft.net> > Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com> > Cc: netdev@vger.kernel.org > Cc: linux-stm32@st-md-mailman.stormreply.com > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-kernel@vger.kernel.org > Cc: Heiko Stuebner <heiko@sntech.de> > Cc: kernelci.org bot <bot@kernelci.org> > Cc: Florian Fainelli <f.fainelli@gmail.com> > Cc: Sriram Dash <sriram.dash@samsung.com> > --- > drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c > index cc8d7e7bf9ac..4775f49d7f3b 100644 > --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c > +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c > @@ -320,7 +320,7 @@ static int stmmac_mtl_setup(struct platform_device *pdev, > static int stmmac_dt_phy(struct plat_stmmacenet_data *plat, > struct device_node *np, struct device *dev) > { > - bool mdio = false; > + bool mdio = !of_phy_is_fixed_link(np); > static const struct of_device_id need_mdio_ids[] = { > { .compatible = "snps,dwc-qos-ethernet-4.10" }, > {}, > Acked-by: Neil Armstrong <narmstrong@baylibre.com>
On 1/7/20 4:35 AM, Jose Abreu wrote: > When using fixed link we don't need the MDIO bus support. > > Reported-by: Heiko Stuebner <heiko@sntech.de> > Reported-by: kernelci.org bot <bot@kernelci.org> > Fixes: d3e014ec7d5e ("net: stmmac: platform: Fix MDIO init for platforms without PHY") > Signed-off-by: Jose Abreu <Jose.Abreu@synopsys.com> Reviewed-by: Florian Fainelli <f.fainelli@gmail.com> Tested-by: Florian Fainelli <f.fainelli@gmail> # Lamobo R1 (fixed-link + MDIO sub node for roboswitch).
From: Jose Abreu <Jose.Abreu@synopsys.com> Date: Tue, 7 Jan 2020 13:35:42 +0100 > When using fixed link we don't need the MDIO bus support. > > Reported-by: Heiko Stuebner <heiko@sntech.de> > Reported-by: kernelci.org bot <bot@kernelci.org> > Fixes: d3e014ec7d5e ("net: stmmac: platform: Fix MDIO init for platforms without PHY") > Signed-off-by: Jose Abreu <Jose.Abreu@synopsys.com> Applied.
From: Florian Fainelli <f.fainelli@gmail.com> Date: Tue, 7 Jan 2020 11:05:07 -0800 > Reviewed-by: Florian Fainelli <f.fainelli@gmail.com> > Tested-by: Florian Fainelli <f.fainelli@gmail> # Lamobo R1 (fixed-link + > MDIO sub node for roboswitch). Florian please be careful not to let individual tags split into multiple lines, I had to hand edit the second part of the Tested-by: tag into the commit message.
diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c index cc8d7e7bf9ac..4775f49d7f3b 100644 --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c @@ -320,7 +320,7 @@ static int stmmac_mtl_setup(struct platform_device *pdev, static int stmmac_dt_phy(struct plat_stmmacenet_data *plat, struct device_node *np, struct device *dev) { - bool mdio = false; + bool mdio = !of_phy_is_fixed_link(np); static const struct of_device_id need_mdio_ids[] = { { .compatible = "snps,dwc-qos-ethernet-4.10" }, {},
When using fixed link we don't need the MDIO bus support. Reported-by: Heiko Stuebner <heiko@sntech.de> Reported-by: kernelci.org bot <bot@kernelci.org> Fixes: d3e014ec7d5e ("net: stmmac: platform: Fix MDIO init for platforms without PHY") Signed-off-by: Jose Abreu <Jose.Abreu@synopsys.com> --- Cc: Giuseppe Cavallaro <peppe.cavallaro@st.com> Cc: Alexandre Torgue <alexandre.torgue@st.com> Cc: Jose Abreu <joabreu@synopsys.com> Cc: "David S. Miller" <davem@davemloft.net> Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com> Cc: netdev@vger.kernel.org Cc: linux-stm32@st-md-mailman.stormreply.com Cc: linux-arm-kernel@lists.infradead.org Cc: linux-kernel@vger.kernel.org Cc: Heiko Stuebner <heiko@sntech.de> Cc: kernelci.org bot <bot@kernelci.org> Cc: Florian Fainelli <f.fainelli@gmail.com> Cc: Sriram Dash <sriram.dash@samsung.com> --- drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)