diff mbox series

bna: remove set but not used variable 'pgoff'

Message ID 20200103120437.46400-1-yukuai3@huawei.com
State Accepted
Delegated to: David Miller
Headers show
Series bna: remove set but not used variable 'pgoff' | expand

Commit Message

yukuai (C) Jan. 3, 2020, 12:04 p.m. UTC
drivers/net/ethernet/brocade/bna/bfa_ioc.c: In function
‘bfa_ioc_fwver_clear’:
drivers/net/ethernet/brocade/bna/bfa_ioc.c:1127:13: warning: variable
‘pgoff’ set but not used [-Wunused-but-set-variable]

It is never used, and so can be removed.

Signed-off-by: yu kuai <yukuai3@huawei.com>
---
 drivers/net/ethernet/brocade/bna/bfa_ioc.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Comments

David Miller Jan. 3, 2020, 8:33 p.m. UTC | #1
From: yu kuai <yukuai3@huawei.com>
Date: Fri, 3 Jan 2020 20:04:37 +0800

> drivers/net/ethernet/brocade/bna/bfa_ioc.c: In function
> ‘bfa_ioc_fwver_clear’:
> drivers/net/ethernet/brocade/bna/bfa_ioc.c:1127:13: warning: variable
> ‘pgoff’ set but not used [-Wunused-but-set-variable]
> 
> It is never used, and so can be removed.
> 
> Signed-off-by: yu kuai <yukuai3@huawei.com>

Applied.
diff mbox series

Patch

diff --git a/drivers/net/ethernet/brocade/bna/bfa_ioc.c b/drivers/net/ethernet/brocade/bna/bfa_ioc.c
index 4042c2185e98..e17bfc87da90 100644
--- a/drivers/net/ethernet/brocade/bna/bfa_ioc.c
+++ b/drivers/net/ethernet/brocade/bna/bfa_ioc.c
@@ -1124,11 +1124,10 @@  bfa_nw_ioc_sem_release(void __iomem *sem_reg)
 static void
 bfa_ioc_fwver_clear(struct bfa_ioc *ioc)
 {
-	u32 pgnum, pgoff, loff = 0;
+	u32 pgnum, loff = 0;
 	int i;
 
 	pgnum = PSS_SMEM_PGNUM(ioc->ioc_regs.smem_pg0, loff);
-	pgoff = PSS_SMEM_PGOFF(loff);
 	writel(pgnum, ioc->ioc_regs.host_page_num_fn);
 
 	for (i = 0; i < (sizeof(struct bfi_ioc_image_hdr) / sizeof(u32)); i++) {