| Message ID | 157746672570.257308.7385062978550192444.stgit@firesoul |
|---|---|
| Headers | show |
| Series | page_pool: NUMA node handling fixes | expand |
From: Jesper Dangaard Brouer <brouer@redhat.com> Date: Fri, 27 Dec 2019 18:13:13 +0100 > The recently added NUMA changes (merged for v5.5) to page_pool, it both > contains a bug in handling NUMA_NO_NODE condition, and added code to > the fast-path. > > This patchset fixes the bug and moves code out of fast-path. The first > patch contains a fix that should be considered for 5.5. The second > patch reduce code size and overhead in case CONFIG_NUMA is disabled. > > Currently the NUMA_NO_NODE setting bug only affects driver 'ti_cpsw' > (drivers/net/ethernet/ti/), but after this patchset, we plan to move > other drivers (netsec and mvneta) to use NUMA_NO_NODE setting. Series applied to net-next with the "fallthrough" misspelling fixed in patch #1. Thank you.
Thanks David On Thu, Jan 02, 2020 at 03:38:25PM -0800, David Miller wrote: > From: Jesper Dangaard Brouer <brouer@redhat.com> > Date: Fri, 27 Dec 2019 18:13:13 +0100 > > > The recently added NUMA changes (merged for v5.5) to page_pool, it both > > contains a bug in handling NUMA_NO_NODE condition, and added code to > > the fast-path. > > > > This patchset fixes the bug and moves code out of fast-path. The first > > patch contains a fix that should be considered for 5.5. The second > > patch reduce code size and overhead in case CONFIG_NUMA is disabled. > > > > Currently the NUMA_NO_NODE setting bug only affects driver 'ti_cpsw' > > (drivers/net/ethernet/ti/), but after this patchset, we plan to move > > other drivers (netsec and mvneta) to use NUMA_NO_NODE setting. > > Series applied to net-next with the "fallthrough" misspelling fixed in > patch #1. > > Thank you. I did review the patch and everything seemed fine, i was waiting Saeed to test it in any case you can add my reviewed by if it's not too late Reviewed-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>
The recently added NUMA changes (merged for v5.5) to page_pool, it both contains a bug in handling NUMA_NO_NODE condition, and added code to the fast-path. This patchset fixes the bug and moves code out of fast-path. The first patch contains a fix that should be considered for 5.5. The second patch reduce code size and overhead in case CONFIG_NUMA is disabled. Currently the NUMA_NO_NODE setting bug only affects driver 'ti_cpsw' (drivers/net/ethernet/ti/), but after this patchset, we plan to move other drivers (netsec and mvneta) to use NUMA_NO_NODE setting. --- Jesper Dangaard Brouer (2): page_pool: handle page recycle for NUMA_NO_NODE condition page_pool: help compiler remove code in case CONFIG_NUMA=n net/core/page_pool.c | 89 +++++++++++++++++++++++++++++++++++++++----------- 1 file changed, 70 insertions(+), 19 deletions(-) --