Message ID | 20191230143028.27313-17-alobakin@dlink.ru |
---|---|
State | RFC |
Delegated to: | David Miller |
Headers | show |
Series | net: dsa: add GRO support | expand |
On Mon, Dec 30, 2019 at 05:30:24PM +0300, Alexander Lobakin wrote: > DSA core updates Tx stats for slaves in dsa_slave_xmit(), no need to do > it manually in .xmit() tagger callback. > > Signed-off-by: Alexander Lobakin <alobakin@dlink.ru> Reviewed-by: Andrew Lunn <andrew@lunn.ch> Andrew
On 12/30/19 9:23 AM, Andrew Lunn wrote: > On Mon, Dec 30, 2019 at 05:30:24PM +0300, Alexander Lobakin wrote: >> DSA core updates Tx stats for slaves in dsa_slave_xmit(), no need to do >> it manually in .xmit() tagger callback. >> >> Signed-off-by: Alexander Lobakin <alobakin@dlink.ru> > > Reviewed-by: Andrew Lunn <andrew@lunn.ch> Alexander, can you submit that separately from your GRO series and add a Fixes tag for this? Thanks!
diff --git a/net/dsa/tag_qca.c b/net/dsa/tag_qca.c index 8e2dbaaffe59..e1c4dd04734a 100644 --- a/net/dsa/tag_qca.c +++ b/net/dsa/tag_qca.c @@ -33,9 +33,6 @@ static struct sk_buff *qca_tag_xmit(struct sk_buff *skb, struct net_device *dev) struct dsa_port *dp = dsa_slave_to_port(dev); u16 *phdr, hdr; - dev->stats.tx_packets++; - dev->stats.tx_bytes += skb->len; - if (skb_cow_head(skb, 0) < 0) return NULL;
DSA core updates Tx stats for slaves in dsa_slave_xmit(), no need to do it manually in .xmit() tagger callback. Signed-off-by: Alexander Lobakin <alobakin@dlink.ru> --- net/dsa/tag_qca.c | 3 --- 1 file changed, 3 deletions(-)