Message ID | 20191230143028.27313-7-alobakin@dlink.ru |
---|---|
State | RFC |
Delegated to: | David Miller |
Headers | show |
Series | net: dsa: add GRO support | expand |
On Mon, Dec 30, 2019 at 05:30:14PM +0300, Alexander Lobakin wrote: > "gwsip" -> "gswip". > > Signed-off-by: Alexander Lobakin <alobakin@dlink.ru> Reviewed-by: Andrew Lunn <andrew@lunn.ch> Andrew
On 12/30/19 9:22 AM, Andrew Lunn wrote: > On Mon, Dec 30, 2019 at 05:30:14PM +0300, Alexander Lobakin wrote: >> "gwsip" -> "gswip". >> >> Signed-off-by: Alexander Lobakin <alobakin@dlink.ru> > > Reviewed-by: Andrew Lunn <andrew@lunn.ch> Likewise, this is a bug fix that should be extracted out of this GRO series and a Fixes: tag be put since this has an user-visible impact through /sys/class/net/*/dsa/tagging. Thanks
Florian Fainelli wrote 15.01.2020 00:57: > On 12/30/19 9:22 AM, Andrew Lunn wrote: >> On Mon, Dec 30, 2019 at 05:30:14PM +0300, Alexander Lobakin wrote: >>> "gwsip" -> "gswip". >>> >>> Signed-off-by: Alexander Lobakin <alobakin@dlink.ru> >> >> Reviewed-by: Andrew Lunn <andrew@lunn.ch> > > Likewise, this is a bug fix that should be extracted out of this GRO > series and a Fixes: tag be put since this has an user-visible impact > through /sys/class/net/*/dsa/tagging. Sure, I'll pull some really important fixes (like this one and doubled Tx stats in tag_qca) out of this series and submit them as separate patches, maybe even in net-fixes tree? > Thanks Regards, ᚷ ᛖ ᚢ ᚦ ᚠ ᚱ
diff --git a/net/dsa/tag_gswip.c b/net/dsa/tag_gswip.c index b678160bbd66..408d4af390a0 100644 --- a/net/dsa/tag_gswip.c +++ b/net/dsa/tag_gswip.c @@ -104,7 +104,7 @@ static struct sk_buff *gswip_tag_rcv(struct sk_buff *skb, } static const struct dsa_device_ops gswip_netdev_ops = { - .name = "gwsip", + .name = "gswip", .proto = DSA_TAG_PROTO_GSWIP, .xmit = gswip_tag_xmit, .rcv = gswip_tag_rcv,
"gwsip" -> "gswip". Signed-off-by: Alexander Lobakin <alobakin@dlink.ru> --- net/dsa/tag_gswip.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)