Message ID | 20191230143028.27313-1-alobakin@dlink.ru |
---|---|
Headers | show |
Series | net: dsa: add GRO support | expand |
> I mark this as RFC, and there are the key questions for maintainers, > developers, users etc.: > - Do we need GRO support for DSA at all? > - Does this series bring any performance improvements on the > affected systems? Hi Alexander I think these are the two most important questions. Did you do any performance testing for the hardware you have? I personally don't have any of the switches you have made modifications to, so i cannot test these patches. I might be able to add GRO to DSA and EDSA, where i can do some performance testing. Andrew
Hi Alexander, On Mon, 30 Dec 2019 at 16:31, Alexander Lobakin <alobakin@dlink.ru> wrote: > > I mark this as RFC, and there are the key questions for maintainers, > developers, users etc.: > - Do we need GRO support for DSA at all? > - Which tagger protocols really need it and which don't? > - Does this series bring any performance improvements on the > affected systems? If these are these questions for maintainers, developers, users etc, then what has determined you to make these changes? Thanks, -Vladimir
Andrew Lunn wrote 30.12.2019 20:12: >> I mark this as RFC, and there are the key questions for maintainers, >> developers, users etc.: >> - Do we need GRO support for DSA at all? > >> - Does this series bring any performance improvements on the >> affected systems? > > Hi Alexander Hi, > I think these are the two most important questions. Did you do any > performance testing for the hardware you have? Exactly, this are the top questions. I performed lots of tests on hardware with which I'm working on and had a pretty good boosts (I didn't mainlined my drivers yet unfortunately). But this does not mean that GRO would be that nice for all kind of devices *at all*. That's why I would like to see more test results on different systems. > I personally don't have any of the switches you have made > modifications to, so i cannot test these patches. I might be able to > add GRO to DSA and EDSA, where i can do some performance testing. > > Andrew Regards, ᚷ ᛖ ᚢ ᚦ ᚠ ᚱ
Vladimir Oltean wrote 31.12.2019 18:32: > Hi Alexander, Hi, > On Mon, 30 Dec 2019 at 16:31, Alexander Lobakin <alobakin@dlink.ru> > wrote: >> >> I mark this as RFC, and there are the key questions for maintainers, >> developers, users etc.: >> - Do we need GRO support for DSA at all? >> - Which tagger protocols really need it and which don't? >> - Does this series bring any performance improvements on the >> affected systems? > > If these are these questions for maintainers, developers, users etc, > then what has determined you to make these changes? The main reason was obviously pretty good results on a particular hardware on which I developed this (and other) series and a general opinion that GRO improves overall performance on most systems. DSA is a special case though. > Thanks, > -Vladimir Regards, ᚷ ᛖ ᚢ ᚦ ᚠ ᚱ