mbox series

[iproute2-next,00/10] tc: add support for JSON output in some qdiscs

Message ID 20191225190418.8806-1-lesliemonis@gmail.com
Headers show
Series tc: add support for JSON output in some qdiscs | expand

Message

Leslie Monis Dec. 25, 2019, 7:04 p.m. UTC
Several qdiscs do not yet support the JSON output format. This patch series
adds the missing compatibility to 9 classless qdiscs. Some of the patches
also improve the oneline output of the qdiscs. The last patch in the series
fixes a missing statistic in the JSON output of fq_codel.

Leslie Monis (10):
  tc: cbs: add support for JSON output
  tc: choke: add support for JSON output
  tc: codel: add support for JSON output
  tc: fq: add support for JSON output
  tc: hhf: add support for JSON output
  tc: pie: add support for JSON output
  tc: sfb: add support for JSON output
  tc: sfq: add support for JSON output
  tc: tbf: add support for JSON output
  tc: fq_codel: fix missing statistic in JSON output

 man/man8/tc-fq.8  |  14 +++---
 man/man8/tc-pie.8 |  16 +++----
 tc/q_cbs.c        |  10 ++---
 tc/q_choke.c      |  26 +++++++----
 tc/q_codel.c      |  45 +++++++++++++------
 tc/q_fq.c         | 108 ++++++++++++++++++++++++++++++++--------------
 tc/q_fq_codel.c   |   4 +-
 tc/q_hhf.c        |  33 +++++++++-----
 tc/q_pie.c        |  47 ++++++++++++--------
 tc/q_sfb.c        |  67 ++++++++++++++++++----------
 tc/q_sfq.c        |  66 +++++++++++++++++-----------
 tc/q_tbf.c        |  68 ++++++++++++++++++++---------
 12 files changed, 335 insertions(+), 169 deletions(-)

Comments

Stephen Hemminger Dec. 27, 2019, 2:19 a.m. UTC | #1
On Thu, 26 Dec 2019 00:34:08 +0530
Leslie Monis <lesliemonis@gmail.com> wrote:

> Several qdiscs do not yet support the JSON output format. This patch series
> adds the missing compatibility to 9 classless qdiscs. Some of the patches
> also improve the oneline output of the qdiscs. The last patch in the series
> fixes a missing statistic in the JSON output of fq_codel.
> 
> Leslie Monis (10):
>   tc: cbs: add support for JSON output
>   tc: choke: add support for JSON output
>   tc: codel: add support for JSON output
>   tc: fq: add support for JSON output
>   tc: hhf: add support for JSON output
>   tc: pie: add support for JSON output
>   tc: sfb: add support for JSON output
>   tc: sfq: add support for JSON output
>   tc: tbf: add support for JSON output
>   tc: fq_codel: fix missing statistic in JSON output
> 
>  man/man8/tc-fq.8  |  14 +++---
>  man/man8/tc-pie.8 |  16 +++----
>  tc/q_cbs.c        |  10 ++---
>  tc/q_choke.c      |  26 +++++++----
>  tc/q_codel.c      |  45 +++++++++++++------
>  tc/q_fq.c         | 108 ++++++++++++++++++++++++++++++++--------------
>  tc/q_fq_codel.c   |   4 +-
>  tc/q_hhf.c        |  33 +++++++++-----
>  tc/q_pie.c        |  47 ++++++++++++--------
>  tc/q_sfb.c        |  67 ++++++++++++++++++----------
>  tc/q_sfq.c        |  66 +++++++++++++++++-----------
>  tc/q_tbf.c        |  68 ++++++++++++++++++++---------
>  12 files changed, 335 insertions(+), 169 deletions(-)
> 

After I test these, looks like they could go into iproute2 directly
and skip next. There is no kernel version dependency
Leslie Monis Dec. 27, 2019, 11:13 a.m. UTC | #2
On Fri, Dec 27, 2019 at 7:49 AM Stephen Hemminger
<stephen@networkplumber.org> wrote:
>
> On Thu, 26 Dec 2019 00:34:08 +0530
> Leslie Monis <lesliemonis@gmail.com> wrote:
>
> > Several qdiscs do not yet support the JSON output format. This patch series
> > adds the missing compatibility to 9 classless qdiscs. Some of the patches
> > also improve the oneline output of the qdiscs. The last patch in the series
> > fixes a missing statistic in the JSON output of fq_codel.
> >
> > Leslie Monis (10):
> >   tc: cbs: add support for JSON output
> >   tc: choke: add support for JSON output
> >   tc: codel: add support for JSON output
> >   tc: fq: add support for JSON output
> >   tc: hhf: add support for JSON output
> >   tc: pie: add support for JSON output
> >   tc: sfb: add support for JSON output
> >   tc: sfq: add support for JSON output
> >   tc: tbf: add support for JSON output
> >   tc: fq_codel: fix missing statistic in JSON output
> >
> >  man/man8/tc-fq.8  |  14 +++---
> >  man/man8/tc-pie.8 |  16 +++----
> >  tc/q_cbs.c        |  10 ++---
> >  tc/q_choke.c      |  26 +++++++----
> >  tc/q_codel.c      |  45 +++++++++++++------
> >  tc/q_fq.c         | 108 ++++++++++++++++++++++++++++++++--------------
> >  tc/q_fq_codel.c   |   4 +-
> >  tc/q_hhf.c        |  33 +++++++++-----
> >  tc/q_pie.c        |  47 ++++++++++++--------
> >  tc/q_sfb.c        |  67 ++++++++++++++++++----------
> >  tc/q_sfq.c        |  66 +++++++++++++++++-----------
> >  tc/q_tbf.c        |  68 ++++++++++++++++++++---------
> >  12 files changed, 335 insertions(+), 169 deletions(-)
> >
>
> After I test these, looks like they could go into iproute2 directly
> and skip next. There is no kernel version dependency

Sure, that's fine with me.
Thanks
Stephen Hemminger Dec. 29, 2019, 6:04 p.m. UTC | #3
On Thu, 26 Dec 2019 00:34:08 +0530
Leslie Monis <lesliemonis@gmail.com> wrote:

> Several qdiscs do not yet support the JSON output format. This patch series
> adds the missing compatibility to 9 classless qdiscs. Some of the patches
> also improve the oneline output of the qdiscs. The last patch in the series
> fixes a missing statistic in the JSON output of fq_codel.
> 
> Leslie Monis (10):
>   tc: cbs: add support for JSON output
>   tc: choke: add support for JSON output
>   tc: codel: add support for JSON output
>   tc: fq: add support for JSON output
>   tc: hhf: add support for JSON output
>   tc: pie: add support for JSON output
>   tc: sfb: add support for JSON output
>   tc: sfq: add support for JSON output
>   tc: tbf: add support for JSON output
>   tc: fq_codel: fix missing statistic in JSON output
> 
>  man/man8/tc-fq.8  |  14 +++---
>  man/man8/tc-pie.8 |  16 +++----
>  tc/q_cbs.c        |  10 ++---
>  tc/q_choke.c      |  26 +++++++----
>  tc/q_codel.c      |  45 +++++++++++++------
>  tc/q_fq.c         | 108 ++++++++++++++++++++++++++++++++--------------
>  tc/q_fq_codel.c   |   4 +-
>  tc/q_hhf.c        |  33 +++++++++-----
>  tc/q_pie.c        |  47 ++++++++++++--------
>  tc/q_sfb.c        |  67 ++++++++++++++++++----------
>  tc/q_sfq.c        |  66 +++++++++++++++++-----------
>  tc/q_tbf.c        |  68 ++++++++++++++++++++---------
>  12 files changed, 335 insertions(+), 169 deletions(-)
> 

Applied, thanks for doing this.