Message ID | cover.1576515562.git.petrm@mellanox.com |
---|---|
Headers | show |
Series | Add a new Qdisc, ETS | expand |
From: Petr Machata <petrm@mellanox.com> Date: Mon, 16 Dec 2019 17:01:36 +0000 > The IEEE standard 802.1Qaz (and 802.1Q-2014) specifies four principal > transmission selection algorithms: strict priority, credit-based shaper, > ETS (bandwidth sharing), and vendor-specific. All these have their > corresponding knobs in DCB. But DCB does not have interfaces to configure > RED and ECN, unlike Qdiscs. ... I have no problem with this new schedule or how it is coded. But I really want there to be some documentation blurb in the Kconfig entry (less verbose) and in a code comment of the scheduler itself (more verbose) which explains where this is derived from. People can indeed look at the commit but I think if someone just sees the new Kconfig or looks at the code they should be able to read something there that says what this thing is. The commit log message for patch #4 would be good to use as a basis. Thank you.
David Miller <davem@davemloft.net> writes: > From: Petr Machata <petrm@mellanox.com> > Date: Mon, 16 Dec 2019 17:01:36 +0000 > >> The IEEE standard 802.1Qaz (and 802.1Q-2014) specifies four principal >> transmission selection algorithms: strict priority, credit-based shaper, >> ETS (bandwidth sharing), and vendor-specific. All these have their >> corresponding knobs in DCB. But DCB does not have interfaces to configure >> RED and ECN, unlike Qdiscs. > ... > > I have no problem with this new schedule or how it is coded. > > But I really want there to be some documentation blurb in the Kconfig > entry (less verbose) and in a code comment of the scheduler itself > (more verbose) which explains where this is derived from. > > People can indeed look at the commit but I think if someone just sees > the new Kconfig or looks at the code they should be able to read > something there that says what this thing is. > > The commit log message for patch #4 would be good to use as a basis. > > Thank you. OK, I'll spin a v2.