| Message ID | 35a23315938909c80e7772838e1de0d2d46302f2.1576499103.git.agx@sigxcpu.org |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | leds: lm3692x: Allow to set ovp and brigthness mode | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success |
Guido Thanks for the patch On 12/16/19 6:28 AM, Guido Günther wrote: > We allow configuration of brightness mode and over voltage > protection. > > Signed-off-by: Guido Günther <agx@sigxcpu.org> > --- > Documentation/devicetree/bindings/leds/leds-lm3692x.txt | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/Documentation/devicetree/bindings/leds/leds-lm3692x.txt b/Documentation/devicetree/bindings/leds/leds-lm3692x.txt > index 4c2d923f8758..f195e8b45d85 100644 > --- a/Documentation/devicetree/bindings/leds/leds-lm3692x.txt > +++ b/Documentation/devicetree/bindings/leds/leds-lm3692x.txt > @@ -18,6 +18,10 @@ Required properties: > Optional properties: > - enable-gpios : gpio pin to enable/disable the device. > - vled-supply : LED supply > + - ti,brightness-mapping-exponential: Whether to use exponential > + brightness mapping > + - ti,overvoltage-volts: Overvoltage protection in Volts, can > + be 0 (unprotected), 21, 25 or 29V > Can you show examples of these in the DT binding? Dan
On Mon 2019-12-16 13:28:05, Guido Günther wrote: > We allow configuration of brightness mode and over voltage > protection. > > Signed-off-by: Guido Günther <agx@sigxcpu.org> > +++ b/Documentation/devicetree/bindings/leds/leds-lm3692x.txt > @@ -18,6 +18,10 @@ Required properties: > Optional properties: > - enable-gpios : gpio pin to enable/disable the device. > - vled-supply : LED supply > + - ti,brightness-mapping-exponential: Whether to use exponential > + brightness mapping > + - ti,overvoltage-volts: Overvoltage protection in Volts, can > + be 0 (unprotected), 21, 25 or 29V > We usually use microvolts in various device tree properties... Exponential mapping s not really property of the hardware, is it? Does it belong here or somewhere in the backlight binding? Best regards, Pavel
Hi, On Sat, Dec 21, 2019 at 08:15:15PM +0100, Pavel Machek wrote: > On Mon 2019-12-16 13:28:05, Guido Günther wrote: > > We allow configuration of brightness mode and over voltage > > protection. > > > > Signed-off-by: Guido Günther <agx@sigxcpu.org> > > +++ b/Documentation/devicetree/bindings/leds/leds-lm3692x.txt > > @@ -18,6 +18,10 @@ Required properties: > > Optional properties: > > - enable-gpios : gpio pin to enable/disable the device. > > - vled-supply : LED supply > > + - ti,brightness-mapping-exponential: Whether to use exponential > > + brightness mapping > > + - ti,overvoltage-volts: Overvoltage protection in Volts, can > > + be 0 (unprotected), 21, 25 or 29V > > > > We usually use microvolts in various device tree properties... Make sense. > Exponential mapping s not really property of the hardware, is it? Does > it belong here or somewhere in the backlight binding? I opted for having it with the hardware since the property can't be configured per backlight led strip individually. Cheers, -- Guido > Best regards, > Pavel > -- > (english) http://www.livejournal.com/~pavelmachek > (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
On Mon, Dec 16, 2019 at 01:28:05PM +0100, Guido Günther wrote: > We allow configuration of brightness mode and over voltage > protection. > > Signed-off-by: Guido Günther <agx@sigxcpu.org> > --- > Documentation/devicetree/bindings/leds/leds-lm3692x.txt | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/Documentation/devicetree/bindings/leds/leds-lm3692x.txt b/Documentation/devicetree/bindings/leds/leds-lm3692x.txt > index 4c2d923f8758..f195e8b45d85 100644 > --- a/Documentation/devicetree/bindings/leds/leds-lm3692x.txt > +++ b/Documentation/devicetree/bindings/leds/leds-lm3692x.txt > @@ -18,6 +18,10 @@ Required properties: > Optional properties: > - enable-gpios : gpio pin to enable/disable the device. > - vled-supply : LED supply > + - ti,brightness-mapping-exponential: Whether to use exponential > + brightness mapping > + - ti,overvoltage-volts: Overvoltage protection in Volts, can > + be 0 (unprotected), 21, 25 or 29V '-microvolt' is the standard unit suffix. > > Required child properties: > - reg : 0 - Will enable all LED sync paths > -- > 2.23.0 >
Hi, On Thu, Dec 26, 2019 at 12:19:06PM -0700, Rob Herring wrote: > On Mon, Dec 16, 2019 at 01:28:05PM +0100, Guido Günther wrote: > > We allow configuration of brightness mode and over voltage > > protection. > > > > Signed-off-by: Guido Günther <agx@sigxcpu.org> > > --- > > Documentation/devicetree/bindings/leds/leds-lm3692x.txt | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/leds/leds-lm3692x.txt b/Documentation/devicetree/bindings/leds/leds-lm3692x.txt > > index 4c2d923f8758..f195e8b45d85 100644 > > --- a/Documentation/devicetree/bindings/leds/leds-lm3692x.txt > > +++ b/Documentation/devicetree/bindings/leds/leds-lm3692x.txt > > @@ -18,6 +18,10 @@ Required properties: > > Optional properties: > > - enable-gpios : gpio pin to enable/disable the device. > > - vled-supply : LED supply > > + - ti,brightness-mapping-exponential: Whether to use exponential > > + brightness mapping > > + - ti,overvoltage-volts: Overvoltage protection in Volts, can > > + be 0 (unprotected), 21, 25 or 29V > > '-microvolt' is the standard unit suffix. Fixed in v2: https://lore.kernel.org/linux-leds/20191226100615.GA4033@amd/T/#u Cheers, -- Guido > > > > > Required child properties: > > - reg : 0 - Will enable all LED sync paths > > -- > > 2.23.0 > > >
diff --git a/Documentation/devicetree/bindings/leds/leds-lm3692x.txt b/Documentation/devicetree/bindings/leds/leds-lm3692x.txt index 4c2d923f8758..f195e8b45d85 100644 --- a/Documentation/devicetree/bindings/leds/leds-lm3692x.txt +++ b/Documentation/devicetree/bindings/leds/leds-lm3692x.txt @@ -18,6 +18,10 @@ Required properties: Optional properties: - enable-gpios : gpio pin to enable/disable the device. - vled-supply : LED supply + - ti,brightness-mapping-exponential: Whether to use exponential + brightness mapping + - ti,overvoltage-volts: Overvoltage protection in Volts, can + be 0 (unprotected), 21, 25 or 29V Required child properties: - reg : 0 - Will enable all LED sync paths
We allow configuration of brightness mode and over voltage protection. Signed-off-by: Guido Günther <agx@sigxcpu.org> --- Documentation/devicetree/bindings/leds/leds-lm3692x.txt | 4 ++++ 1 file changed, 4 insertions(+)