| Message ID | e64595c27468e392826f0afb5f18b68ce258787a.1575779993.git.lucien.xin@gmail.com |
|---|---|
| State | Changes Requested |
| Delegated to: | Pablo Neira |
| Headers | show |
| Series | netfilter: nft_tunnel: reinforce key opts support | expand |
On Sun, Dec 08, 2019 at 12:41:34PM +0800, Xin Long wrote: > This is not necessary, but it'll be easier to parse in userspace, > also given that other places like act_tunnel_key, cls_flower and > ip_tunnel_core are also doing so. > > Signed-off-by: Xin Long <lucien.xin@gmail.com> Acked-by: Pablo Neira Ayuso <pablo@netfilter.org>
diff --git a/net/netfilter/nft_tunnel.c b/net/netfilter/nft_tunnel.c index e1184fa..576437f 100644 --- a/net/netfilter/nft_tunnel.c +++ b/net/netfilter/nft_tunnel.c @@ -479,6 +479,9 @@ static int nft_tunnel_opts_dump(struct sk_buff *skb, opts->u.vxlan.gbp)) return -1; } else if (opts->flags & TUNNEL_ERSPAN_OPT) { + if (nla_put_u8(skb, NFTA_TUNNEL_KEY_ERSPAN_VERSION, + opts->u.erspan.version)) + return -1; switch (opts->u.erspan.version) { case ERSPAN_VERSION: if (nla_put_be32(skb, NFTA_TUNNEL_KEY_ERSPAN_V1_INDEX,
This is not necessary, but it'll be easier to parse in userspace, also given that other places like act_tunnel_key, cls_flower and ip_tunnel_core are also doing so. Signed-off-by: Xin Long <lucien.xin@gmail.com> --- net/netfilter/nft_tunnel.c | 3 +++ 1 file changed, 3 insertions(+)