| Message ID | 1576078359-9220-1-git-send-email-tlfalcon@linux.ibm.com |
|---|---|
| State | Superseded |
| Delegated to: | David Miller |
| Headers | show |
| Series | net/ibmvnic: Fix typo in retry check | expand |
On 12/11/19 9:32 AM, Thomas Falcon wrote: > This conditional is missing a bang, with the intent > being to break when the retry count reaches zero. > > Fixes: 476d96ca9c ("ibmvnic: Bound waits for device queries") > Suggested-by: Juliet Kim <minkim@linux.ibm.com> > Signed-off-by: Thomas Falcon <tlfalcon@linux.ibm.com> > --- Excuse me, disregard this patch. I used the wrong email address for Juliet. And forgot the intended branch. I will resend a v2 soon. Tom > drivers/net/ethernet/ibm/ibmvnic.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/ibm/ibmvnic.c b/drivers/net/ethernet/ibm/ibmvnic.c > index efb0f10..2d84523 100644 > --- a/drivers/net/ethernet/ibm/ibmvnic.c > +++ b/drivers/net/ethernet/ibm/ibmvnic.c > @@ -184,7 +184,7 @@ static int ibmvnic_wait_for_completion(struct ibmvnic_adapter *adapter, > netdev_err(netdev, "Device down!\n"); > return -ENODEV; > } > - if (retry--) > + if (!retry--) > break; > if (wait_for_completion_timeout(comp_done, div_timeout)) > return 0;
diff --git a/drivers/net/ethernet/ibm/ibmvnic.c b/drivers/net/ethernet/ibm/ibmvnic.c index efb0f10..2d84523 100644 --- a/drivers/net/ethernet/ibm/ibmvnic.c +++ b/drivers/net/ethernet/ibm/ibmvnic.c @@ -184,7 +184,7 @@ static int ibmvnic_wait_for_completion(struct ibmvnic_adapter *adapter, netdev_err(netdev, "Device down!\n"); return -ENODEV; } - if (retry--) + if (!retry--) break; if (wait_for_completion_timeout(comp_done, div_timeout)) return 0;
This conditional is missing a bang, with the intent being to break when the retry count reaches zero. Fixes: 476d96ca9c ("ibmvnic: Bound waits for device queries") Suggested-by: Juliet Kim <minkim@linux.ibm.com> Signed-off-by: Thomas Falcon <tlfalcon@linux.ibm.com> --- drivers/net/ethernet/ibm/ibmvnic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)