mbox series

[0/2] can: fix USB altsetting bugs

Message ID 20191210113231.3797-1-johan@kernel.org
Headers show
Series can: fix USB altsetting bugs | expand

Message

Johan Hovold Dec. 10, 2019, 11:32 a.m. UTC 
We had quite a few driver using the first alternate setting instead of
the current one when doing descriptor sanity checks. This is mostly an
issue on kernels with panic_on_warn set due to a WARN() in
usb_submit_urn(). Since we've started backporting such fixes (e.g. as
reported by syzbot), I've marked these for stable as well.

The second patch here is a related cleanup to prevent future issues.

Johan


Johan Hovold (2):
  can: kvaser_usb: fix interface sanity check
  can: gs_usb: use descriptors of current altsetting

 drivers/net/can/usb/gs_usb.c                      | 4 ++--
 drivers/net/can/usb/kvaser_usb/kvaser_usb_hydra.c | 2 +-
 drivers/net/can/usb/kvaser_usb/kvaser_usb_leaf.c  | 2 +-
 3 files changed, 4 insertions(+), 4 deletions(-)

Comments

Marc Kleine-Budde Dec. 10, 2019, 11:40 a.m. UTC | #1 
On 12/10/19 12:32 PM, Johan Hovold wrote:
> We had quite a few driver using the first alternate setting instead of
> the current one when doing descriptor sanity checks. This is mostly an
> issue on kernels with panic_on_warn set due to a WARN() in
> usb_submit_urn(). Since we've started backporting such fixes (e.g. as
> reported by syzbot), I've marked these for stable as well.
> 
> The second patch here is a related cleanup to prevent future issues.

Applied both to linux-can.

Tnx,
Marc