mbox series

[net-next,v2,0/2] Rebase of patches

Message ID 20191209175943.23110-1-dmurphy@ti.com
Headers show
Series Rebase of patches | expand

Message

Dan Murphy Dec. 9, 2019, 5:59 p.m. UTC
Hello

This is a rebase of the dp83867 patches on top of the net-next tree

Dan

Dan Murphy (2):
  dt-bindings: dp83867: Convert fifo-depth to common fifo-depth and make
    optional
  net: phy: dp83867: Add rx-fifo-depth and tx-fifo-depth

 .../devicetree/bindings/net/ti,dp83867.txt    | 12 +++-
 drivers/net/phy/dp83867.c                     | 62 +++++++++++++++----
 2 files changed, 58 insertions(+), 16 deletions(-)

Comments

David Miller Dec. 9, 2019, 6:10 p.m. UTC | #1
From: Dan Murphy <dmurphy@ti.com>
Date: Mon, 9 Dec 2019 11:59:41 -0600

> This is a rebase of the dp83867 patches on top of the net-next tree

That's not what this patch series does.

The introductory posting is where you describe, at a high level, what the
whole patch series is doing as a unit, how it is doing it, and why it is
doing it that way.

It also serves as the single email I can respond to when I want to let you
know that I've applied the patch series.

Please read the documentation under Documentation/ if you still are unsure
what this introductory posting is all about and how you should compose one.

Thank you.
Dan Murphy Dec. 9, 2019, 6:23 p.m. UTC | #2
David

On 12/9/19 12:10 PM, David Miller wrote:
> From: Dan Murphy <dmurphy@ti.com>
> Date: Mon, 9 Dec 2019 11:59:41 -0600
>
>> This is a rebase of the dp83867 patches on top of the net-next tree
> That's not what this patch series does.
>
> The introductory posting is where you describe, at a high level, what the
> whole patch series is doing as a unit, how it is doing it, and why it is
> doing it that way.
>
> It also serves as the single email I can respond to when I want to let you
> know that I've applied the patch series.
>
> Please read the documentation under Documentation/ if you still are unsure
> what this introductory posting is all about and how you should compose one.
>
> Thank you.

I understand what a cover letter is.

I don't normally see cover letters required for small patchsets like 
this in other trees.  The commit messages should explain in detail what 
is being changed as the cover letters are not committed to the kernel.  
I only add cover letters when the patchsets are significant, per the 
Documentation/ you eluded to.

But if you require this for the linux net tree then I can add them as I 
move forward it is not a problem either way.

Dan
David Miller Dec. 9, 2019, 6:31 p.m. UTC | #3
From: Dan Murphy <dmurphy@ti.com>
Date: Mon, 9 Dec 2019 12:23:46 -0600

> I understand what a cover letter is.

As seen below, perhaps you don't

> The commit messages should explain in detail
> what is being changed as the cover letters are not committed to the
> kernel.

Not true.

I _always_ add them, for every networking patch series.

They go into the merge commit I create for your patch series.